Re: [PATCH v7 16/46] virtio_blk: v1.0 support

2014-12-01 Thread Cornelia Huck
On Mon, 1 Dec 2014 15:47:19 +0200 "Michael S. Tsirkin" wrote: > On Mon, Dec 01, 2014 at 02:00:04PM +0100, Cornelia Huck wrote: > > On Mon, 1 Dec 2014 14:51:26 +0200 > > "Michael S. Tsirkin" wrote: > > > > > On Mon, Dec 01, 2014 at 01:40:36PM +0100, Cornelia Huck wrote: > > > > On Mon, 1 Dec 201

Re: [PATCH v7 16/46] virtio_blk: v1.0 support

2014-12-01 Thread Michael S. Tsirkin
On Mon, Dec 01, 2014 at 02:00:04PM +0100, Cornelia Huck wrote: > On Mon, 1 Dec 2014 14:51:26 +0200 > "Michael S. Tsirkin" wrote: > > > On Mon, Dec 01, 2014 at 01:40:36PM +0100, Cornelia Huck wrote: > > > On Mon, 1 Dec 2014 14:34:55 +0200 > > > "Michael S. Tsirkin" wrote: > > > > > > > On Mon, D

Re: [PATCH v7 16/46] virtio_blk: v1.0 support

2014-12-01 Thread Cornelia Huck
On Mon, 1 Dec 2014 14:51:26 +0200 "Michael S. Tsirkin" wrote: > On Mon, Dec 01, 2014 at 01:40:36PM +0100, Cornelia Huck wrote: > > On Mon, 1 Dec 2014 14:34:55 +0200 > > "Michael S. Tsirkin" wrote: > > > > > On Mon, Dec 01, 2014 at 01:02:58PM +0100, Cornelia Huck wrote: > > > > On Mon, 1 Dec 201

Re: [PATCH v7 16/46] virtio_blk: v1.0 support

2014-12-01 Thread Michael S. Tsirkin
On Mon, Dec 01, 2014 at 01:40:36PM +0100, Cornelia Huck wrote: > On Mon, 1 Dec 2014 14:34:55 +0200 > "Michael S. Tsirkin" wrote: > > > On Mon, Dec 01, 2014 at 01:02:58PM +0100, Cornelia Huck wrote: > > > On Mon, 1 Dec 2014 13:46:45 +0200 > > > "Michael S. Tsirkin" wrote: > > > > > > > On Mon, D

Re: [PATCH v7 16/46] virtio_blk: v1.0 support

2014-12-01 Thread Cornelia Huck
On Mon, 1 Dec 2014 14:34:55 +0200 "Michael S. Tsirkin" wrote: > On Mon, Dec 01, 2014 at 01:02:58PM +0100, Cornelia Huck wrote: > > On Mon, 1 Dec 2014 13:46:45 +0200 > > "Michael S. Tsirkin" wrote: > > > > > On Mon, Dec 01, 2014 at 12:33:15PM +0100, Cornelia Huck wrote: > > > > On Mon, 1 Dec 201

Re: [PATCH v7 16/46] virtio_blk: v1.0 support

2014-12-01 Thread Michael S. Tsirkin
On Mon, Dec 01, 2014 at 01:02:58PM +0100, Cornelia Huck wrote: > On Mon, 1 Dec 2014 13:46:45 +0200 > "Michael S. Tsirkin" wrote: > > > On Mon, Dec 01, 2014 at 12:33:15PM +0100, Cornelia Huck wrote: > > > On Mon, 1 Dec 2014 11:26:58 +0200 > > > "Michael S. Tsirkin" wrote: > > > > > > > For some

Re: [PATCH v7 16/46] virtio_blk: v1.0 support

2014-12-01 Thread Michael S. Tsirkin
On Mon, Dec 01, 2014 at 01:02:58PM +0100, Cornelia Huck wrote: > On Mon, 1 Dec 2014 13:46:45 +0200 > "Michael S. Tsirkin" wrote: > > > On Mon, Dec 01, 2014 at 12:33:15PM +0100, Cornelia Huck wrote: > > > On Mon, 1 Dec 2014 11:26:58 +0200 > > > "Michael S. Tsirkin" wrote: > > > > > > > For some

Re: [PATCH v7 16/46] virtio_blk: v1.0 support

2014-12-01 Thread Cornelia Huck
On Mon, 1 Dec 2014 13:46:45 +0200 "Michael S. Tsirkin" wrote: > On Mon, Dec 01, 2014 at 12:33:15PM +0100, Cornelia Huck wrote: > > On Mon, 1 Dec 2014 11:26:58 +0200 > > "Michael S. Tsirkin" wrote: > > > > > For some places on data path, it might be worth it > > > to cache the correct value e.g.

Re: [PATCH v7 16/46] virtio_blk: v1.0 support

2014-12-01 Thread Michael S. Tsirkin
On Mon, Dec 01, 2014 at 12:33:15PM +0100, Cornelia Huck wrote: > On Mon, 1 Dec 2014 11:26:58 +0200 > "Michael S. Tsirkin" wrote: > > > For some places on data path, it might be worth it > > to cache the correct value e.g. as part of device > > structure. This replaces a branch with a memory load,

Re: [PATCH v7 16/46] virtio_blk: v1.0 support

2014-12-01 Thread Cornelia Huck
On Mon, 1 Dec 2014 11:26:58 +0200 "Michael S. Tsirkin" wrote: > For some places on data path, it might be worth it > to cache the correct value e.g. as part of device > structure. This replaces a branch with a memory load, > so the gain would have to be measured, best done > separately? I think

Re: [PATCH v7 16/46] virtio_blk: v1.0 support

2014-12-01 Thread Cornelia Huck
On Mon, 1 Dec 2014 11:01:36 +0100 David Hildenbrand wrote: > > On Mon, Dec 01, 2014 at 09:16:41AM +0100, David Hildenbrand wrote: > > > > Based on patch by Cornelia Huck. > > > > > > > > Note: for consistency, and to avoid sparse errors, > > > > convert all fields, even those no longer in

Re: [PATCH v7 16/46] virtio_blk: v1.0 support

2014-12-01 Thread David Hildenbrand
> On Mon, Dec 01, 2014 at 09:16:41AM +0100, David Hildenbrand wrote: > > > Based on patch by Cornelia Huck. > > > > > > Note: for consistency, and to avoid sparse errors, > > > convert all fields, even those no longer in use > > > for virtio v1.0. > > > > > > Signed-off-by: Cornelia H

Re: [PATCH v7 16/46] virtio_blk: v1.0 support

2014-12-01 Thread Michael S. Tsirkin
On Mon, Dec 01, 2014 at 09:16:41AM +0100, David Hildenbrand wrote: > > Based on patch by Cornelia Huck. > > > > Note: for consistency, and to avoid sparse errors, > > convert all fields, even those no longer in use > > for virtio v1.0. > > > > Signed-off-by: Cornelia Huck > > Signed-

Re: [PATCH v7 16/46] virtio_blk: v1.0 support

2014-12-01 Thread Michael S. Tsirkin
On Mon, Dec 01, 2014 at 09:16:41AM +0100, David Hildenbrand wrote: > > Based on patch by Cornelia Huck. > > > > Note: for consistency, and to avoid sparse errors, > > convert all fields, even those no longer in use > > for virtio v1.0. > > > > Signed-off-by: Cornelia Huck > > Signed-

Re: [PATCH v7 16/46] virtio_blk: v1.0 support

2014-12-01 Thread David Hildenbrand
> Based on patch by Cornelia Huck. > > Note: for consistency, and to avoid sparse errors, > convert all fields, even those no longer in use > for virtio v1.0. > > Signed-off-by: Cornelia Huck > Signed-off-by: Michael S. Tsirkin ... > > -static unsigned int features[] = { > +static

[PATCH v7 16/46] virtio_blk: v1.0 support

2014-11-30 Thread Michael S. Tsirkin
Based on patch by Cornelia Huck. Note: for consistency, and to avoid sparse errors, convert all fields, even those no longer in use for virtio v1.0. Signed-off-by: Cornelia Huck Signed-off-by: Michael S. Tsirkin --- include/uapi/linux/virtio_blk.h | 15 - drivers/block/virt