Re: [PATCH v7 2/2] Kbuild: implement support for DWARF v5

2021-02-03 Thread Masahiro Yamada
On Thu, Feb 4, 2021 at 8:27 AM Nick Desaulniers wrote: > > On Wed, Feb 3, 2021 at 3:07 PM Masahiro Yamada wrote: > > > > Nick, the patch set is getting simpler and simpler, > > and almost good enough to be merged. > > I agree. I think Sedat pointed out a binutils 2.35.2 release; thanks > to

Re: [PATCH v7 2/2] Kbuild: implement support for DWARF v5

2021-02-03 Thread Masahiro Yamada
On Thu, Feb 4, 2021 at 8:36 AM Jakub Jelinek wrote: > > On Thu, Feb 04, 2021 at 08:06:12AM +0900, Masahiro Yamada wrote: > > GCC never outputs '.file 0', which is why > > this test is only needed for Clang, correct? > > No, GCC outputs .file 0 if it during configure time detected assembler that >

Re: [PATCH v7 2/2] Kbuild: implement support for DWARF v5

2021-02-03 Thread Jakub Jelinek
On Thu, Feb 04, 2021 at 08:06:12AM +0900, Masahiro Yamada wrote: > GCC never outputs '.file 0', which is why > this test is only needed for Clang, correct? No, GCC outputs .file 0 if it during configure time detected assembler that supports it and doesn't have any of the known bugs related to it.

Re: [PATCH v7 2/2] Kbuild: implement support for DWARF v5

2021-02-03 Thread Nick Desaulniers
On Wed, Feb 3, 2021 at 3:07 PM Masahiro Yamada wrote: > > Nick, the patch set is getting simpler and simpler, > and almost good enough to be merged. I agree. I think Sedat pointed out a binutils 2.35.2 release; thanks to Nick Clifton for that. > > > Please let me ask two questions below. > >

Re: [PATCH v7 2/2] Kbuild: implement support for DWARF v5

2021-02-03 Thread Masahiro Yamada
On Sat, Jan 30, 2021 at 9:44 AM 'Nick Desaulniers' via Clang Built Linux wrote: > > DWARF v5 is the latest standard of the DWARF debug info format. > > Feature detection of DWARF5 is onerous, especially given that we've > removed $(AS), so we must query $(CC) for DWARF5 assembler directive >

Re: [PATCH v7 2/2] Kbuild: implement support for DWARF v5

2021-01-30 Thread Sedat Dilek
On Sun, Jan 31, 2021 at 1:37 AM Fāng-ruì Sòng wrote: > > On Sat, Jan 30, 2021 at 3:10 PM Sedat Dilek wrote: > > > > On Sat, Jan 30, 2021 at 1:44 AM Nick Desaulniers > > wrote: > > > > > > DWARF v5 is the latest standard of the DWARF debug info format. > > > > > > Feature detection of DWARF5 is

Re: [PATCH v7 2/2] Kbuild: implement support for DWARF v5

2021-01-30 Thread Fāng-ruì Sòng
On Sat, Jan 30, 2021 at 3:10 PM Sedat Dilek wrote: > > On Sat, Jan 30, 2021 at 1:44 AM Nick Desaulniers > wrote: > > > > DWARF v5 is the latest standard of the DWARF debug info format. > > > > Feature detection of DWARF5 is onerous, especially given that we've > > removed $(AS), so we must query

Re: [PATCH v7 2/2] Kbuild: implement support for DWARF v5

2021-01-30 Thread Sedat Dilek
On Sun, Jan 31, 2021 at 12:10 AM Sedat Dilek wrote: > > On Sat, Jan 30, 2021 at 1:44 AM Nick Desaulniers > wrote: > > > > DWARF v5 is the latest standard of the DWARF debug info format. > > > > Feature detection of DWARF5 is onerous, especially given that we've > > removed $(AS), so we must

Re: [PATCH v7 2/2] Kbuild: implement support for DWARF v5

2021-01-30 Thread Sedat Dilek
On Sat, Jan 30, 2021 at 1:44 AM Nick Desaulniers wrote: > > DWARF v5 is the latest standard of the DWARF debug info format. > > Feature detection of DWARF5 is onerous, especially given that we've > removed $(AS), so we must query $(CC) for DWARF5 assembler directive > support. > > The DWARF

[PATCH v7 2/2] Kbuild: implement support for DWARF v5

2021-01-30 Thread Nick Desaulniers
DWARF v5 is the latest standard of the DWARF debug info format. Feature detection of DWARF5 is onerous, especially given that we've removed $(AS), so we must query $(CC) for DWARF5 assembler directive support. The DWARF version of a binary can be validated with: $ llvm-dwarfdump vmlinux | head

Re: [PATCH v7 2/2] Kbuild: implement support for DWARF v5

2021-01-29 Thread Nathan Chancellor
On Fri, Jan 29, 2021 at 04:44:01PM -0800, Nick Desaulniers wrote: > DWARF v5 is the latest standard of the DWARF debug info format. > > Feature detection of DWARF5 is onerous, especially given that we've > removed $(AS), so we must query $(CC) for DWARF5 assembler directive > support. > > The