Re: [PATCH v7 2/2] cpufreq: qcom-hw: Add support for QCOM cpufreq HW driver

2018-09-24 Thread Matthias Kaehlcke
On Sun, Sep 23, 2018 at 03:10:55PM +0530, Taniya Das wrote: > Hello Matthias, > > Thanks for your review comments. > > On 8/29/2018 11:31 PM, Matthias Kaehlcke wrote: > > Hi Taniya, > > > > On Tue, Jul 24, 2018 at 04:12:50PM +0530, Taniya Das wrote: > > > The CPUfreq HW present in some QCOM chip

Re: [PATCH v7 2/2] cpufreq: qcom-hw: Add support for QCOM cpufreq HW driver

2018-09-24 Thread Matthias Kaehlcke
On Sun, Sep 23, 2018 at 03:18:20PM +0530, Taniya Das wrote: > > > On 9/11/2018 1:00 AM, Matthias Kaehlcke wrote: > > On Tue, Jul 24, 2018 at 04:12:50PM +0530, Taniya Das wrote: > > > The CPUfreq HW present in some QCOM chipsets offloads the steps necessary > > > for changing the frequency of CPUs

Re: [PATCH v7 2/2] cpufreq: qcom-hw: Add support for QCOM cpufreq HW driver

2018-09-23 Thread Taniya Das
On 9/11/2018 1:00 AM, Matthias Kaehlcke wrote: On Tue, Jul 24, 2018 at 04:12:50PM +0530, Taniya Das wrote: The CPUfreq HW present in some QCOM chipsets offloads the steps necessary for changing the frequency of CPUs. The driver implements the cpufreq driver interface for this hardware engine.

Re: [PATCH v7 2/2] cpufreq: qcom-hw: Add support for QCOM cpufreq HW driver

2018-09-23 Thread Taniya Das
Hi Amit, On 9/9/2018 8:04 PM, Amit Kucheria wrote: Hi Taniya, How much have you stressed this driver? I tried it on top of an integration branch based on 4.19-rc2 that we maintain[1] and was able to get the board to reboot fairly easily with just a few "yes > /dev/null &" instances running in

Re: [PATCH v7 2/2] cpufreq: qcom-hw: Add support for QCOM cpufreq HW driver

2018-09-23 Thread Taniya Das
Hello Matthias, Thanks for your review comments. On 8/29/2018 11:31 PM, Matthias Kaehlcke wrote: Hi Taniya, On Tue, Jul 24, 2018 at 04:12:50PM +0530, Taniya Das wrote: The CPUfreq HW present in some QCOM chipsets offloads the steps necessary for changing the frequency of CPUs. The driver impl

Re: [PATCH v7 2/2] cpufreq: qcom-hw: Add support for QCOM cpufreq HW driver

2018-09-23 Thread Taniya Das
Hello Stephen, On 8/24/2018 12:08 AM, Stephen Boyd wrote: Quoting Taniya Das (2018-08-08 03:15:26) On 8/8/2018 11:52 AM, Stephen Boyd wrote: Binding describes hardware controllable by the OS. That's the reality. Let's not add mandatory clock bindings for clocks that the OS can't do anythin

Re: [PATCH v7 2/2] cpufreq: qcom-hw: Add support for QCOM cpufreq HW driver

2018-09-10 Thread Matthias Kaehlcke
On Tue, Jul 24, 2018 at 04:12:50PM +0530, Taniya Das wrote: > The CPUfreq HW present in some QCOM chipsets offloads the steps necessary > for changing the frequency of CPUs. The driver implements the cpufreq > driver interface for this hardware engine. > > Signed-off-by: Saravana Kannan > Signed-

Re: [PATCH v7 2/2] cpufreq: qcom-hw: Add support for QCOM cpufreq HW driver

2018-09-09 Thread Amit Kucheria
Hi Taniya, How much have you stressed this driver? I tried it on top of an integration branch based on 4.19-rc2 that we maintain[1] and was able to get the board to reboot fairly easily with just a few "yes > /dev/null &" instances running in the background. I even tried with interconnect framew

Re: [PATCH v7 2/2] cpufreq: qcom-hw: Add support for QCOM cpufreq HW driver

2018-08-29 Thread Matthias Kaehlcke
Hi Taniya, On Tue, Jul 24, 2018 at 04:12:50PM +0530, Taniya Das wrote: > The CPUfreq HW present in some QCOM chipsets offloads the steps necessary > for changing the frequency of CPUs. The driver implements the cpufreq > driver interface for this hardware engine. > > Signed-off-by: Saravana Kanna

Re: [PATCH v7 2/2] cpufreq: qcom-hw: Add support for QCOM cpufreq HW driver

2018-08-23 Thread Stephen Boyd
Quoting Taniya Das (2018-08-08 03:15:26) > > > On 8/8/2018 11:52 AM, Stephen Boyd wrote: > >> > >> Binding describes hardware controllable by the OS. That's the reality. > >> Let's not add mandatory clock bindings for clocks that the OS can't do > >> anything about. > >> > > > > It seems that yo

Re: [PATCH v7 2/2] cpufreq: qcom-hw: Add support for QCOM cpufreq HW driver

2018-08-08 Thread Taniya Das
On 8/8/2018 11:52 AM, Stephen Boyd wrote: Quoting skan...@codeaurora.org (2018-08-06 13:46:05) On 2018-08-03 15:24, Stephen Boyd wrote: Quoting skan...@codeaurora.org (2018-08-03 12:52:48) On 2018-08-03 12:40, Evan Green wrote: Hi Taniya, On Tue, Jul 24, 2018 at 3:44 AM Taniya Das wrote:

Re: [PATCH v7 2/2] cpufreq: qcom-hw: Add support for QCOM cpufreq HW driver

2018-08-07 Thread Stephen Boyd
Quoting skan...@codeaurora.org (2018-08-06 13:46:05) > On 2018-08-03 15:24, Stephen Boyd wrote: > > Quoting skan...@codeaurora.org (2018-08-03 12:52:48) > >> On 2018-08-03 12:40, Evan Green wrote: > >> > Hi Taniya, > >> > > >> > On Tue, Jul 24, 2018 at 3:44 AM Taniya Das wrote: > >> >> > >> >> +

Re: [PATCH v7 2/2] cpufreq: qcom-hw: Add support for QCOM cpufreq HW driver

2018-08-06 Thread skannan
On 2018-08-03 15:24, Stephen Boyd wrote: Quoting skan...@codeaurora.org (2018-08-03 12:52:48) On 2018-08-03 12:40, Evan Green wrote: > Hi Taniya, > > On Tue, Jul 24, 2018 at 3:44 AM Taniya Das wrote: >> >> + if (src) >> + c->table[i].frequency = c->xo_rate *

Re: [PATCH v7 2/2] cpufreq: qcom-hw: Add support for QCOM cpufreq HW driver

2018-08-03 Thread Stephen Boyd
Quoting skan...@codeaurora.org (2018-08-03 12:52:48) > On 2018-08-03 12:40, Evan Green wrote: > > Hi Taniya, > > > > On Tue, Jul 24, 2018 at 3:44 AM Taniya Das wrote: > >> > >> + if (src) > >> + c->table[i].frequency = c->xo_rate * lval / > >> 1000; > >> +

Re: [PATCH v7 2/2] cpufreq: qcom-hw: Add support for QCOM cpufreq HW driver

2018-08-03 Thread skannan
On 2018-08-03 12:40, Evan Green wrote: Hi Taniya, On Tue, Jul 24, 2018 at 3:44 AM Taniya Das wrote: The CPUfreq HW present in some QCOM chipsets offloads the steps necessary for changing the frequency of CPUs. The driver implements the cpufreq driver interface for this hardware engine. Sig

Re: [PATCH v7 2/2] cpufreq: qcom-hw: Add support for QCOM cpufreq HW driver

2018-08-03 Thread Evan Green
Hi Taniya, On Tue, Jul 24, 2018 at 3:44 AM Taniya Das wrote: > > The CPUfreq HW present in some QCOM chipsets offloads the steps necessary > for changing the frequency of CPUs. The driver implements the cpufreq > driver interface for this hardware engine. > > Signed-off-by: Saravana Kannan > Sig

[PATCH v7 2/2] cpufreq: qcom-hw: Add support for QCOM cpufreq HW driver

2018-07-24 Thread Taniya Das
The CPUfreq HW present in some QCOM chipsets offloads the steps necessary for changing the frequency of CPUs. The driver implements the cpufreq driver interface for this hardware engine. Signed-off-by: Saravana Kannan Signed-off-by: Taniya Das --- drivers/cpufreq/Kconfig.arm | 11 ++ dri