Re: [PATCH v7 2/2] drm/panel: Add JDI LT070ME05000 WUXGA DSI Panel

2016-07-11 Thread Emil Velikov
On 11 July 2016 at 13:31, Vinay Simha wrote: > emil, > > As you had suggested to drop the spurious returns in > jdi_panel_unprepare and drop the return itself. > But as i had mentioned earlier , we cannot drop the return function > and void for jdi_panel_unprepare , since the

Re: [PATCH v7 2/2] drm/panel: Add JDI LT070ME05000 WUXGA DSI Panel

2016-07-11 Thread Emil Velikov
On 11 July 2016 at 13:31, Vinay Simha wrote: > emil, > > As you had suggested to drop the spurious returns in > jdi_panel_unprepare and drop the return itself. > But as i had mentioned earlier , we cannot drop the return function > and void for jdi_panel_unprepare , since the drm fun* requires

Re: [PATCH v7 2/2] drm/panel: Add JDI LT070ME05000 WUXGA DSI Panel

2016-07-11 Thread Vinay Simha
emil, As you had suggested to drop the spurious returns in jdi_panel_unprepare and drop the return itself. But as i had mentioned earlier , we cannot drop the return function and void for jdi_panel_unprepare , since the drm fun* requires int as return type (drm_panel_funcs .unprepare). please do

Re: [PATCH v7 2/2] drm/panel: Add JDI LT070ME05000 WUXGA DSI Panel

2016-07-11 Thread Vinay Simha
emil, As you had suggested to drop the spurious returns in jdi_panel_unprepare and drop the return itself. But as i had mentioned earlier , we cannot drop the return function and void for jdi_panel_unprepare , since the drm fun* requires int as return type (drm_panel_funcs .unprepare). please do

Re: [PATCH v7 2/2] drm/panel: Add JDI LT070ME05000 WUXGA DSI Panel

2016-07-11 Thread Thierry Reding
On Sun, Jul 03, 2016 at 11:52:11PM +0100, Emil Velikov wrote: > On 28 June 2016 at 16:59, Vinay Simha wrote: > > hi, > > > > Any further comments or reviews? > > > You still haven't covered my earlier suggestions, as such I cannot > give you a r-b :-( They are not blockers by

Re: [PATCH v7 2/2] drm/panel: Add JDI LT070ME05000 WUXGA DSI Panel

2016-07-11 Thread Thierry Reding
On Sun, Jul 03, 2016 at 11:52:11PM +0100, Emil Velikov wrote: > On 28 June 2016 at 16:59, Vinay Simha wrote: > > hi, > > > > Any further comments or reviews? > > > You still haven't covered my earlier suggestions, as such I cannot > give you a r-b :-( They are not blockers by any means, but it'll

Re: [PATCH v7 2/2] drm/panel: Add JDI LT070ME05000 WUXGA DSI Panel

2016-07-06 Thread Emil Velikov
On 4 July 2016 at 07:27, Vinay Simha wrote: > On Mon, Jul 4, 2016 at 4:22 AM, Emil Velikov wrote: >> On 28 June 2016 at 16:59, Vinay Simha wrote: >>> hi, >>> >>> Any further comments or reviews? >>> >> You still haven't covered

Re: [PATCH v7 2/2] drm/panel: Add JDI LT070ME05000 WUXGA DSI Panel

2016-07-06 Thread Emil Velikov
On 4 July 2016 at 07:27, Vinay Simha wrote: > On Mon, Jul 4, 2016 at 4:22 AM, Emil Velikov wrote: >> On 28 June 2016 at 16:59, Vinay Simha wrote: >>> hi, >>> >>> Any further comments or reviews? >>> >> You still haven't covered my earlier suggestions, as such I cannot >> give you a r-b :-( They

Re: [PATCH v7 2/2] drm/panel: Add JDI LT070ME05000 WUXGA DSI Panel

2016-07-04 Thread Vinay Simha
On Mon, Jul 4, 2016 at 4:22 AM, Emil Velikov wrote: > On 28 June 2016 at 16:59, Vinay Simha wrote: >> hi, >> >> Any further comments or reviews? >> > You still haven't covered my earlier suggestions, as such I cannot > give you a r-b :-( They are not

Re: [PATCH v7 2/2] drm/panel: Add JDI LT070ME05000 WUXGA DSI Panel

2016-07-04 Thread Vinay Simha
On Mon, Jul 4, 2016 at 4:22 AM, Emil Velikov wrote: > On 28 June 2016 at 16:59, Vinay Simha wrote: >> hi, >> >> Any further comments or reviews? >> > You still haven't covered my earlier suggestions, as such I cannot > give you a r-b :-( They are not blockers by any means, but it'll be > up-to

Re: [PATCH v7 2/2] drm/panel: Add JDI LT070ME05000 WUXGA DSI Panel

2016-07-03 Thread Emil Velikov
On 28 June 2016 at 16:59, Vinay Simha wrote: > hi, > > Any further comments or reviews? > You still haven't covered my earlier suggestions, as such I cannot give you a r-b :-( They are not blockers by any means, but it'll be up-to the maintainer to ack/pick this up. Thierry ?

Re: [PATCH v7 2/2] drm/panel: Add JDI LT070ME05000 WUXGA DSI Panel

2016-07-03 Thread Emil Velikov
On 28 June 2016 at 16:59, Vinay Simha wrote: > hi, > > Any further comments or reviews? > You still haven't covered my earlier suggestions, as such I cannot give you a r-b :-( They are not blockers by any means, but it'll be up-to the maintainer to ack/pick this up. Thierry ? Regards, Emil

Re: [PATCH v7 2/2] drm/panel: Add JDI LT070ME05000 WUXGA DSI Panel

2016-06-28 Thread Vinay Simha
hi, Any further comments or reviews? On Mon, Jun 20, 2016 at 11:23 AM, Vinay Simha BN wrote: > Add support for the JDI LT070ME05000 WUXGA DSI panel used in > Nexus 7 2013 devices. > > Programming sequence for the panel is was originally found in the >

Re: [PATCH v7 2/2] drm/panel: Add JDI LT070ME05000 WUXGA DSI Panel

2016-06-28 Thread Vinay Simha
hi, Any further comments or reviews? On Mon, Jun 20, 2016 at 11:23 AM, Vinay Simha BN wrote: > Add support for the JDI LT070ME05000 WUXGA DSI panel used in > Nexus 7 2013 devices. > > Programming sequence for the panel is was originally found in the > android-msm-flo-3.4-lollipop-release branch

[PATCH v7 2/2] drm/panel: Add JDI LT070ME05000 WUXGA DSI Panel

2016-06-19 Thread Vinay Simha BN
Add support for the JDI LT070ME05000 WUXGA DSI panel used in Nexus 7 2013 devices. Programming sequence for the panel is was originally found in the android-msm-flo-3.4-lollipop-release branch from: https://android.googlesource.com/kernel/msm.git And video mode setting is from

[PATCH v7 2/2] drm/panel: Add JDI LT070ME05000 WUXGA DSI Panel

2016-06-19 Thread Vinay Simha BN
Add support for the JDI LT070ME05000 WUXGA DSI panel used in Nexus 7 2013 devices. Programming sequence for the panel is was originally found in the android-msm-flo-3.4-lollipop-release branch from: https://android.googlesource.com/kernel/msm.git And video mode setting is from