Re: [PATCH v7 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-12-11 Thread Liang Yang
Hi Miquel, On 2018/12/11 17:07, Miquel Raynal wrote: Hi Liang, Liang Yang wrote on Tue, 11 Dec 2018 16:36:47 +0800: Hi Miquel, Thanks for your quickly reply. On 2018/12/11 15:54, Miquel Raynal wrote: Hi Liang, Liang Yang wrote on Tue, 11 Dec 2018 09:56:25 +0800: Hi Miquel, On

Re: [PATCH v7 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-12-11 Thread Liang Yang
Hi Boris, On 2018/12/11 16:39, Boris Brezillon wrote: On Tue, 11 Dec 2018 09:56:25 +0800 Liang Yang wrote: Hi Miquel, On 2018/12/10 22:50, Miquel Raynal wrote: Hi Liang, Liang Yang wrote on Mon, 10 Dec 2018 20:12:39 +0800: On 2018/12/10 19:38, Boris Brezillon wrote: On Mon, 10 Dec

Re: [PATCH v7 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-12-11 Thread Miquel Raynal
Hi Liang, Liang Yang wrote on Tue, 11 Dec 2018 16:36:47 +0800: > Hi Miquel, > > Thanks for your quickly reply. > > On 2018/12/11 15:54, Miquel Raynal wrote: > > Hi Liang, > > > > Liang Yang wrote on Tue, 11 Dec 2018 09:56:25 > > +0800: > > > >> Hi Miquel, > >> > >> On 2018/12/10 22:50,

Re: [PATCH v7 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-12-11 Thread Boris Brezillon
On Tue, 11 Dec 2018 09:56:25 +0800 Liang Yang wrote: > Hi Miquel, > > On 2018/12/10 22:50, Miquel Raynal wrote: > > Hi Liang, > > > > Liang Yang wrote on Mon, 10 Dec 2018 20:12:39 > > +0800: > > > >> On 2018/12/10 19:38, Boris Brezillon wrote: > >>> On Mon, 10 Dec 2018 19:23:46 +0800 >

Re: [PATCH v7 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-12-11 Thread Liang Yang
Hi Miquel, Thanks for your quickly reply. On 2018/12/11 15:54, Miquel Raynal wrote: Hi Liang, Liang Yang wrote on Tue, 11 Dec 2018 09:56:25 +0800: Hi Miquel, On 2018/12/10 22:50, Miquel Raynal wrote: Hi Liang, Liang Yang wrote on Mon, 10 Dec 2018 20:12:39 +0800: On 2018/12/10

Re: [PATCH v7 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-12-10 Thread Miquel Raynal
Hi Liang, Liang Yang wrote on Tue, 11 Dec 2018 09:56:25 +0800: > Hi Miquel, > > On 2018/12/10 22:50, Miquel Raynal wrote: > > Hi Liang, > > > > Liang Yang wrote on Mon, 10 Dec 2018 20:12:39 > > +0800: > > > >> On 2018/12/10 19:38, Boris Brezillon wrote: > >>> On Mon, 10 Dec 2018

Re: [PATCH v7 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-12-10 Thread Liang Yang
Hi Miquel, On 2018/12/10 22:50, Miquel Raynal wrote: Hi Liang, Liang Yang wrote on Mon, 10 Dec 2018 20:12:39 +0800: On 2018/12/10 19:38, Boris Brezillon wrote: On Mon, 10 Dec 2018 19:23:46 +0800 Liang Yang wrote: + mtd->ecc_stats.failed++; +

Re: [PATCH v7 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-12-10 Thread Miquel Raynal
Hi Liang, Liang Yang wrote on Mon, 10 Dec 2018 20:12:39 +0800: > On 2018/12/10 19:38, Boris Brezillon wrote: > > On Mon, 10 Dec 2018 19:23:46 +0800 > > Liang Yang wrote: > > > +mtd->ecc_stats.failed++; > +continue; > +

Re: [PATCH v7 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-12-10 Thread Liang Yang
On 2018/12/10 19:38, Boris Brezillon wrote: On Mon, 10 Dec 2018 19:23:46 +0800 Liang Yang wrote: + mtd->ecc_stats.failed++; + continue; + } + mtd->ecc_stats.corrected += ECC_ERR_CNT(*info); + bitflips =

Re: [PATCH v7 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-12-10 Thread Boris Brezillon
On Mon, 10 Dec 2018 19:23:46 +0800 Liang Yang wrote: > >> + mtd->ecc_stats.failed++; > >> + continue; > >> + } > >> + mtd->ecc_stats.corrected += ECC_ERR_CNT(*info); > >> + bitflips = max_t(u32, bitflips, ECC_ERR_CNT(*info)); > >> + }

Re: [PATCH v7 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-12-10 Thread Liang Yang
On 2018/12/7 17:24, Miquel Raynal wrote: Hi Jianxin, Looks good to me overall, a few comments inline. Jianxin Pan wrote on Sat, 17 Nov 2018 00:40:38 +0800: From: Liang Yang Add initial support for the Amlogic NAND flash controller which found in the Meson-GXBB/GXL/AXG SoCs.

Re: [PATCH v7 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-12-07 Thread Miquel Raynal
Hi Liang, Liang Yang wrote on Fri, 7 Dec 2018 18:41:39 +0800: > Hi Miquel, > > Appreciate your time. Sorry for being late to do this review. > I will follow the nand/next and rework some next week as soon as possible. There is no hurry, I don't think the driver will enter 4.21 (or whatever

Re: [PATCH v7 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-12-07 Thread Miquel Raynal
Hi Liang, Liang Yang wrote on Fri, 7 Dec 2018 18:41:39 +0800: > Hi Miquel, > > Appreciate your time. Sorry for being late to do this review. > I will follow the nand/next and rework some next week as soon as possible. There is no hurry, I don't think the driver will enter 4.21 (or whatever

Re: [PATCH v7 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-12-07 Thread Liang Yang
Hi Miquel, Appreciate your time. I will follow the nand/next and rework some next week as soon as possible. On 2018/12/7 17:42, Miquel Raynal wrote: Hi Jianxin, Miquel Raynal wrote on Fri, 7 Dec 2018 10:24:56 +0100: Hi Jianxin, Looks good to me overall, a few comments inline. Jianxin Pan

Re: [PATCH v7 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-12-07 Thread Liang Yang
Hi Miquel, Appreciate your time. I will follow the nand/next and rework some next week as soon as possible. On 2018/12/7 17:42, Miquel Raynal wrote: Hi Jianxin, Miquel Raynal wrote on Fri, 7 Dec 2018 10:24:56 +0100: Hi Jianxin, Looks good to me overall, a few comments inline. Jianxin Pan

Re: [PATCH v7 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-12-07 Thread Miquel Raynal
Hi Jianxin, Miquel Raynal wrote on Fri, 7 Dec 2018 10:24:56 +0100: > Hi Jianxin, > > Looks good to me overall, a few comments inline. > > Jianxin Pan wrote on Sat, 17 Nov 2018 > 00:40:38 +0800: > > > From: Liang Yang > > > > Add initial support for the Amlogic NAND flash controller which

Re: [PATCH v7 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-12-07 Thread Miquel Raynal
Hi Jianxin, Miquel Raynal wrote on Fri, 7 Dec 2018 10:24:56 +0100: > Hi Jianxin, > > Looks good to me overall, a few comments inline. > > Jianxin Pan wrote on Sat, 17 Nov 2018 > 00:40:38 +0800: > > > From: Liang Yang > > > > Add initial support for the Amlogic NAND flash controller which

Re: [PATCH v7 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-12-07 Thread Miquel Raynal
Hi Jianxin, Looks good to me overall, a few comments inline. Jianxin Pan wrote on Sat, 17 Nov 2018 00:40:38 +0800: > From: Liang Yang > > Add initial support for the Amlogic NAND flash controller which found > in the Meson-GXBB/GXL/AXG SoCs. > > Signed-off-by: Liang Yang > Signed-off-by:

Re: [PATCH v7 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-12-07 Thread Miquel Raynal
Hi Jianxin, Looks good to me overall, a few comments inline. Jianxin Pan wrote on Sat, 17 Nov 2018 00:40:38 +0800: > From: Liang Yang > > Add initial support for the Amlogic NAND flash controller which found > in the Meson-GXBB/GXL/AXG SoCs. > > Signed-off-by: Liang Yang > Signed-off-by:

[PATCH v7 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-11-16 Thread Jianxin Pan
From: Liang Yang Add initial support for the Amlogic NAND flash controller which found in the Meson-GXBB/GXL/AXG SoCs. Signed-off-by: Liang Yang Signed-off-by: Yixun Lan Signed-off-by: Jianxin Pan --- drivers/mtd/nand/raw/Kconfig | 10 + drivers/mtd/nand/raw/Makefile |1 +

[PATCH v7 2/2] mtd: rawnand: meson: add support for Amlogic NAND flash controller

2018-11-16 Thread Jianxin Pan
From: Liang Yang Add initial support for the Amlogic NAND flash controller which found in the Meson-GXBB/GXL/AXG SoCs. Signed-off-by: Liang Yang Signed-off-by: Yixun Lan Signed-off-by: Jianxin Pan --- drivers/mtd/nand/raw/Kconfig | 10 + drivers/mtd/nand/raw/Makefile |1 +