Re: [PATCH v7 2/2] s390: virtio: PV needs VIRTIO I/O device protection

2020-08-06 Thread Pierre Morel
On 2020-07-30 13:31, Pierre Morel wrote: ...snip... What bothers me here is that arch code depends on virtio now. It works even with a modular virtio when functions are inline, but it seems fragile: e.g. it breaks virtio as an out of tree module, since layout of struct virtio_device can change

Re: [PATCH v7 2/2] s390: virtio: PV needs VIRTIO I/O device protection

2020-07-30 Thread Pierre Morel
gentle ping. On 2020-07-15 13:51, Michael S. Tsirkin wrote: On Wed, Jul 15, 2020 at 06:16:59PM +0800, Jason Wang wrote: On 2020/7/15 下午5:50, Michael S. Tsirkin wrote: On Wed, Jul 15, 2020 at 10:31:09AM +0200, Pierre Morel wrote: If protected virtualization is active on s390, the virtio qu

Re: [PATCH v7 2/2] s390: virtio: PV needs VIRTIO I/O device protection

2020-07-22 Thread Pierre Morel
On 2020-07-15 13:51, Michael S. Tsirkin wrote: On Wed, Jul 15, 2020 at 06:16:59PM +0800, Jason Wang wrote: On 2020/7/15 下午5:50, Michael S. Tsirkin wrote: On Wed, Jul 15, 2020 at 10:31:09AM +0200, Pierre Morel wrote: If protected virtualization is active on s390, the virtio queues are not a

Re: [PATCH v7 2/2] s390: virtio: PV needs VIRTIO I/O device protection

2020-07-16 Thread Michael S. Tsirkin
On Thu, Jul 16, 2020 at 01:19:55PM +0200, Christian Borntraeger wrote: > > > On 15.07.20 13:51, Michael S. Tsirkin wrote: > > On Wed, Jul 15, 2020 at 06:16:59PM +0800, Jason Wang wrote: > >> > >> On 2020/7/15 下午5:50, Michael S. Tsirkin wrote: > >>> On Wed, Jul 15, 2020 at 10:31:09AM +0200, Pierre

Re: [PATCH v7 2/2] s390: virtio: PV needs VIRTIO I/O device protection

2020-07-16 Thread Christian Borntraeger
On 15.07.20 13:51, Michael S. Tsirkin wrote: > On Wed, Jul 15, 2020 at 06:16:59PM +0800, Jason Wang wrote: >> >> On 2020/7/15 下午5:50, Michael S. Tsirkin wrote: >>> On Wed, Jul 15, 2020 at 10:31:09AM +0200, Pierre Morel wrote: If protected virtualization is active on s390, the virtio queues

Re: [PATCH v7 2/2] s390: virtio: PV needs VIRTIO I/O device protection

2020-07-15 Thread Michael S. Tsirkin
On Wed, Jul 15, 2020 at 06:16:59PM +0800, Jason Wang wrote: > > On 2020/7/15 下午5:50, Michael S. Tsirkin wrote: > > On Wed, Jul 15, 2020 at 10:31:09AM +0200, Pierre Morel wrote: > > > If protected virtualization is active on s390, the virtio queues are > > > not accessible to the host, unless VIRTI

Re: [PATCH v7 2/2] s390: virtio: PV needs VIRTIO I/O device protection

2020-07-15 Thread Jason Wang
On 2020/7/15 下午5:50, Michael S. Tsirkin wrote: On Wed, Jul 15, 2020 at 10:31:09AM +0200, Pierre Morel wrote: If protected virtualization is active on s390, the virtio queues are not accessible to the host, unless VIRTIO_F_IOMMU_PLATFORM has been negotiated. Use the new arch_validate_virtio_fea

Re: [PATCH v7 2/2] s390: virtio: PV needs VIRTIO I/O device protection

2020-07-15 Thread Michael S. Tsirkin
On Wed, Jul 15, 2020 at 10:31:09AM +0200, Pierre Morel wrote: > If protected virtualization is active on s390, the virtio queues are > not accessible to the host, unless VIRTIO_F_IOMMU_PLATFORM has been > negotiated. Use the new arch_validate_virtio_features() interface to > fail probe if that's no

[PATCH v7 2/2] s390: virtio: PV needs VIRTIO I/O device protection

2020-07-15 Thread Pierre Morel
If protected virtualization is active on s390, the virtio queues are not accessible to the host, unless VIRTIO_F_IOMMU_PLATFORM has been negotiated. Use the new arch_validate_virtio_features() interface to fail probe if that's not the case, preventing a host error on access attempt. Signed-off-by: