Re: [PATCH v7 2/3] I2C: mediatek: Add driver for MediaTek I2C controller

2015-05-18 Thread Wolfram Sang
> sh_mobile already implement dmaengine, so its I2C driver can use dma > channel. OK. signature.asc Description: Digital signature

Re: [PATCH v7 2/3] I2C: mediatek: Add driver for MediaTek I2C controller

2015-05-18 Thread Eddie Huang
Hi Wolfram, On Mon, 2015-05-18 at 08:37 +0200, Wolfram Sang wrote: > > > > + rpaddr = dma_map_single(i2c->adap.dev.parent, msgs->buf, > > > > + msgs->len, > > > > DMA_FROM_DEVICE); > > > > > > I think you shouldn't use the adapter devic

Re: [PATCH v7 2/3] I2C: mediatek: Add driver for MediaTek I2C controller

2015-05-17 Thread Wolfram Sang
> > > + rpaddr = dma_map_single(i2c->adap.dev.parent, msgs->buf, > > > + msgs->len, DMA_FROM_DEVICE); > > > > I think you shouldn't use the adapter device here and later, but the dma > > channel device. > > > In MTK SoC, each I2C controller has its

Re: [PATCH v7 2/3] I2C: mediatek: Add driver for MediaTek I2C controller

2015-05-17 Thread Eddie Huang
Hi Wolfram, Narrow down CC-list. Please see my reply below. On Tue, 2015-05-12 at 14:58 +0200, w...@the-dreams.de wrote: > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#inclu

Re: [PATCH v7 2/3] I2C: mediatek: Add driver for MediaTek I2C controller

2015-05-12 Thread wsa
> +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include Please sort the includes to avoid dupl

[PATCH v7 2/3] I2C: mediatek: Add driver for MediaTek I2C controller

2015-05-06 Thread Eddie Huang
From: Xudong Chen The mediatek SoCs have I2C controller that handle I2C transfer. This patch include common I2C bus driver. This driver is compatible with I2C controller on mt65xx/mt81xx. Signed-off-by: Xudong Chen Signed-off-by: Liguo Zhang Signed-off-by: Eddie Huang --- drivers/i2c/busses/