Hi Viresh,
On 2/18/21 11:00 AM, Viresh Kumar wrote:
> On 15-02-21, 07:51, Nicola Mazzucato wrote:
>> +/*
>> + * Add OPPs only on those CPUs for which we haven't already done so.
>> + */
>> nr_opp = dev_pm_opp_get_opp_count(cpu_dev);
>
> Please add a more detailed comment here
On 15-02-21, 07:51, Nicola Mazzucato wrote:
> + /*
> + * Add OPPs only on those CPUs for which we haven't already done so.
> + */
> nr_opp = dev_pm_opp_get_opp_count(cpu_dev);
Please add a more detailed comment here explaining why you expect OPPs
to be present here in advance.
By design, SCMI performance domains define the granularity of
performance controls, they do not describe any underlying hardware
dependencies (although they may match in many cases).
It is therefore possible to have some platforms where hardware may have
the ability to control CPU performance at
3 matches
Mail list logo
