Re: [PATCH v7 2/4] CMDQ: Mediatek CMDQ driver

2016-05-26 Thread Horng-Shyang Liao
Hi CK, Reply in line. On Thu, 2016-05-26 at 15:28 +0800, CK Hu wrote: > Hi, HS: > > Replay inline. > > On Tue, 2016-05-24 at 20:27 +0800, Horng-Shyang Liao wrote: > > Hi CK, > > > > Reply in line. > > > > On Tue, 2016-05-24 at 11:05 +0800, CK Hu wrote: > > > Hi, HS: > > > > > > Some comments

Re: [PATCH v7 2/4] CMDQ: Mediatek CMDQ driver

2016-05-26 Thread CK Hu
Hi, HS: Replay inline. On Tue, 2016-05-24 at 20:27 +0800, Horng-Shyang Liao wrote: > Hi CK, > > Reply in line. > > On Tue, 2016-05-24 at 11:05 +0800, CK Hu wrote: > > Hi, HS: > > > > Some comments below. > > > ... > > > +static void cmdq_thread_irq_handler(struct cmdq *cmdq, int tid) > > > +{

Re: [PATCH v7 2/4] CMDQ: Mediatek CMDQ driver

2016-05-24 Thread Horng-Shyang Liao
Hi CK, Reply in line. On Tue, 2016-05-24 at 11:05 +0800, CK Hu wrote: > Hi, HS: > > Some comments below. > > On Mon, 2016-05-23 at 20:23 +0800, HS Liao wrote: ... > > +struct cmdq_task { > > + struct cmdq *cmdq; > > + struct list_headlist_entry; > > + enum cmdq_task_st

Re: [PATCH v7 2/4] CMDQ: Mediatek CMDQ driver

2016-05-23 Thread CK Hu
Hi, HS: Some comments below. On Mon, 2016-05-23 at 20:23 +0800, HS Liao wrote: > This patch is first version of Mediatek Command Queue(CMDQ) driver. The > CMDQ is used to help read/write registers with critical time limitation, > such as updating display configuration during the vblank. It contro

[PATCH v7 2/4] CMDQ: Mediatek CMDQ driver

2016-05-23 Thread HS Liao
This patch is first version of Mediatek Command Queue(CMDQ) driver. The CMDQ is used to help read/write registers with critical time limitation, such as updating display configuration during the vblank. It controls Global Command Engine (GCE) hardware to achieve this requirement. Currently, CMDQ on