Re: [PATCH v7 2/5] dt-bindings: leds: Add LED_COLOR_ID_MOONLIGHT definitions

2020-11-24 Thread Jacek Anaszewski
On 11/24/20 8:33 AM, Gene Chen wrote: Jacek Anaszewski 於 2020年11月24日 週二 上午4:52寫道: On 11/23/20 4:00 AM, Gene Chen wrote: Jacek Anaszewski 於 2020年11月20日 週五 上午6:26寫道: On 11/19/20 10:57 PM, Pavel Machek wrote: On Thu 2020-11-19 22:03:14, Jacek Anaszewski wrote: Hi Pavel, Gene, On 11/18/20

Re: [PATCH v7 2/5] dt-bindings: leds: Add LED_COLOR_ID_MOONLIGHT definitions

2020-11-24 Thread Gene Chen
Fix Typo. Gene Chen 於 2020年11月24日 週二 下午3:33寫道: > > Jacek Anaszewski 於 2020年11月24日 週二 上午4:52寫道: > > > > On 11/23/20 4:00 AM, Gene Chen wrote: > > > Jacek Anaszewski 於 2020年11月20日 週五 上午6:26寫道: > > >> > > >> On 11/19/20 10:57 PM, Pavel Machek wrote: > > >>> On Thu 2020-11-19 22:03:14, Jacek

Re: [PATCH v7 2/5] dt-bindings: leds: Add LED_COLOR_ID_MOONLIGHT definitions

2020-11-23 Thread Gene Chen
Jacek Anaszewski 於 2020年11月24日 週二 上午4:52寫道: > > On 11/23/20 4:00 AM, Gene Chen wrote: > > Jacek Anaszewski 於 2020年11月20日 週五 上午6:26寫道: > >> > >> On 11/19/20 10:57 PM, Pavel Machek wrote: > >>> On Thu 2020-11-19 22:03:14, Jacek Anaszewski wrote: > Hi Pavel, Gene, > > On 11/18/20

Re: [PATCH v7 2/5] dt-bindings: leds: Add LED_COLOR_ID_MOONLIGHT definitions

2020-11-23 Thread Jacek Anaszewski
On 11/23/20 4:00 AM, Gene Chen wrote: Jacek Anaszewski 於 2020年11月20日 週五 上午6:26寫道: On 11/19/20 10:57 PM, Pavel Machek wrote: On Thu 2020-11-19 22:03:14, Jacek Anaszewski wrote: Hi Pavel, Gene, On 11/18/20 10:37 PM, Pavel Machek wrote: Hi! From: Gene Chen Add LED_COLOR_ID_MOONLIGHT

Re: [PATCH v7 2/5] dt-bindings: leds: Add LED_COLOR_ID_MOONLIGHT definitions

2020-11-22 Thread Gene Chen
Jacek Anaszewski 於 2020年11月20日 週五 上午6:26寫道: > > On 11/19/20 10:57 PM, Pavel Machek wrote: > > On Thu 2020-11-19 22:03:14, Jacek Anaszewski wrote: > >> Hi Pavel, Gene, > >> > >> On 11/18/20 10:37 PM, Pavel Machek wrote: > >>> Hi! > >>> > From: Gene Chen > > Add

Re: [PATCH v7 2/5] dt-bindings: leds: Add LED_COLOR_ID_MOONLIGHT definitions

2020-11-19 Thread Jacek Anaszewski
On 11/19/20 10:57 PM, Pavel Machek wrote: On Thu 2020-11-19 22:03:14, Jacek Anaszewski wrote: Hi Pavel, Gene, On 11/18/20 10:37 PM, Pavel Machek wrote: Hi! From: Gene Chen Add LED_COLOR_ID_MOONLIGHT definitions Why is moonlight a color? Camera flashes are usually white, no? At least it

Re: [PATCH v7 2/5] dt-bindings: leds: Add LED_COLOR_ID_MOONLIGHT definitions

2020-11-19 Thread Pavel Machek
On Thu 2020-11-19 22:03:14, Jacek Anaszewski wrote: > Hi Pavel, Gene, > > On 11/18/20 10:37 PM, Pavel Machek wrote: > >Hi! > > > >>From: Gene Chen > >> > >>Add LED_COLOR_ID_MOONLIGHT definitions > > > >Why is moonlight a color? Camera flashes are usually white, no? > > > >At least it needs a

Re: [PATCH v7 2/5] dt-bindings: leds: Add LED_COLOR_ID_MOONLIGHT definitions

2020-11-19 Thread Jacek Anaszewski
Hi Pavel, Gene, On 11/18/20 10:37 PM, Pavel Machek wrote: Hi! From: Gene Chen Add LED_COLOR_ID_MOONLIGHT definitions Why is moonlight a color? Camera flashes are usually white, no? At least it needs a comment... That's my fault, In fact I should have asked about adding

Re: [PATCH v7 2/5] dt-bindings: leds: Add LED_COLOR_ID_MOONLIGHT definitions

2020-11-19 Thread Pavel Machek
Hi! > > > Moonlight has more current level(150mA) from general RGB LED (24mA). > > > It can be used as night-light and usually use color AMBER. > > > Camera flashes are usually use two flash LED. One is YELLOW, and one > > >is WHITE. > > > > From what I seen, night-lights are usually differetent

Re: [PATCH v7 2/5] dt-bindings: leds: Add LED_COLOR_ID_MOONLIGHT definitions

2020-11-18 Thread Gene Chen
Pavel Machek 於 2020年11月19日 週四 下午3:44寫道: > > Hi! > > > > > From: Gene Chen > > > > > > > > Add LED_COLOR_ID_MOONLIGHT definitions > > > > > > Why is moonlight a color? Camera flashes are usually white, no? > > > > > > At least it needs a comment... > > > > > > Best regards, > > >

Re: [PATCH v7 2/5] dt-bindings: leds: Add LED_COLOR_ID_MOONLIGHT definitions

2020-11-18 Thread Pavel Machek
Hi! > > > From: Gene Chen > > > > > > Add LED_COLOR_ID_MOONLIGHT definitions > > > > Why is moonlight a color? Camera flashes are usually white, no? > > > > At least it needs a comment... > > > > Best regards, > > Pavel > > > >

Re: [PATCH v7 2/5] dt-bindings: leds: Add LED_COLOR_ID_MOONLIGHT definitions

2020-11-18 Thread Gene Chen
Pavel Machek 於 2020年11月19日 週四 上午5:37寫道: > > Hi! > > > From: Gene Chen > > > > Add LED_COLOR_ID_MOONLIGHT definitions > > Why is moonlight a color? Camera flashes are usually white, no? > > At least it needs a comment... > > Best regards, >

Re: [PATCH v7 2/5] dt-bindings: leds: Add LED_COLOR_ID_MOONLIGHT definitions

2020-11-18 Thread Pavel Machek
Hi! > From: Gene Chen > > Add LED_COLOR_ID_MOONLIGHT definitions Why is moonlight a color? Camera flashes are usually white, no? At least it needs a comment... Best regards, Pavel

[PATCH v7 2/5] dt-bindings: leds: Add LED_COLOR_ID_MOONLIGHT definitions

2020-11-18 Thread Gene Chen
From: Gene Chen Add LED_COLOR_ID_MOONLIGHT definitions Signed-off-by: Gene Chen --- include/dt-bindings/leds/common.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/dt-bindings/leds/common.h b/include/dt-bindings/leds/common.h index 52b619d..1409e9a 100644 ---