Re: [RESEND PATCH v7 2/5] seq_buf: Export seq_buf_printf() to external modules

2020-05-20 Thread Christoph Hellwig
s/seq_buf: Export seq_buf_printf() to external modules/ seq_buf: export seq_buf_printf/

[RESEND PATCH v7 2/5] seq_buf: Export seq_buf_printf() to external modules

2020-05-19 Thread Vaibhav Jain
'seq_buf' provides a very useful abstraction for writing to a string buffer without needing to worry about it over-flowing. However even though the API has been stable for couple of years now its stills not exported to external modules limiting its usage. Hence this patch proposes update to 'seq_b

Re: [PATCH v7 2/5] seq_buf: Export seq_buf_printf() to external modules

2020-05-10 Thread Vaibhav Jain
Michael Ellerman writes: > Borislav Petkov writes: >> On Fri, May 08, 2020 at 04:19:19PM +0530, Vaibhav Jain wrote: >>> 'seq_buf' provides a very useful abstraction for writing to a string >>> buffer without needing to worry about it over-flowing. However even >>> though the API has been stable

Re: [PATCH v7 2/5] seq_buf: Export seq_buf_printf() to external modules

2020-05-10 Thread Vaibhav Jain
Hi Boris, Borislav Petkov writes: > On Fri, May 08, 2020 at 05:30:31PM +0530, Vaibhav Jain wrote: >> I am referring to Kernel Loadable Modules with MODULE_LICENSE("GPL") >> here. > > And what does "external" refer to? Because if it is out-of-tree, we > don't export symbols for out-of-tree module

Re: [PATCH v7 2/5] seq_buf: Export seq_buf_printf() to external modules

2020-05-10 Thread Vaibhav Jain
Hi Joe, Joe Perches writes: > On Fri, 2020-05-08 at 17:30 +0530, Vaibhav Jain wrote: >> Hi Boris, >> >> Borislav Petkov writes: >> >> > On Fri, May 08, 2020 at 04:19:19PM +0530, Vaibhav Jain wrote: >> > > 'seq_buf' provides a very useful abstraction for writing to a string >> > > buffer witho

Re: [PATCH v7 2/5] seq_buf: Export seq_buf_printf() to external modules

2020-05-08 Thread Steven Rostedt
On Fri, 8 May 2020 18:09:35 +0200 Borislav Petkov wrote: > On Fri, May 08, 2020 at 05:30:31PM +0530, Vaibhav Jain wrote: > > I am referring to Kernel Loadable Modules with MODULE_LICENSE("GPL") > > here. > > And what does "external" refer to? Because if it is out-of-tree, we > don't export sym

Re: [PATCH v7 2/5] seq_buf: Export seq_buf_printf() to external modules

2020-05-08 Thread Borislav Petkov
On Fri, May 08, 2020 at 05:30:31PM +0530, Vaibhav Jain wrote: > I am referring to Kernel Loadable Modules with MODULE_LICENSE("GPL") > here. And what does "external" refer to? Because if it is out-of-tree, we don't export symbols for out-of-tree modules. Looks like you're exporting it for that pa

Re: [PATCH v7 2/5] seq_buf: Export seq_buf_printf() to external modules

2020-05-08 Thread Joe Perches
On Fri, 2020-05-08 at 17:30 +0530, Vaibhav Jain wrote: > Hi Boris, > > Borislav Petkov writes: > > > On Fri, May 08, 2020 at 04:19:19PM +0530, Vaibhav Jain wrote: > > > 'seq_buf' provides a very useful abstraction for writing to a string > > > buffer without needing to worry about it over-flowin

Re: [PATCH v7 2/5] seq_buf: Export seq_buf_printf() to external modules

2020-05-08 Thread Michael Ellerman
Borislav Petkov writes: > On Fri, May 08, 2020 at 04:19:19PM +0530, Vaibhav Jain wrote: >> 'seq_buf' provides a very useful abstraction for writing to a string >> buffer without needing to worry about it over-flowing. However even >> though the API has been stable for couple of years now its still

Re: [PATCH v7 2/5] seq_buf: Export seq_buf_printf() to external modules

2020-05-08 Thread Vaibhav Jain
Hi Boris, Borislav Petkov writes: > On Fri, May 08, 2020 at 04:19:19PM +0530, Vaibhav Jain wrote: >> 'seq_buf' provides a very useful abstraction for writing to a string >> buffer without needing to worry about it over-flowing. However even >> though the API has been stable for couple of years n

Re: [PATCH v7 2/5] seq_buf: Export seq_buf_printf() to external modules

2020-05-08 Thread Borislav Petkov
On Fri, May 08, 2020 at 04:19:19PM +0530, Vaibhav Jain wrote: > 'seq_buf' provides a very useful abstraction for writing to a string > buffer without needing to worry about it over-flowing. However even > though the API has been stable for couple of years now its stills not > exported to external m

[PATCH v7 2/5] seq_buf: Export seq_buf_printf() to external modules

2020-05-08 Thread Vaibhav Jain
'seq_buf' provides a very useful abstraction for writing to a string buffer without needing to worry about it over-flowing. However even though the API has been stable for couple of years now its stills not exported to external modules limiting its usage. Hence this patch proposes update to 'seq_b