Re: [PATCH v7 2/9] i2c: rk3x: use struct "rk3x_i2c_calced_timings"

Hi Doug, 在 2016/5/6 6:55, Doug Anderson 写道: David, On Wed, May 4, 2016 at 7:13 AM, David Wu wrote: Signed-off-by: David Wu Usually folks like a description and not just a subject line. I'd add a description like: The "div_high" and "div_low" values are always used together. Group them i

Re: [PATCH v7 2/9] i2c: rk3x: use struct "rk3x_i2c_calced_timings"

David, On Wed, May 4, 2016 at 7:13 AM, David Wu wrote: > Signed-off-by: David Wu Usually folks like a description and not just a subject line. I'd add a description like: The "div_high" and "div_low" values are always used together. Group them into a structure to make it easier to pass them

[PATCH v7 2/9] i2c: rk3x: use struct "rk3x_i2c_calced_timings"

Signed-off-by: David Wu --- Change in v7: - none drivers/i2c/busses/i2c-rk3x.c | 55 +-- 1 file changed, 32 insertions(+), 23 deletions(-) diff --git a/drivers/i2c/busses/i2c-rk3x.c b/drivers/i2c/busses/i2c-rk3x.c index 7e45d51..1e2677a 100644 --- a/drive