Re: [PATCH v7 25/38] iio/scmi: port driver to the new scmi_sensor_proto_ops interface

2021-03-31 Thread Jonathan Cameron
On Wed, 31 Mar 2021 09:32:19 +0100 Cristian Marussi wrote: > Hi Jonathan > > On Tue, Mar 30, 2021 at 06:34:04PM +0100, Jonathan Cameron wrote: > > On Tue, 30 Mar 2021 13:51:13 +0100 > > Cristian Marussi wrote: > > > > > Hi Jonathan, > > > > > > On Tue, Mar 30, 2021 at 12:33:25PM +0100,

Re: [PATCH v7 25/38] iio/scmi: port driver to the new scmi_sensor_proto_ops interface

2021-03-31 Thread Cristian Marussi
Hi Jonathan On Tue, Mar 30, 2021 at 06:34:04PM +0100, Jonathan Cameron wrote: > On Tue, 30 Mar 2021 13:51:13 +0100 > Cristian Marussi wrote: > > > Hi Jonathan, > > > > On Tue, Mar 30, 2021 at 12:33:25PM +0100, Jonathan Cameron wrote: > > > On Tue, 16 Mar 2021 12:48:50 + > > > Cristian

Re: [PATCH v7 25/38] iio/scmi: port driver to the new scmi_sensor_proto_ops interface

2021-03-30 Thread Jonathan Cameron
On Tue, 30 Mar 2021 13:51:13 +0100 Cristian Marussi wrote: > Hi Jonathan, > > On Tue, Mar 30, 2021 at 12:33:25PM +0100, Jonathan Cameron wrote: > > On Tue, 16 Mar 2021 12:48:50 + > > Cristian Marussi wrote: > > > > > Port driver to the new SCMI Sensor interface based on protocol handles

Re: [PATCH v7 25/38] iio/scmi: port driver to the new scmi_sensor_proto_ops interface

2021-03-30 Thread Cristian Marussi
Hi Jonathan, On Tue, Mar 30, 2021 at 12:33:25PM +0100, Jonathan Cameron wrote: > On Tue, 16 Mar 2021 12:48:50 + > Cristian Marussi wrote: > > > Port driver to the new SCMI Sensor interface based on protocol handles > > and common devm_get_ops(). > > > > Cc: Jyoti Bhayana > > Cc: Jonathan

Re: [PATCH v7 25/38] iio/scmi: port driver to the new scmi_sensor_proto_ops interface

2021-03-30 Thread Jonathan Cameron
On Tue, 16 Mar 2021 12:48:50 + Cristian Marussi wrote: > Port driver to the new SCMI Sensor interface based on protocol handles > and common devm_get_ops(). > > Cc: Jyoti Bhayana > Cc: Jonathan Cameron > Signed-off-by: Cristian Marussi +CC linux-...@vger.kernel.org Rule of thumb if it

Re: [PATCH v7 25/38] iio/scmi: port driver to the new scmi_sensor_proto_ops interface

2021-03-30 Thread Jonathan Cameron
On Tue, 23 Mar 2021 09:48:28 + Sudeep Holla wrote: > Hi Jonathan, > > On Thu, Mar 18, 2021 at 12:12:02PM +, Sudeep Holla wrote: > > On Tue, Mar 16, 2021 at 10:38:43PM -0700, Jyoti Bhayana wrote: > > > Hi Christian, > > > > > > Thanks for the detailed explanation. Sounds good to me. >

Re: [PATCH v7 25/38] iio/scmi: port driver to the new scmi_sensor_proto_ops interface

2021-03-23 Thread Sudeep Holla
Hi Jonathan, On Thu, Mar 18, 2021 at 12:12:02PM +, Sudeep Holla wrote: > On Tue, Mar 16, 2021 at 10:38:43PM -0700, Jyoti Bhayana wrote: > > Hi Christian, > > > > Thanks for the detailed explanation. Sounds good to me. > > > > Can I get official Reviewed-by or Acked-by please if you are

Re: [PATCH v7 25/38] iio/scmi: port driver to the new scmi_sensor_proto_ops interface

2021-03-19 Thread Jyoti Bhayana
iio/scmi: port driver to the new scmi_sensor_proto_ops interface Port driver to the new SCMI Sensor interface based on protocol handles and common devm_get_ops(). Cc: Jyoti Bhayana Cc: Jonathan Cameron Acked-by: Jyoti Bhayana Signed-off-by: Cristian Marussi On

Re: [PATCH v7 25/38] iio/scmi: port driver to the new scmi_sensor_proto_ops interface

2021-03-18 Thread Sudeep Holla
On Tue, Mar 16, 2021 at 10:38:43PM -0700, Jyoti Bhayana wrote: > Hi Christian, > > Thanks for the detailed explanation. Sounds good to me. > Can I get official Reviewed-by or Acked-by please if you are fine with the change ? I definitely need one from Jonathan to merge this and one from Jyoti

Re: [PATCH v7 25/38] iio/scmi: port driver to the new scmi_sensor_proto_ops interface

2021-03-16 Thread Jyoti Bhayana
Hi Christian, Thanks for the detailed explanation. Sounds good to me. Thanks, Jyoti On Tue, Mar 16, 2021 at 3:22 PM Cristian Marussi wrote: > > Hi Jyoti, > > On Tue, Mar 16, 2021 at 10:51:48AM -0700, Jyoti Bhayana wrote: > > Hi Christian, > > > > Thanks for porting this driver to the new

Re: [PATCH v7 25/38] iio/scmi: port driver to the new scmi_sensor_proto_ops interface

2021-03-16 Thread Cristian Marussi
Hi Jyoti, On Tue, Mar 16, 2021 at 10:51:48AM -0700, Jyoti Bhayana wrote: > Hi Christian, > > Thanks for porting this driver to the new interface. I have two questions: > > 1) In the following code snippet, can the sensor_ops be made as part > of struct scmi_iio_priv as scmi_protocol_handle is

Re: [PATCH v7 25/38] iio/scmi: port driver to the new scmi_sensor_proto_ops interface

2021-03-16 Thread Jyoti Bhayana
Hi Christian, Thanks for porting this driver to the new interface. I have two questions: 1) In the following code snippet, can the sensor_ops be made as part of struct scmi_iio_priv as scmi_protocol_handle is also part of that struct. Not sure if there are any particular reasons for having the

[PATCH v7 25/38] iio/scmi: port driver to the new scmi_sensor_proto_ops interface

2021-03-16 Thread Cristian Marussi
Port driver to the new SCMI Sensor interface based on protocol handles and common devm_get_ops(). Cc: Jyoti Bhayana Cc: Jonathan Cameron Signed-off-by: Cristian Marussi --- drivers/iio/common/scmi_sensors/scmi_iio.c | 91 ++ 1 file changed, 41 insertions(+), 50