Re: [PATCH v7 3/3] arm64: Add architecture support for PCI

2014-04-08 Thread Liviu Dudau
On Tue, Apr 08, 2014 at 12:58:30AM +0100, Bjorn Helgaas wrote: > On Fri, Mar 14, 2014 at 03:34:18PM +, Liviu Dudau wrote: > > Use the generic host bridge functions to provide support for > > PCI Express on arm64. There is no support for ISA memory. > > > > Signed-off-by: Liviu Dudau > > Tested

Re: [PATCH v7 3/3] arm64: Add architecture support for PCI

2014-04-07 Thread Bjorn Helgaas
On Fri, Mar 14, 2014 at 03:34:18PM +, Liviu Dudau wrote: > Use the generic host bridge functions to provide support for > PCI Express on arm64. There is no support for ISA memory. > > Signed-off-by: Liviu Dudau > Tested-by: Tanmay Inamdar > --- > arch/arm64/Kconfig| 19 +++- >

Re: [PATCH v7 3/3] arm64: Add architecture support for PCI

2014-03-20 Thread Liviu Dudau
On Thu, Mar 20, 2014 at 12:26:02PM +, Arnd Bergmann wrote: > On Thursday 20 March 2014, Liviu Dudau wrote: > > > I don't even understand why you want to create a generic > > > pci_address_to_pio > > > implementation, when we don't need that for arm64 at all. Unless I'm > > > missing something

Re: [PATCH v7 3/3] arm64: Add architecture support for PCI

2014-03-20 Thread Arnd Bergmann
On Thursday 20 March 2014, Liviu Dudau wrote: > > I don't even understand why you want to create a generic pci_address_to_pio > > implementation, when we don't need that for arm64 at all. Unless I'm > > missing something important, that function is only called in case of > > PCI_PROBE_DEVTREE with

Re: [PATCH v7 3/3] arm64: Add architecture support for PCI

2014-03-20 Thread Liviu Dudau
On Thu, Mar 20, 2014 at 11:17:22AM +, Arnd Bergmann wrote: > On Thursday 20 March 2014, Liviu Dudau wrote: > > On Wed, Mar 19, 2014 at 06:37:51PM +, Arnd Bergmann wrote: > > > On Wednesday 19 March 2014 17:21:41 Liviu Dudau wrote: > > > > > > > > My ultimate point is that no matter how lon

Re: [PATCH v7 3/3] arm64: Add architecture support for PCI

2014-03-20 Thread Arnd Bergmann
On Thursday 20 March 2014, Liviu Dudau wrote: > On Wed, Mar 19, 2014 at 06:37:51PM +, Arnd Bergmann wrote: > > On Wednesday 19 March 2014 17:21:41 Liviu Dudau wrote: > > > > > > My ultimate point is that no matter how long we argue about the shape of > > > the functions that > > > I've added

Re: [PATCH v7 3/3] arm64: Add architecture support for PCI

2014-03-20 Thread Liviu Dudau
On Wed, Mar 19, 2014 at 06:37:51PM +, Arnd Bergmann wrote: > On Wednesday 19 March 2014 17:21:41 Liviu Dudau wrote: > > > > My ultimate point is that no matter how long we argue about the shape of > > the functions that > > I've added into arch/arm64/kernel/pci.c I don't think we can get away

Re: [PATCH v7 3/3] arm64: Add architecture support for PCI

2014-03-19 Thread Arnd Bergmann
On Wednesday 19 March 2014 17:21:41 Liviu Dudau wrote: > > My ultimate point is that no matter how long we argue about the shape of the > functions that > I've added into arch/arm64/kernel/pci.c I don't think we can get away without > having that > file, or at least not in the first phase if we

Re: [PATCH v7 3/3] arm64: Add architecture support for PCI

2014-03-19 Thread Arnd Bergmann
On Wednesday 19 March 2014 12:53:11 Rob Herring wrote: > I've successfully used the preceeding series on ARM converting the > Versatile PCI support to use it. The main part of the process was just > copying this arm64 code to arm which tells me the code is in the wrong > place. There are still some

Re: [PATCH v7 3/3] arm64: Add architecture support for PCI

2014-03-19 Thread Liviu Dudau
On Wed, Mar 19, 2014 at 01:56:19PM +, Catalin Marinas wrote: > On Mon, Mar 17, 2014 at 06:05:25PM +, Liviu Dudau wrote: > > On Mon, Mar 17, 2014 at 05:38:21PM +, Catalin Marinas wrote: > > > On Fri, Mar 14, 2014 at 06:05:27PM +, Liviu Dudau wrote: > > > > On Fri, Mar 14, 2014 at 05:

Re: [PATCH v7 3/3] arm64: Add architecture support for PCI

2014-03-19 Thread Rob Herring
On Wed, Mar 19, 2014 at 12:21 PM, Liviu Dudau wrote: > On Wed, Mar 19, 2014 at 01:56:19PM +, Catalin Marinas wrote: >> On Mon, Mar 17, 2014 at 06:05:25PM +, Liviu Dudau wrote: >> > On Mon, Mar 17, 2014 at 05:38:21PM +, Catalin Marinas wrote: >> > > On Fri, Mar 14, 2014 at 06:05:27PM +0

Re: [PATCH v7 3/3] arm64: Add architecture support for PCI

2014-03-19 Thread Catalin Marinas
On Mon, Mar 17, 2014 at 06:05:25PM +, Liviu Dudau wrote: > On Mon, Mar 17, 2014 at 05:38:21PM +, Catalin Marinas wrote: > > On Fri, Mar 14, 2014 at 06:05:27PM +, Liviu Dudau wrote: > > > On Fri, Mar 14, 2014 at 05:38:08PM +, Arnd Bergmann wrote: > > > > On Friday 14 March 2014, Cata

Re: [PATCH v7 3/3] arm64: Add architecture support for PCI

2014-03-17 Thread Liviu Dudau
On Mon, Mar 17, 2014 at 05:38:21PM +, Catalin Marinas wrote: > On Fri, Mar 14, 2014 at 06:05:27PM +, Liviu Dudau wrote: > > On Fri, Mar 14, 2014 at 05:38:08PM +, Arnd Bergmann wrote: > > > On Friday 14 March 2014, Catalin Marinas wrote: > > > > On Fri, Mar 14, 2014 at 03:34:18PM +,

Re: [PATCH v7 3/3] arm64: Add architecture support for PCI

2014-03-17 Thread Catalin Marinas
On Fri, Mar 14, 2014 at 06:05:27PM +, Liviu Dudau wrote: > On Fri, Mar 14, 2014 at 05:38:08PM +, Arnd Bergmann wrote: > > On Friday 14 March 2014, Catalin Marinas wrote: > > > On Fri, Mar 14, 2014 at 03:34:18PM +, Liviu Dudau wrote: > > > > --- /dev/null > > > > +++ b/arch/arm64/kernel/

Re: [PATCH v7 3/3] arm64: Add architecture support for PCI

2014-03-17 Thread Liviu Dudau
On Mon, Mar 17, 2014 at 04:05:38PM +, Rob Herring wrote: > On Fri, Mar 14, 2014 at 10:34 AM, Liviu Dudau wrote: > > Use the generic host bridge functions to provide support for > > PCI Express on arm64. There is no support for ISA memory. > > > > Signed-off-by: Liviu Dudau > > Tested-by: Tanm

Re: [PATCH v7 3/3] arm64: Add architecture support for PCI

2014-03-17 Thread Rob Herring
On Fri, Mar 14, 2014 at 10:34 AM, Liviu Dudau wrote: > Use the generic host bridge functions to provide support for > PCI Express on arm64. There is no support for ISA memory. > > Signed-off-by: Liviu Dudau > Tested-by: Tanmay Inamdar > --- > arch/arm64/Kconfig| 19 +++- > arch/arm

Re: [PATCH v7 3/3] arm64: Add architecture support for PCI

2014-03-15 Thread Benjamin Herrenschmidt
On Fri, 2014-03-14 at 20:10 +0100, Arnd Bergmann wrote: > > As for the other two functions, I've no special attachment to where they > > are present > > and I'm happy to move them into drivers/pci on the condition that the > > patchset doesn't > > double in size. The reason why I'm weary of touch

Re: [PATCH v7 3/3] arm64: Add architecture support for PCI

2014-03-14 Thread Arnd Bergmann
On Friday 14 March 2014, Liviu Dudau wrote: > > > > I haven't seen any reaction from Bjorn on this, so I threaded carefully on > that > subject. I'm new to this so I don't know how to handle this. > > To my mind, and looking at the way every architecture has been setup, the > pcibios_* > funct

Re: [PATCH v7 3/3] arm64: Add architecture support for PCI

2014-03-14 Thread Liviu Dudau
On Fri, Mar 14, 2014 at 05:38:08PM +, Arnd Bergmann wrote: > On Friday 14 March 2014, Catalin Marinas wrote: > > On Fri, Mar 14, 2014 at 03:34:18PM +, Liviu Dudau wrote: > > > --- /dev/null > > > +++ b/arch/arm64/kernel/pci.c > > [...] > > > +int pci_register_io_range(phys_addr_t address, r

Re: [PATCH v7 3/3] arm64: Add architecture support for PCI

2014-03-14 Thread Arnd Bergmann
On Friday 14 March 2014, Catalin Marinas wrote: > On Fri, Mar 14, 2014 at 03:34:18PM +, Liviu Dudau wrote: > > --- /dev/null > > +++ b/arch/arm64/kernel/pci.c > [...] > > +int pci_register_io_range(phys_addr_t address, resource_size_t size) > [...] > > +unsigned long pci_address_to_pio(phys_add

Re: [PATCH v7 3/3] arm64: Add architecture support for PCI

2014-03-14 Thread Catalin Marinas
On Fri, Mar 14, 2014 at 03:34:18PM +, Liviu Dudau wrote: > --- /dev/null > +++ b/arch/arm64/kernel/pci.c [...] > +int pci_register_io_range(phys_addr_t address, resource_size_t size) [...] > +unsigned long pci_address_to_pio(phys_addr_t address) [...] > +void pcibios_fixup_bus(struct pci_bus *b

[PATCH v7 3/3] arm64: Add architecture support for PCI

2014-03-14 Thread Liviu Dudau
Use the generic host bridge functions to provide support for PCI Express on arm64. There is no support for ISA memory. Signed-off-by: Liviu Dudau Tested-by: Tanmay Inamdar --- arch/arm64/Kconfig| 19 +++- arch/arm64/include/asm/Kbuild | 1 + arch/arm64/include/asm/io.h | 3 +-