Re: [PATCH v7 3/3] leds: trigger: implement a tty trigger

2020-07-22 Thread Johan Hovold
On Tue, Jul 21, 2020 at 09:48:15PM +0200, Uwe Kleine-König wrote: > Hello Johan, > > On Tue, Jul 14, 2020 at 09:13:55AM +0200, Johan Hovold wrote: > > On Tue, Jul 07, 2020 at 06:59:58PM +0200, Uwe Kleine-König wrote: > > > + while (firstrun || > > > +icount.rx != trigger_data->rx || > > >

Re: [PATCH v7 3/3] leds: trigger: implement a tty trigger

2020-07-21 Thread Uwe Kleine-König
Hello Johan, On Tue, Jul 14, 2020 at 09:13:55AM +0200, Johan Hovold wrote: > On Tue, Jul 07, 2020 at 06:59:58PM +0200, Uwe Kleine-König wrote: > > + while (firstrun || > > + icount.rx != trigger_data->rx || > > + icount.tx != trigger_data->tx) { > > + > > +

Re: [PATCH v7 3/3] leds: trigger: implement a tty trigger

2020-07-14 Thread Johan Hovold
On Tue, Jul 07, 2020 at 06:59:58PM +0200, Uwe Kleine-König wrote: > Usage is as follows: > > myled=ledname > tty=ttyS0 > > echo tty > /sys/class/leds/$myled/trigger > echo $tty > /sys/class/leds/$myled/ttyname > > . When this new trigger is active it periodically checks

Re: [PATCH v7 3/3] leds: trigger: implement a tty trigger

2020-07-13 Thread Uwe Kleine-König
Hello Pavel, On Sun, Jul 12, 2020 at 10:24:53AM +0200, Pavel Machek wrote: > > +++ b/drivers/leds/trigger/ledtrig-tty.c > > @@ -0,0 +1,192 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > 2.0+ is preffered. My employer requests GPL-2.0-only for kernel code. > > + while (firstrun || > > +

Re: [PATCH v7 3/3] leds: trigger: implement a tty trigger

2020-07-12 Thread Greg Kroah-Hartman
On Sun, Jul 12, 2020 at 11:07:31AM +0200, Pavel Machek wrote: > On Sun 2020-07-12 11:02:17, Greg Kroah-Hartman wrote: > > On Sun, Jul 12, 2020 at 10:50:59AM +0200, Pavel Machek wrote: > > > On Sun 2020-07-12 10:43:52, Greg Kroah-Hartman wrote: > > > > On Sun, Jul 12, 2020 at 10:24:53AM +0200,

Re: [PATCH v7 3/3] leds: trigger: implement a tty trigger

2020-07-12 Thread Pavel Machek
On Sun 2020-07-12 11:02:17, Greg Kroah-Hartman wrote: > On Sun, Jul 12, 2020 at 10:50:59AM +0200, Pavel Machek wrote: > > On Sun 2020-07-12 10:43:52, Greg Kroah-Hartman wrote: > > > On Sun, Jul 12, 2020 at 10:24:53AM +0200, Pavel Machek wrote: > > > > > +++ b/drivers/leds/trigger/ledtrig-tty.c > >

Re: [PATCH v7 3/3] leds: trigger: implement a tty trigger

2020-07-12 Thread Greg Kroah-Hartman
On Sun, Jul 12, 2020 at 10:50:59AM +0200, Pavel Machek wrote: > On Sun 2020-07-12 10:43:52, Greg Kroah-Hartman wrote: > > On Sun, Jul 12, 2020 at 10:24:53AM +0200, Pavel Machek wrote: > > > > +++ b/drivers/leds/trigger/ledtrig-tty.c > > > > @@ -0,0 +1,192 @@ > > > > +// SPDX-License-Identifier:

Re: [PATCH v7 3/3] leds: trigger: implement a tty trigger

2020-07-12 Thread Pavel Machek
On Sun 2020-07-12 10:43:52, Greg Kroah-Hartman wrote: > On Sun, Jul 12, 2020 at 10:24:53AM +0200, Pavel Machek wrote: > > > +++ b/drivers/leds/trigger/ledtrig-tty.c > > > @@ -0,0 +1,192 @@ > > > +// SPDX-License-Identifier: GPL-2.0 > > > > 2.0+ is preffered. > > No it is not, that's up to the

Re: [PATCH v7 3/3] leds: trigger: implement a tty trigger

2020-07-12 Thread Greg Kroah-Hartman
On Sun, Jul 12, 2020 at 10:24:53AM +0200, Pavel Machek wrote: > > +++ b/drivers/leds/trigger/ledtrig-tty.c > > @@ -0,0 +1,192 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > 2.0+ is preffered. No it is not, that's up to the developer. thanks, greg k-h

Re: [PATCH v7 3/3] leds: trigger: implement a tty trigger

2020-07-12 Thread Pavel Machek
Hi! > +++ b/Documentation/ABI/testing/sysfs-class-led-trigger-tty > @@ -0,0 +1,6 @@ > +What:/sys/class/leds//ttyname > +Date:Jul 2020 > +KernelVersion: 5.8 > +Contact: linux-l...@vger.kernel.org > +Description: > + Specifies the tty device

[PATCH v7 3/3] leds: trigger: implement a tty trigger

2020-07-07 Thread Uwe Kleine-König
Usage is as follows: myled=ledname tty=ttyS0 echo tty > /sys/class/leds/$myled/trigger echo $tty > /sys/class/leds/$myled/ttyname . When this new trigger is active it periodically checks the tty's statistics and when it changed since the last check the led is