Re: [PATCH v7 3/3] perf-stat: enable counting events for BPF programs

Em Wed, Jan 20, 2021 at 10:01:37AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Wed, Jan 20, 2021 at 09:37:27AM -0300, Arnaldo Carvalho de Melo escreveu: > > Breakpoint 3, bpf_program_profiler__read (evsel=0xce02c0) at > > util/bpf_counter.c:208 > > 208 { > > (gdb) c > > Continuing. > > > > Pro

Re: FIX Re: [PATCH v7 3/3] perf-stat: enable counting events for BPF programs

Em Wed, Jan 20, 2021 at 04:40:46PM +, Song Liu escreveu: > > > > On Jan 20, 2021, at 8:30 AM, Arnaldo Carvalho de Melo > > wrote: > > > > Em Wed, Jan 20, 2021 at 10:50:13AM -0300, Arnaldo Carvalho de Melo escreveu: > >> So sizeof(struct bpf_perf_event_value) == 24 and it is a per-cpu array

Re: FIX Re: [PATCH v7 3/3] perf-stat: enable counting events for BPF programs

> On Jan 20, 2021, at 8:30 AM, Arnaldo Carvalho de Melo wrote: > > Em Wed, Jan 20, 2021 at 10:50:13AM -0300, Arnaldo Carvalho de Melo escreveu: >> So sizeof(struct bpf_perf_event_value) == 24 and it is a per-cpu array, the >> machine has 24 cpus, why is the kernel thinking it has more and end

FIX Re: [PATCH v7 3/3] perf-stat: enable counting events for BPF programs

Em Wed, Jan 20, 2021 at 10:50:13AM -0300, Arnaldo Carvalho de Melo escreveu: > So sizeof(struct bpf_perf_event_value) == 24 and it is a per-cpu array, the > machine has 24 cpus, why is the kernel thinking it has more and end up zeroing > entries after the 24 cores? Some percpu map subtlety (or obvi

Re: [PATCH v7 3/3] perf-stat: enable counting events for BPF programs

Em Wed, Jan 20, 2021 at 09:37:27AM -0300, Arnaldo Carvalho de Melo escreveu: > Breakpoint 3, bpf_program_profiler__read (evsel=0xce02c0) at > util/bpf_counter.c:208 > 208 { > (gdb) c > Continuing. > > Program received signal SIGSEGV, Segmentation fault. > 0x005cf34b in bpf_program_profi

Re: [PATCH v7 3/3] perf-stat: enable counting events for BPF programs

Em Tue, Jan 19, 2021 at 07:30:21PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Tue, Jan 19, 2021 at 09:54:50PM +, Song Liu escreveu: > > > > > > > On Jan 19, 2021, at 8:31 AM, Arnaldo Carvalho de Melo > > > wrote: > > > > > > Em Tue, Jan 19, 2021 at 11:42:49AM -0300, Arnaldo Carvalho de

Re: [PATCH v7 3/3] perf-stat: enable counting events for BPF programs

Em Tue, Jan 19, 2021 at 12:48:19AM +, Song Liu escreveu: > > On Jan 18, 2021, at 11:38 AM, Arnaldo Carvalho de Melo > > wrote: > We are looking at two issues: > 1. Cannot recursively attach; > 2. prog FD 3 doesn't have valid btf. > #1 was caused by the verifier disallowing attaching fentry

Re: [PATCH v7 3/3] perf-stat: enable counting events for BPF programs

Em Tue, Jan 19, 2021 at 09:54:50PM +, Song Liu escreveu: > > > > On Jan 19, 2021, at 8:31 AM, Arnaldo Carvalho de Melo > > wrote: > > > > Em Tue, Jan 19, 2021 at 11:42:49AM -0300, Arnaldo Carvalho de Melo escreveu: > >> Em Tue, Jan 19, 2021 at 11:31:44AM -0300, Arnaldo Carvalho de Melo >

Re: [PATCH v7 3/3] perf-stat: enable counting events for BPF programs

> On Jan 19, 2021, at 8:31 AM, Arnaldo Carvalho de Melo wrote: > > Em Tue, Jan 19, 2021 at 11:42:49AM -0300, Arnaldo Carvalho de Melo escreveu: >> Em Tue, Jan 19, 2021 at 11:31:44AM -0300, Arnaldo Carvalho de Melo escreveu: >>> Em Tue, Jan 19, 2021 at 12:48:19AM +, Song Liu escreveu: >

Re: [PATCH v7 3/3] perf-stat: enable counting events for BPF programs

Em Tue, Jan 19, 2021 at 11:42:49AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Tue, Jan 19, 2021 at 11:31:44AM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Tue, Jan 19, 2021 at 12:48:19AM +, Song Liu escreveu: > > > > On Jan 18, 2021, at 11:38 AM, Arnaldo Carvalho de Melo > > > > wrote

Re: [PATCH v7 3/3] perf-stat: enable counting events for BPF programs

Em Tue, Jan 19, 2021 at 11:31:44AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Tue, Jan 19, 2021 at 12:48:19AM +, Song Liu escreveu: > > > On Jan 18, 2021, at 11:38 AM, Arnaldo Carvalho de Melo > > > wrote: > > We are looking at two issues: > > 1. Cannot recursively attach; > > 2. prog FD

Re: [PATCH v7 3/3] perf-stat: enable counting events for BPF programs

Hi Arnaldo, > On Jan 18, 2021, at 11:38 AM, Arnaldo Carvalho de Melo > wrote: > > Em Tue, Dec 29, 2020 at 01:42:14PM -0800, Song Liu escreveu: >> Introduce perf-stat -b option, which counts events for BPF programs, like: >> >> [root@localhost ~]# ~/perf stat -e ref-cycles,cycles -b 254 -I 1000

Re: [PATCH v7 3/3] perf-stat: enable counting events for BPF programs

Em Tue, Dec 29, 2020 at 01:42:14PM -0800, Song Liu escreveu: > Introduce perf-stat -b option, which counts events for BPF programs, like: > > [root@localhost ~]# ~/perf stat -e ref-cycles,cycles -b 254 -I 1000 > 1.487903822115,200 ref-cycles > 1.487903822 86,

Re: [PATCH v7 3/3] perf-stat: enable counting events for BPF programs

Em Tue, Jan 12, 2021 at 04:35:14PM +0900, Namhyung Kim escreveu: > Hi, > > On Wed, Dec 30, 2020 at 6:42 AM Song Liu wrote: > > > > Introduce perf-stat -b option, which counts events for BPF programs, like: > > > > [root@localhost ~]# ~/perf stat -e ref-cycles,cycles -b 254 -I 1000 > > 1.4879

Re: [PATCH v7 3/3] perf-stat: enable counting events for BPF programs

Hi, On Wed, Dec 30, 2020 at 6:42 AM Song Liu wrote: > > Introduce perf-stat -b option, which counts events for BPF programs, like: > > [root@localhost ~]# ~/perf stat -e ref-cycles,cycles -b 254 -I 1000 > 1.487903822115,200 ref-cycles > 1.487903822 86,012

[PATCH v7 3/3] perf-stat: enable counting events for BPF programs

Introduce perf-stat -b option, which counts events for BPF programs, like: [root@localhost ~]# ~/perf stat -e ref-cycles,cycles -b 254 -I 1000 1.487903822115,200 ref-cycles 1.487903822 86,012 cycles 2.489147029 80,560 ref-cycles