RE: [PATCH v7 3/3] phy: intel: Add Keem Bay eMMC PHY support

2020-08-31 Thread Wan Mohamad, Wan Ahmad Zainie
vadivel.muruganx.ramuthe...@linux.intel.com; Raja Subramanian, Lakshmi > Bai ; linux- > ker...@vger.kernel.org; devicet...@vger.kernel.org > Subject: Re: [PATCH v7 3/3] phy: intel: Add Keem Bay eMMC PHY support > > On 21-08-20, 19:37, Wan Ahmad Zainie wrote: > > > +/* From ACS_eMMC51_16nF

Re: [PATCH v7 3/3] phy: intel: Add Keem Bay eMMC PHY support

2020-08-31 Thread Vinod Koul
On 21-08-20, 19:37, Wan Ahmad Zainie wrote: > +/* From ACS_eMMC51_16nFFC_RO1100_Userguide_v1p0.pdf p17 */ > +#define FREQSEL_200M_170M0x0 > +#define FREQSEL_170M_140M0x1 > +#define FREQSEL_140M_110M0x2 > +#define FREQSEL_110M_80M 0x3 > +#define FREQSEL_80M_50M 0x4 > +

Re: [PATCH v7 3/3] phy: intel: Add Keem Bay eMMC PHY support

2020-08-21 Thread Andy Shevchenko
On Fri, Aug 21, 2020 at 07:37:47PM +0800, Wan Ahmad Zainie wrote: > Add support for eMMC PHY on Intel Keem Bay SoC. Thanks for an update. I have couple of nit-picks below, otherwise, FWIW, Reviewed-by: Andy Shevchenko > Signed-off-by: Wan Ahmad Zainie > --- > drivers/phy/intel/Kconfig

[PATCH v7 3/3] phy: intel: Add Keem Bay eMMC PHY support

2020-08-21 Thread Wan Ahmad Zainie
Add support for eMMC PHY on Intel Keem Bay SoC. Signed-off-by: Wan Ahmad Zainie --- drivers/phy/intel/Kconfig | 12 + drivers/phy/intel/Makefile | 1 + drivers/phy/intel/phy-intel-keembay-emmc.c | 310 + 3 files changed, 323 insertions(+)