Re: [PATCH v7 3/3] phy: intel: Add driver support for ComboPhy

2020-05-11 Thread Dilip Kota
Hi Vinod, On 5/5/2020 3:54 PM, Dilip Kota wrote: On 5/5/2020 1:21 PM, Vinod Koul wrote: On 04-05-20, 17:32, Dilip Kota wrote: On 5/4/2020 5:20 PM, Vinod Koul wrote: On 04-05-20, 16:26, Dilip Kota wrote: On 5/4/2020 3:29 PM, Vinod Koul wrote: On 30-04-20, 15:15, Dilip Kota wrote: +   

Re: [PATCH v7 3/3] phy: intel: Add driver support for ComboPhy

2020-05-05 Thread Dilip Kota
On 5/5/2020 1:21 PM, Vinod Koul wrote: On 04-05-20, 17:32, Dilip Kota wrote: On 5/4/2020 5:20 PM, Vinod Koul wrote: On 04-05-20, 16:26, Dilip Kota wrote: On 5/4/2020 3:29 PM, Vinod Koul wrote: On 30-04-20, 15:15, Dilip Kota wrote: + u32 mask, u32

Re: [PATCH v7 3/3] phy: intel: Add driver support for ComboPhy

2020-05-04 Thread Vinod Koul
On 04-05-20, 17:32, Dilip Kota wrote: > > On 5/4/2020 5:20 PM, Vinod Koul wrote: > > On 04-05-20, 16:26, Dilip Kota wrote: > > > On 5/4/2020 3:29 PM, Vinod Koul wrote: > > > > On 30-04-20, 15:15, Dilip Kota wrote: > > > > > > > > > + u32 mask, u32 val) > > >

Re: [PATCH v7 3/3] phy: intel: Add driver support for ComboPhy

2020-05-04 Thread Dilip Kota
On 5/4/2020 5:20 PM, Vinod Koul wrote: On 04-05-20, 16:26, Dilip Kota wrote: On 5/4/2020 3:29 PM, Vinod Koul wrote: On 30-04-20, 15:15, Dilip Kota wrote: + u32 mask, u32 val) +{ + u32 reg_val; + + reg_val = readl(base + reg); +

Re: [PATCH v7 3/3] phy: intel: Add driver support for ComboPhy

2020-05-04 Thread Vinod Koul
On 04-05-20, 16:26, Dilip Kota wrote: > > On 5/4/2020 3:29 PM, Vinod Koul wrote: > > On 30-04-20, 15:15, Dilip Kota wrote: > > > > > +enum { > > > + PHY_0, > > > + PHY_1, > > > + PHY_MAX_NUM > > PHY_MAX_NUM = PHY_1? > Driver is using it for no. of PHYs/maximum PHY id. Ok > > > +static inline

Re: [PATCH v7 3/3] phy: intel: Add driver support for ComboPhy

2020-05-04 Thread Dilip Kota
On 5/4/2020 3:29 PM, Vinod Koul wrote: On 30-04-20, 15:15, Dilip Kota wrote: +enum { + PHY_0, + PHY_1, + PHY_MAX_NUM PHY_MAX_NUM = PHY_1? Driver is using it for no. of PHYs/maximum PHY id. Code snippets: struct intel_combo_phy { ...     struct reset_control   

Re: [PATCH v7 3/3] phy: intel: Add driver support for ComboPhy

2020-05-04 Thread Vinod Koul
On 30-04-20, 15:15, Dilip Kota wrote: > +enum { > + PHY_0, > + PHY_1, > + PHY_MAX_NUM PHY_MAX_NUM = PHY_1? > +static inline void combo_phy_w32_off_mask(void __iomem *base, unsigned int > reg, > + u32 mask, u32 val) > +{ > + u32 reg_val; > +

[PATCH v7 3/3] phy: intel: Add driver support for ComboPhy

2020-04-30 Thread Dilip Kota
ComboPhy subsystem provides PHYs for various controllers like PCIe, SATA and EMAC. Signed-off-by: Dilip Kota --- Changes on v7: Use device_node_to_regmap instead of fwnode_to_regmap Changes on v6: No changes Changes on v5: Add changes as per inputs from Andy and Rob: DT node uses