Re: [PATCH v7 3/4] dt-bindings: power: supply: qcom_bms: Add bindings

2018-09-21 Thread Linus Walleij
On Thu, Sep 20, 2018 at 9:58 AM Sebastian Reichel wrote: > I prefer the second binding (with mV -> uV), but I think it becomes > messy when temperature is added. What do you think about the > following proposal (derived from pinctrl style): > > Proposal C: > > ocv-capacity-table-temperatures =

Re: [PATCH v7 3/4] dt-bindings: power: supply: qcom_bms: Add bindings

2018-09-21 Thread Linus Walleij
On Thu, Sep 20, 2018 at 9:58 AM Sebastian Reichel wrote: > I prefer the second binding (with mV -> uV), but I think it becomes > messy when temperature is added. What do you think about the > following proposal (derived from pinctrl style): > > Proposal C: > > ocv-capacity-table-temperatures =

Re: [PATCH v7 3/4] dt-bindings: power: supply: qcom_bms: Add bindings

2018-09-20 Thread Sebastian Reichel
Hi, On Fri, Sep 21, 2018 at 04:08:28AM +0800, Baolin Wang wrote: > Hi Sebastian, > > On 21 September 2018 at 00:58, Sebastian Reichel > wrote: > > [Dropped a couple of people from CC, added Baolin] > > > > Hi Craig, Baolin and Rob, > > > > On Thu, Sep 20, 2018 at 03:32:29PM +0100, Craig wrote:

Re: [PATCH v7 3/4] dt-bindings: power: supply: qcom_bms: Add bindings

2018-09-20 Thread Sebastian Reichel
On Thu, Sep 20, 2018 at 08:13:52PM +0100, Craig wrote: > On 20 September 2018 17:58:47 BST, Sebastian Reichel > wrote: > >[Dropped a couple of people from CC, added Baolin] > > > >Hi Craig, Baolin and Rob, > > > >On Thu, Sep 20, 2018 at 03:32:29PM +0100, Craig wrote: > >> On 16 September 2018

Re: [PATCH v7 3/4] dt-bindings: power: supply: qcom_bms: Add bindings

2018-09-20 Thread Sebastian Reichel
On Thu, Sep 20, 2018 at 08:13:52PM +0100, Craig wrote: > On 20 September 2018 17:58:47 BST, Sebastian Reichel > wrote: > >[Dropped a couple of people from CC, added Baolin] > > > >Hi Craig, Baolin and Rob, > > > >On Thu, Sep 20, 2018 at 03:32:29PM +0100, Craig wrote: > >> On 16 September 2018

Re: [PATCH v7 3/4] dt-bindings: power: supply: qcom_bms: Add bindings

2018-09-20 Thread Sebastian Reichel
Hi, On Fri, Sep 21, 2018 at 04:08:28AM +0800, Baolin Wang wrote: > Hi Sebastian, > > On 21 September 2018 at 00:58, Sebastian Reichel > wrote: > > [Dropped a couple of people from CC, added Baolin] > > > > Hi Craig, Baolin and Rob, > > > > On Thu, Sep 20, 2018 at 03:32:29PM +0100, Craig wrote:

Re: [PATCH v7 3/4] dt-bindings: power: supply: qcom_bms: Add bindings

2018-09-20 Thread Baolin Wang
Hi Sebastian, On 21 September 2018 at 00:58, Sebastian Reichel wrote: > [Dropped a couple of people from CC, added Baolin] > > Hi Craig, Baolin and Rob, > > On Thu, Sep 20, 2018 at 03:32:29PM +0100, Craig wrote: >> On 16 September 2018 13:10:45 BST, Sebastian Reichel >> wrote: >> >Sorry for my

Re: [PATCH v7 3/4] dt-bindings: power: supply: qcom_bms: Add bindings

2018-09-20 Thread Baolin Wang
Hi Sebastian, On 21 September 2018 at 00:58, Sebastian Reichel wrote: > [Dropped a couple of people from CC, added Baolin] > > Hi Craig, Baolin and Rob, > > On Thu, Sep 20, 2018 at 03:32:29PM +0100, Craig wrote: >> On 16 September 2018 13:10:45 BST, Sebastian Reichel >> wrote: >> >Sorry for my

Re: [PATCH v7 3/4] dt-bindings: power: supply: qcom_bms: Add bindings

2018-09-20 Thread Craig
On 20 September 2018 17:58:47 BST, Sebastian Reichel wrote: >[Dropped a couple of people from CC, added Baolin] > >Hi Craig, Baolin and Rob, > >On Thu, Sep 20, 2018 at 03:32:29PM +0100, Craig wrote: >> On 16 September 2018 13:10:45 BST, Sebastian Reichel > wrote: >> >Sorry for my long delay

Re: [PATCH v7 3/4] dt-bindings: power: supply: qcom_bms: Add bindings

2018-09-20 Thread Craig
On 20 September 2018 17:58:47 BST, Sebastian Reichel wrote: >[Dropped a couple of people from CC, added Baolin] > >Hi Craig, Baolin and Rob, > >On Thu, Sep 20, 2018 at 03:32:29PM +0100, Craig wrote: >> On 16 September 2018 13:10:45 BST, Sebastian Reichel > wrote: >> >Sorry for my long delay

Re: [PATCH v7 3/4] dt-bindings: power: supply: qcom_bms: Add bindings

2018-09-20 Thread Sebastian Reichel
[Dropped a couple of people from CC, added Baolin] Hi Craig, Baolin and Rob, On Thu, Sep 20, 2018 at 03:32:29PM +0100, Craig wrote: > On 16 September 2018 13:10:45 BST, Sebastian Reichel > wrote: > >Sorry for my long delay in reviewing this. I like the binding, > >but the "qcom," specific

Re: [PATCH v7 3/4] dt-bindings: power: supply: qcom_bms: Add bindings

2018-09-20 Thread Sebastian Reichel
[Dropped a couple of people from CC, added Baolin] Hi Craig, Baolin and Rob, On Thu, Sep 20, 2018 at 03:32:29PM +0100, Craig wrote: > On 16 September 2018 13:10:45 BST, Sebastian Reichel > wrote: > >Sorry for my long delay in reviewing this. I like the binding, > >but the "qcom," specific

Re: [PATCH v7 3/4] dt-bindings: power: supply: qcom_bms: Add bindings

2018-09-20 Thread Craig
On 16 September 2018 13:10:45 BST, Sebastian Reichel wrote: >Hi, > >Sorry for my long delay in reviewing this. I like the binding, >but the "qcom," specific properties should become common properties >in > >Documentation/devicetree/bindings/power/supply/battery.txt Thanks for the review, what

Re: [PATCH v7 3/4] dt-bindings: power: supply: qcom_bms: Add bindings

2018-09-20 Thread Craig
On 16 September 2018 13:10:45 BST, Sebastian Reichel wrote: >Hi, > >Sorry for my long delay in reviewing this. I like the binding, >but the "qcom," specific properties should become common properties >in > >Documentation/devicetree/bindings/power/supply/battery.txt Thanks for the review, what

Re: [PATCH v7 3/4] dt-bindings: power: supply: qcom_bms: Add bindings

2018-09-16 Thread Sebastian Reichel
Hi, Sorry for my long delay in reviewing this. I like the binding, but the "qcom," specific properties should become common properties in Documentation/devicetree/bindings/power/supply/battery.txt and referenced via monitored-battery. -- Sebastian On Thu, Jun 14, 2018 at 04:14:16PM +0100,

Re: [PATCH v7 3/4] dt-bindings: power: supply: qcom_bms: Add bindings

2018-09-16 Thread Sebastian Reichel
Hi, Sorry for my long delay in reviewing this. I like the binding, but the "qcom," specific properties should become common properties in Documentation/devicetree/bindings/power/supply/battery.txt and referenced via monitored-battery. -- Sebastian On Thu, Jun 14, 2018 at 04:14:16PM +0100,

[PATCH v7 3/4] dt-bindings: power: supply: qcom_bms: Add bindings

2018-06-14 Thread Craig Tatlor
Add bindings for the Qualcomm Battery Monitoring system. Signed-off-by: Craig Tatlor Reviewed-by: Rob Herring --- * Changes from v6: s/celcius/celsius change uah to uAh. * Changes from v5:

[PATCH v7 3/4] dt-bindings: power: supply: qcom_bms: Add bindings

2018-06-14 Thread Craig Tatlor
Add bindings for the Qualcomm Battery Monitoring system. Signed-off-by: Craig Tatlor Reviewed-by: Rob Herring --- * Changes from v6: s/celcius/celsius change uah to uAh. * Changes from v5: