Re: [PATCH v7 3/5] RTC: RK808: add RTC driver for RK808

2014-09-02 Thread Doug Anderson
Hi, On Tue, Sep 2, 2014 at 8:52 PM, Doug Anderson wrote: > Chris, > > On Tue, Sep 2, 2014 at 7:01 PM, Chris Zhong wrote: >> >> On 09/02/2014 11:58 AM, Doug Anderson wrote: +static int rk808_rtc_probe(struct platform_device *pdev) >+{ >+ struct rk808 *rk808 = dev_get_drv

Re: [PATCH v7 3/5] RTC: RK808: add RTC driver for RK808

2014-09-02 Thread Doug Anderson
Chris, On Tue, Sep 2, 2014 at 7:01 PM, Chris Zhong wrote: > > On 09/02/2014 11:58 AM, Doug Anderson wrote: >>> >>> +static int rk808_rtc_probe(struct platform_device *pdev) >>> >+{ >>> >+ struct rk808 *rk808 = dev_get_drvdata(pdev->dev.parent); >>> >+ struct rk808_rtc *rk808_rtc; >>>

Re: [PATCH v7 3/5] RTC: RK808: add RTC driver for RK808

2014-09-02 Thread Chris Zhong
On 09/02/2014 11:58 AM, Doug Anderson wrote: +static int rk808_rtc_probe(struct platform_device *pdev) >+{ >+ struct rk808 *rk808 = dev_get_drvdata(pdev->dev.parent); >+ struct rk808_rtc *rk808_rtc; >+ struct rtc_time tm; >+ int ret; >+ >+ rk808_rtc = devm_kzalloc(&

Re: [PATCH v7 3/5] RTC: RK808: add RTC driver for RK808

2014-09-01 Thread Doug Anderson
Chris, On Mon, Sep 1, 2014 at 2:43 AM, Chris Zhong wrote: > Adding RTC driver for supporting RTC device present inside RK808 PMIC. > > Signed-off-by: Chris Zhong > Signed-off-by: Zhang Qing > > --- > > Changes in v7: > Adviced by doug > - read rtc time from shadowed registers > Adviced by Dmitr

[PATCH v7 3/5] RTC: RK808: add RTC driver for RK808

2014-09-01 Thread Chris Zhong
Adding RTC driver for supporting RTC device present inside RK808 PMIC. Signed-off-by: Chris Zhong Signed-off-by: Zhang Qing --- Changes in v7: Adviced by doug - read rtc time from shadowed registers Adviced by Dmitry - use CONFIG_PM_SLEEP replace CONFIG_PM - use SIMPLE_DEV_PM_OPS replace dev_p