Re: [PATCH v7 3/5] x86/kvm: Add "nopvspin" parameter to disable PV spinlocks

2019-10-22 Thread Zhenzhong Duan
On 2019/10/23 5:03, Sean Christopherson wrote: On Tue, Oct 22, 2019 at 08:46:46PM +0800, Zhenzhong Duan wrote: Hi Vitaly, On 2019/10/22 19:36, Vitaly Kuznetsov wrote: Zhenzhong Duan writes: ...snip diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c index 249f14a..3945aa5 100644

Re: [PATCH v7 3/5] x86/kvm: Add "nopvspin" parameter to disable PV spinlocks

2019-10-22 Thread Sean Christopherson
On Tue, Oct 22, 2019 at 08:46:46PM +0800, Zhenzhong Duan wrote: > Hi Vitaly, > > On 2019/10/22 19:36, Vitaly Kuznetsov wrote: > > >Zhenzhong Duan writes: > > > ...snip > > >>diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c > >>index 249f14a..3945aa5 100644 > >>--- a/arch/x86/kernel/kv

Re: [PATCH v7 3/5] x86/kvm: Add "nopvspin" parameter to disable PV spinlocks

2019-10-22 Thread Vitaly Kuznetsov
Zhenzhong Duan writes: > Hi Vitaly, > > On 2019/10/22 19:36, Vitaly Kuznetsov wrote: > >> Zhenzhong Duan writes: >> > ...snip > >>> diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c >>> index 249f14a..3945aa5 100644 >>> --- a/arch/x86/kernel/kvm.c >>> +++ b/arch/x86/kernel/kvm.c >>> @@

Re: [PATCH v7 3/5] x86/kvm: Add "nopvspin" parameter to disable PV spinlocks

2019-10-22 Thread Zhenzhong Duan
Hi Vitaly, On 2019/10/22 19:36, Vitaly Kuznetsov wrote: Zhenzhong Duan writes: ...snip diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c index 249f14a..3945aa5 100644 --- a/arch/x86/kernel/kvm.c +++ b/arch/x86/kernel/kvm.c @@ -825,18 +825,36 @@ __visible bool __kvm_vcpu_is_preempt

Re: [PATCH v7 3/5] x86/kvm: Add "nopvspin" parameter to disable PV spinlocks

2019-10-22 Thread Vitaly Kuznetsov
Zhenzhong Duan writes: > There are cases where a guest tries to switch spinlocks to bare metal > behavior (e.g. by setting "xen_nopvspin" on XEN platform and > "hv_nopvspin" on HYPER_V). > > That feature is missed on KVM, add a new parameter "nopvspin" to disable > PV spinlocks for KVM guest. > >

[PATCH v7 3/5] x86/kvm: Add "nopvspin" parameter to disable PV spinlocks

2019-10-22 Thread Zhenzhong Duan
There are cases where a guest tries to switch spinlocks to bare metal behavior (e.g. by setting "xen_nopvspin" on XEN platform and "hv_nopvspin" on HYPER_V). That feature is missed on KVM, add a new parameter "nopvspin" to disable PV spinlocks for KVM guest. The new 'nopvspin' parameter will also