Re: [PATCH v7 4/5] iio: trigger: Introduce IIO hrtimer based trigger

2015-09-02 Thread Vladimir Barinov
Hi Lars, On 31.08.2015 17:57, Lars-Peter Clausen wrote: On 08/17/2015 02:45 PM, Vladimir Barinov wrote: Hello Daniel, I've verified that your hrtimer trigger works. I have minor suggestions. Will not it be useful to have ability to stop/start hrtimer polling not only during attach/detach tri

Re: [PATCH v7 4/5] iio: trigger: Introduce IIO hrtimer based trigger

2015-08-31 Thread Lars-Peter Clausen
On 08/11/2015 12:42 AM, Daniel Baluta wrote: [...] > + > +static struct iio_sw_trigger *iio_trig_hrtimer_probe(const char *name) > +{ > + struct iio_hrtimer_info *trig_info; > + int ret; > + > + trig_info = kzalloc(sizeof(*trig_info), GFP_KERNEL); > + if (!trig_info) > +

Re: [PATCH v7 4/5] iio: trigger: Introduce IIO hrtimer based trigger

2015-08-31 Thread Lars-Peter Clausen
On 08/17/2015 02:45 PM, Vladimir Barinov wrote: > Hello Daniel, > > I've verified that your hrtimer trigger works. > > I have minor suggestions. > > Will not it be useful to have ability to stop/start hrtimer polling > not only during attach/detach trigger. > > f.e. writing 0 to sampling_freque

Re: [PATCH v7 4/5] iio: trigger: Introduce IIO hrtimer based trigger

2015-08-17 Thread Daniel Baluta
On Mon, Aug 17, 2015 at 3:45 PM, Vladimir Barinov wrote: > Hello Daniel, > > I've verified that your hrtimer trigger works. > > I have minor suggestions. > > Will not it be useful to have ability to stop/start hrtimer polling > not only during attach/detach trigger. > > f.e. writing 0 to sampling_

Re: [PATCH v7 4/5] iio: trigger: Introduce IIO hrtimer based trigger

2015-08-17 Thread Vladimir Barinov
Hello Daniel, I've verified that your hrtimer trigger works. I have minor suggestions. Will not it be useful to have ability to stop/start hrtimer polling not only during attach/detach trigger. f.e. writing 0 to sampling_frequency will hrtimer_cancel and writing any valid frequency will hrtime

[PATCH v7 4/5] iio: trigger: Introduce IIO hrtimer based trigger

2015-08-10 Thread Daniel Baluta
This patch registers a new IIO software trigger interrupt source based on high resolution timers. Notice that if configfs is enabled we create sampling_frequency attribute allowing users to change hrtimer period (1/sampling_frequency). The IIO hrtimer trigger has a long history, this patch is bas