Re: [PATCH v7 4/7] pwm: ntxec: Add driver for PWM function in Netronix EC

2021-01-14 Thread Jonathan Neuschäfer
On Wed, Jan 13, 2021 at 11:46:45PM +0100, Andreas Kemnade wrote: > On Tue, 12 Jan 2021 20:39:02 +0100 > Andreas Kemnade wrote: > > [...] > > > +static int ntxec_pwm_probe(struct platform_device *pdev) [...] > > Hmm, I needed > > chip->dev = >dev.parent to use the backlight example > > in patch

Re: [PATCH v7 4/7] pwm: ntxec: Add driver for PWM function in Netronix EC

2021-01-13 Thread Andreas Kemnade
On Tue, 12 Jan 2021 20:39:02 +0100 Andreas Kemnade wrote: [...] > > +static int ntxec_pwm_probe(struct platform_device *pdev) > > +{ > > + struct ntxec *ec = dev_get_drvdata(pdev->dev.parent); > > + struct ntxec_pwm *priv; > > + struct pwm_chip *chip; > > + > > + priv =

Re: [PATCH v7 4/7] pwm: ntxec: Add driver for PWM function in Netronix EC

2021-01-12 Thread Andreas Kemnade
On Sat, 9 Jan 2021 19:02:17 +0100 Jonathan Neuschäfer wrote: > The Netronix EC provides a PWM output which is used for the backlight > on some ebook readers. This patches adds a driver for the PWM output. > > The .get_state callback is not implemented, because the PWM state can't > be read

Re: [PATCH v7 4/7] pwm: ntxec: Add driver for PWM function in Netronix EC

2021-01-11 Thread Lee Jones
On Mon, 11 Jan 2021, Thierry Reding wrote: > On Sat, Jan 09, 2021 at 07:02:17PM +0100, Jonathan Neuschäfer wrote: > > The Netronix EC provides a PWM output which is used for the backlight > > on some ebook readers. This patches adds a driver for the PWM output. > > > > The .get_state callback is

Re: [PATCH v7 4/7] pwm: ntxec: Add driver for PWM function in Netronix EC

2021-01-11 Thread Thierry Reding
On Sat, Jan 09, 2021 at 07:02:17PM +0100, Jonathan Neuschäfer wrote: > The Netronix EC provides a PWM output which is used for the backlight > on some ebook readers. This patches adds a driver for the PWM output. > > The .get_state callback is not implemented, because the PWM state can't > be

Re: [PATCH v7 4/7] pwm: ntxec: Add driver for PWM function in Netronix EC

2021-01-11 Thread Uwe Kleine-König
Hello, On Sat, Jan 09, 2021 at 07:02:17PM +0100, Jonathan Neuschäfer wrote: > The Netronix EC provides a PWM output which is used for the backlight > on some ebook readers. This patches adds a driver for the PWM output. > > The .get_state callback is not implemented, because the PWM state can't

[PATCH v7 4/7] pwm: ntxec: Add driver for PWM function in Netronix EC

2021-01-09 Thread Jonathan Neuschäfer
The Netronix EC provides a PWM output which is used for the backlight on some ebook readers. This patches adds a driver for the PWM output. The .get_state callback is not implemented, because the PWM state can't be read back from the hardware. Signed-off-by: Jonathan Neuschäfer --- v7: - no