Re: [PATCH v7 5/5] ima: Get rid of ima_used_chip and use ima_tpm_chip != NULL instead

2018-07-02 Thread Stefan Berger
On 07/02/2018 11:11 AM, Mimi Zohar wrote: Hi Stefan, On Tue, 2018-06-26 at 15:09 -0400, Stefan Berger wrote: Get rid of ima_used_chip and use ima_tpm_chip variable instead for determining whether to use the TPM chip. I don't see a need for separating this change from the previous patch. Could

Re: [PATCH v7 5/5] ima: Get rid of ima_used_chip and use ima_tpm_chip != NULL instead

2018-07-02 Thread Stefan Berger
On 07/02/2018 11:11 AM, Mimi Zohar wrote: Hi Stefan, On Tue, 2018-06-26 at 15:09 -0400, Stefan Berger wrote: Get rid of ima_used_chip and use ima_tpm_chip variable instead for determining whether to use the TPM chip. I don't see a need for separating this change from the previous patch. Could

Re: [PATCH v7 5/5] ima: Get rid of ima_used_chip and use ima_tpm_chip != NULL instead

2018-07-02 Thread Mimi Zohar
Hi Stefan, On Tue, 2018-06-26 at 15:09 -0400, Stefan Berger wrote: > Get rid of ima_used_chip and use ima_tpm_chip variable instead for > determining whether to use the TPM chip. I don't see a need for separating this change from the previous patch. Could you squash this patch with the previous

Re: [PATCH v7 5/5] ima: Get rid of ima_used_chip and use ima_tpm_chip != NULL instead

2018-07-02 Thread Mimi Zohar
Hi Stefan, On Tue, 2018-06-26 at 15:09 -0400, Stefan Berger wrote: > Get rid of ima_used_chip and use ima_tpm_chip variable instead for > determining whether to use the TPM chip. I don't see a need for separating this change from the previous patch. Could you squash this patch with the previous

[PATCH v7 5/5] ima: Get rid of ima_used_chip and use ima_tpm_chip != NULL instead

2018-06-26 Thread Stefan Berger
Get rid of ima_used_chip and use ima_tpm_chip variable instead for determining whether to use the TPM chip. Signed-off-by: Stefan Berger Acked-by: Jarkko Sakkinen --- security/integrity/ima/ima.h| 1 - security/integrity/ima/ima_crypto.c | 2 +- security/integrity/ima/ima_init.c | 7

[PATCH v7 5/5] ima: Get rid of ima_used_chip and use ima_tpm_chip != NULL instead

2018-06-26 Thread Stefan Berger
Get rid of ima_used_chip and use ima_tpm_chip variable instead for determining whether to use the TPM chip. Signed-off-by: Stefan Berger Acked-by: Jarkko Sakkinen --- security/integrity/ima/ima.h| 1 - security/integrity/ima/ima_crypto.c | 2 +- security/integrity/ima/ima_init.c | 7