[PATCH v7 6/9] acpi/hed: Move handler installing logic to driver

[Michal Wilczynski]

Currently logic for installing notifications from ACPI devices is
implemented using notify callback in struct acpi_driver. Preparations
are being made to replace acpi_driver with more generic struct
platform_driver, which doesn't contain notify callback. Furthermore
as of now handlers are being called indirectly through
acpi_notify_device(), which decreases performance.

Call acpi_dev_install_notify_handler() at the end of .add() callback.
Call acpi_dev_remove_notify_handler() at the beginning of .remove()
callback. Change arguments passed to the notify function to match with
what's required by acpi_dev_install_notify_handler(). Remove .notify
callback initialization in acpi_driver.

Suggested-by: Rafael J. Wysocki <rafael.j.wyso...@intel.com>
Signed-off-by: Michal Wilczynski <michal.wilczyn...@intel.com>
---
 drivers/acpi/hed.c | 17 ++++++++++++++---
 1 file changed, 14 insertions(+), 3 deletions(-)

diff --git a/drivers/acpi/hed.c b/drivers/acpi/hed.c
index 78d44e3fe129..8f54560c6d1c 100644
--- a/drivers/acpi/hed.c
+++ b/drivers/acpi/hed.c
@@ -42,22 +42,34 @@ EXPORT_SYMBOL_GPL(unregister_acpi_hed_notifier);
  * it is used by HEST Generic Hardware Error Source with notify type
  * SCI.
  */
-static void acpi_hed_notify(struct acpi_device *device, u32 event)
+static void acpi_hed_notify(acpi_handle handle, u32 event, void *data)
 {
        blocking_notifier_call_chain(&acpi_hed_notify_list, 0, NULL);
 }
 
 static int acpi_hed_add(struct acpi_device *device)
 {
+       int err;
+
        /* Only one hardware error device */
        if (hed_handle)
                return -EINVAL;
        hed_handle = device->handle;
-       return 0;
+
+       err = acpi_dev_install_notify_handler(device,
+                                             ACPI_DEVICE_NOTIFY,
+                                             acpi_hed_notify);
+       if (err)
+               hed_handle = NULL;
+
+       return err;
 }
 
 static void acpi_hed_remove(struct acpi_device *device)
 {
+       acpi_dev_remove_notify_handler(device,
+                                      ACPI_DEVICE_NOTIFY,
+                                      acpi_hed_notify);
        hed_handle = NULL;
 }
 
@@ -68,7 +80,6 @@ static struct acpi_driver acpi_hed_driver = {
        .ops = {
                .add = acpi_hed_add,
                .remove = acpi_hed_remove,
-               .notify = acpi_hed_notify,
        },
 };
 module_acpi_driver(acpi_hed_driver);
-- 
2.41.0