Re: [PATCH v7 8/8] selinux: include a consumer of the new IMA critical data hook

2020-12-11 Thread Lakshmi Ramasubramanian
On 12/11/20 7:41 AM, Tyler Hicks wrote: On 2020-12-11 09:36:30, Tyler Hicks wrote: The calls to pr_err() in this aren't quite following the style of the other error SELinux error messages. Sorry, I left out a word. I meant to say that the calls to pr_err() in this *file* aren't quite

Re: [PATCH v7 8/8] selinux: include a consumer of the new IMA critical data hook

2020-12-11 Thread Tyler Hicks
On 2020-12-11 09:36:30, Tyler Hicks wrote: > The calls to pr_err() in this aren't quite following the style of the > other error SELinux error messages. Sorry, I left out a word. I meant to say that the calls to pr_err() in this *file* aren't quite following the right style. Please adjust all of

Re: [PATCH v7 8/8] selinux: include a consumer of the new IMA critical data hook

2020-12-11 Thread Tyler Hicks
On 2020-12-09 11:42:12, Tushar Sugandhi wrote: > From: Lakshmi Ramasubramanian > > IMA measures files and buffer data such as keys, command line arguments > passed to the kernel on kexec system call, etc. While these measurements > enable monitoring and validating the integrity of the system, it

[PATCH v7 8/8] selinux: include a consumer of the new IMA critical data hook

2020-12-09 Thread Tushar Sugandhi
From: Lakshmi Ramasubramanian IMA measures files and buffer data such as keys, command line arguments passed to the kernel on kexec system call, etc. While these measurements enable monitoring and validating the integrity of the system, it is not sufficient. Various data structures, policies and