RE: [PATCH v7 RESEND 07/13] spi: imx: fix ERR009165

2020-05-13 Thread Robin Gong
On 2020/05/13 Sascha Hauer wrote: > On Wed, May 13, 2020 at 08:52:39AM +, Robin Gong wrote: > > On 2020/05/13 16:48 Sascha Hauer wrote: > > > On Wed, May 13, 2020 at 08:38:26AM +, Robin Gong wrote: > > > > On 2020/05/13 Sascha Hauer wrote: > > > > > This patch is the one bisecting will e

RE: [PATCH v7 RESEND 07/13] spi: imx: fix ERR009165

2020-05-13 Thread Robin Gong
On 2020/05/13 Sascha Hauer wrote: > On Wed, May 13, 2020 at 09:05:33AM +, Robin Gong wrote: > > On 2020/05/13 Sascha Hauer wrote:d > > > > drivers/spi/spi-imx.c | 16 > > > > 1 file changed, 8 insertions(+), 8 deletions(-) > > > > > > > > diff --git a/drivers/spi/spi-imx.c b

Re: [PATCH v7 RESEND 07/13] spi: imx: fix ERR009165

2020-05-13 Thread Sascha Hauer
On Wed, May 13, 2020 at 08:52:39AM +, Robin Gong wrote: > On 2020/05/13 16:48 Sascha Hauer wrote: > > On Wed, May 13, 2020 at 08:38:26AM +, Robin Gong wrote: > > > On 2020/05/13 Sascha Hauer wrote: > > > > This patch is the one bisecting will end up with when somebody uses > > > > an olde

Re: [PATCH v7 RESEND 07/13] spi: imx: fix ERR009165

2020-05-13 Thread Sascha Hauer
On Wed, May 13, 2020 at 09:05:33AM +, Robin Gong wrote: > On 2020/05/13 Sascha Hauer wrote:d > > > drivers/spi/spi-imx.c | 16 > > > 1 file changed, 8 insertions(+), 8 deletions(-) > > > > > > diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c index > > > f4f28a4..70d

RE: [PATCH v7 RESEND 07/13] spi: imx: fix ERR009165

2020-05-13 Thread Robin Gong
On 2020/05/13 Sascha Hauer wrote:d > > drivers/spi/spi-imx.c | 16 > > 1 file changed, 8 insertions(+), 8 deletions(-) > > > > diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c index > > f4f28a4..70df8e6 100644 > > --- a/drivers/spi/spi-imx.c > > +++ b/drivers/spi/spi-im

RE: [PATCH v7 RESEND 07/13] spi: imx: fix ERR009165

2020-05-13 Thread Robin Gong
On 2020/05/13 16:48 Sascha Hauer wrote: > On Wed, May 13, 2020 at 08:38:26AM +, Robin Gong wrote: > > On 2020/05/13 Sascha Hauer wrote: > > > This patch is the one bisecting will end up with when somebody uses > > > an older SDMA firmware or the ROM scripts. It should have a better > > > desc

Re: [PATCH v7 RESEND 07/13] spi: imx: fix ERR009165

2020-05-13 Thread Sascha Hauer
On Wed, May 13, 2020 at 08:38:26AM +, Robin Gong wrote: > On 2020/05/13 Sascha Hauer wrote: > > This patch is the one bisecting will end up with when somebody uses an older > > SDMA firmware or the ROM scripts. It should have a better description what > > happens and what should be done about

RE: [PATCH v7 RESEND 07/13] spi: imx: fix ERR009165

2020-05-13 Thread Robin Gong
On 2020/05/13 Sascha Hauer wrote: > This patch is the one bisecting will end up with when somebody uses an older > SDMA firmware or the ROM scripts. It should have a better description what > happens and what should be done about it. Emm..That's true. Timeout will be caught in such case, hence, ma

Re: [PATCH v7 RESEND 07/13] spi: imx: fix ERR009165

2020-05-13 Thread Sascha Hauer
On Tue, May 12, 2020 at 01:32:30AM +0800, Robin Gong wrote: > Change to XCH mode even in dma mode, please refer to the below > errata: > https://www.nxp.com/docs/en/errata/IMX6DQCE.pdf > > Signed-off-by: Robin Gong > Acked-by: Mark Brown > --- > drivers/spi/spi-imx.c | 16 > 1

Re: [PATCH v7 RESEND 07/13] spi: imx: fix ERR009165

2020-05-13 Thread Sascha Hauer
On Tue, May 12, 2020 at 01:32:30AM +0800, Robin Gong wrote: > Change to XCH mode even in dma mode, please refer to the below > errata: > https://www.nxp.com/docs/en/errata/IMX6DQCE.pdf This patch is the one bisecting will end up with when somebody uses an older SDMA firmware or the ROM scripts. I

[PATCH v7 RESEND 07/13] spi: imx: fix ERR009165

2020-05-11 Thread Robin Gong
Change to XCH mode even in dma mode, please refer to the below errata: https://www.nxp.com/docs/en/errata/IMX6DQCE.pdf Signed-off-by: Robin Gong Acked-by: Mark Brown --- drivers/spi/spi-imx.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/spi/spi-i