Re: [PATCH v8] psmouse - focaltech pass finger width to userspace

2015-04-29 Thread Dmitry Tunin
> > Hi, > > Some comments below. If it is not a problem that width values are > outdated as soon as there are two or more fingers on the touchpad, I > think the change is good. > > Regards, > Mathias > > Am 24.04.2015 um 01:15 schrieb Dmitry Tunin: >> Focaltech touchpads report finger width in

Re: [PATCH v8] psmouse - focaltech pass finger width to userspace

2015-04-29 Thread Dmitry Tunin
Hi, Some comments below. If it is not a problem that width values are outdated as soon as there are two or more fingers on the touchpad, I think the change is good. Regards, Mathias Am 24.04.2015 um 01:15 schrieb Dmitry Tunin: Focaltech touchpads report finger width in packet[5] of

Re: [PATCH v8] psmouse - focaltech pass finger width to userspace

2015-04-24 Thread Dmitry Tunin
I see that I did not change that here. Width can be in state->width or fingers[finger]->width I think latter is mere correct.It should be that way in this patch. I moved ot back and forth and tested. Noticed no difference. 24.04.2015 13:44, Dmitry Tunin пишет: > >> >> Hi, >> >> Some comments

Re: [PATCH v8] psmouse - focaltech pass finger width to userspace

2015-04-24 Thread Dmitry Tunin
> > Hi, > > Some comments below. If it is not a problem that width values are > outdated as soon as there are two or more fingers on the touchpad, I > think the change is good. > > Regards, > Mathias > > Am 24.04.2015 um 01:15 schrieb Dmitry Tunin: >> Focaltech touchpads report finger width

Re: [PATCH v8] psmouse - focaltech pass finger width to userspace

2015-04-24 Thread Mathias Gottschlag
Hi, Some comments below. If it is not a problem that width values are outdated as soon as there are two or more fingers on the touchpad, I think the change is good. Regards, Mathias Am 24.04.2015 um 01:15 schrieb Dmitry Tunin: > Focaltech touchpads report finger width in packet[5] of absolute

Re: [PATCH v8] psmouse - focaltech pass finger width to userspace

2015-04-24 Thread Dmitry Tunin
I see that I did not change that here. Width can be in state-width or fingers[finger]-width I think latter is mere correct.It should be that way in this patch. I moved ot back and forth and tested. Noticed no difference. 24.04.2015 13:44, Dmitry Tunin пишет: Hi, Some comments below. If it

Re: [PATCH v8] psmouse - focaltech pass finger width to userspace

2015-04-24 Thread Dmitry Tunin
Hi, Some comments below. If it is not a problem that width values are outdated as soon as there are two or more fingers on the touchpad, I think the change is good. Regards, Mathias Am 24.04.2015 um 01:15 schrieb Dmitry Tunin: Focaltech touchpads report finger width in packet[5]

Re: [PATCH v8] psmouse - focaltech pass finger width to userspace

2015-04-24 Thread Mathias Gottschlag
Hi, Some comments below. If it is not a problem that width values are outdated as soon as there are two or more fingers on the touchpad, I think the change is good. Regards, Mathias Am 24.04.2015 um 01:15 schrieb Dmitry Tunin: Focaltech touchpads report finger width in packet[5] of absolute

[PATCH v8] psmouse - focaltech pass finger width to userspace

2015-04-23 Thread Dmitry Tunin
Focaltech touchpads report finger width in packet[5] of absolute packet. Range for width in raw format is 0x10 - 0x70. Second half-byte is always 0. 0xff is reported, when a large contact area is detected. This can be handled in userspace. Signed-off-by: Dmitry Tunin ---

[PATCH v8] psmouse - focaltech pass finger width to userspace

2015-04-23 Thread Dmitry Tunin
Focaltech touchpads report finger width in packet[5] of absolute packet. Range for width in raw format is 0x10 - 0x70. Second half-byte is always 0. 0xff is reported, when a large contact area is detected. This can be handled in userspace. Signed-off-by: Dmitry Tunin hanipouspi...@gmail.com ---