Re: [PATCH v8 0/3] x86/earlyprintk: setup serial earlyprintk as early as possible

2015-06-02 Thread Alexander Kuleshov
2015-05-29 22:55 GMT+06:00 Borislav Petkov : > > You can boot with "ignore_loglevel" to see that message. Provided > ignore_loglevel is even parsed that early. > But ignore_loglevel is early_param too... > > Yes, I meant a testing patch which is used only for testing and which > issues a bunch of

Re: [PATCH v8 0/3] x86/earlyprintk: setup serial earlyprintk as early as possible

2015-05-29 Thread Borislav Petkov
On Thu, May 28, 2015 at 02:01:12PM +0600, Alexander Kuleshov wrote: > 2015-05-27 18:51 GMT+06:00 Borislav Petkov : > > Now, have you tested this on real hardware? Because your 0/n message > > said "qemu" but I don't think that's sufficient. If we're going to > > enable early_printk this early, we'd

Re: [PATCH v8 0/3] x86/earlyprintk: setup serial earlyprintk as early as possible

2015-05-28 Thread Alexander Kuleshov
2015-05-27 18:51 GMT+06:00 Borislav Petkov : > Now, have you tested this on real hardware? Because your 0/n message > said "qemu" but I don't think that's sufficient. If we're going to > enable early_printk this early, we'd need it working on real hardware > too. > > For that I'd suggest adding a 4

Re: [PATCH v8 0/3] x86/earlyprintk: setup serial earlyprintk as early as possible

2015-05-27 Thread Borislav Petkov
On Wed, May 27, 2015 at 06:12:59PM +0600, Alexander Kuleshov wrote: > Is it bad or we no need in it? I want to understand not only how > kernel works, but also why it written so and I can't understand why we > have 'earlyprintk' (or another feature) in one place and do not have > in another. So ho

Re: [PATCH v8 0/3] x86/earlyprintk: setup serial earlyprintk as early as possible

2015-05-27 Thread Alexander Kuleshov
2015-05-27 18:01 GMT+06:00 Borislav Petkov : > Yes, and I'm simply asking why do we even want to use it there at all. > What do you think would need to be dumped with early_printk() calls > there and would be useful? > > IOW, do you have a sensible use case for why we need it there or not? Is earl

Re: [PATCH v8 0/3] x86/earlyprintk: setup serial earlyprintk as early as possible

2015-05-27 Thread Borislav Petkov
On Wed, May 27, 2015 at 01:33:23PM +0600, Alexander Kuleshov wrote: > We can't use earlyprintk from the arch/x86/kernel/head{32,64}.c before > parse_early_param from the arch/x86/kernel/setup.c. Yes, and I'm simply asking why do we even want to use it there at all. What do you think would need to

Re: [PATCH v8 0/3] x86/earlyprintk: setup serial earlyprintk as early as possible

2015-05-27 Thread Alexander Kuleshov
Hello Borislav, 2015-05-27 3:34 GMT+06:00 Borislav Petkov : > On Tue, May 26, 2015 at 08:11:07PM +0600, Alexander Kuleshov wrote: >> It is not "just because we can". There is some code after kernel >> decompression and before parse_early_param and earlyprintk can be >> useful for printing debuggin

Re: [PATCH v8 0/3] x86/earlyprintk: setup serial earlyprintk as early as possible

2015-05-26 Thread Borislav Petkov
On Tue, May 26, 2015 at 08:11:07PM +0600, Alexander Kuleshov wrote: > It is not "just because we can". There is some code after kernel > decompression and before parse_early_param and earlyprintk can be > useful for printing debugging information in this case. Which code? Please show me. Because

Re: [PATCH v8 0/3] x86/earlyprintk: setup serial earlyprintk as early as possible

2015-05-26 Thread Andy Shevchenko
On Tue, 2015-05-26 at 20:11 +0600, Alexander Kuleshov wrote: > 2015-05-26 19:57 GMT+06:00 Borislav Petkov : > > On Tue, May 26, 2015 at 07:20:02PM +0600, Alexander Kuleshov wrote: > >> To be able to use early_printk and serial console between kernel > >> decompression and parse_eary_param. > > > >

Re: [PATCH v8 0/3] x86/earlyprintk: setup serial earlyprintk as early as possible

2015-05-26 Thread Alexander Kuleshov
2015-05-26 19:57 GMT+06:00 Borislav Petkov : > On Tue, May 26, 2015 at 07:20:02PM +0600, Alexander Kuleshov wrote: >> To be able to use early_printk and serial console between kernel >> decompression and parse_eary_param. > > So no real use case - only a "just because we can" case. > It is not "ju

Re: [PATCH v8 0/3] x86/earlyprintk: setup serial earlyprintk as early as possible

2015-05-26 Thread Borislav Petkov
On Tue, May 26, 2015 at 07:20:02PM +0600, Alexander Kuleshov wrote: > To be able to use early_printk and serial console between kernel > decompression and parse_eary_param. So no real use case - only a "just because we can" case. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when y

Re: [PATCH v8 0/3] x86/earlyprintk: setup serial earlyprintk as early as possible

2015-05-26 Thread Borislav Petkov
On Tue, May 26, 2015 at 07:06:47PM +0600, Alexander Kuleshov wrote: > The early_printk function is usable only after the setup_early_printk will > be executed. We pass 'earlyprintk' through the kernel command line. So, it > means that earlyprintk will be usable only after the 'parse_early_param' >

Re: [PATCH v8 0/3] x86/earlyprintk: setup serial earlyprintk as early as possible

2015-05-26 Thread Alexander Kuleshov
2015-05-26 19:17 GMT+06:00 Borislav Petkov : > On Tue, May 26, 2015 at 07:06:47PM +0600, Alexander Kuleshov wrote: >> The early_printk function is usable only after the setup_early_printk will >> be executed. We pass 'earlyprintk' through the kernel command line. So, it >> means that earlyprintk wi

[PATCH v8 0/3] x86/earlyprintk: setup serial earlyprintk as early as possible

2015-05-26 Thread Alexander Kuleshov
The early_printk function is usable only after the setup_early_printk will be executed. We pass 'earlyprintk' through the kernel command line. So, it means that earlyprintk will be usable only after the 'parse_early_param' will be executed. We have usable earlyprintk only during early boot, kernel

[PATCH v8 0/3] x86/earlyprintk: setup serial earlyprintk as early as possible

2015-05-26 Thread Alexander Kuleshov
The early_printk function is usable only after the setup_early_printk will be executed. We pass 'earlyprintk' through the kernel command line. So, it means that earlyprintk will be usable only after the 'parse_early_param' will be executed. We have usable earlyprintk only during early boot, kernel