Re: [PATCH v8 0/8] Introduce the for_each_set_clump8 macro

2019-02-08 Thread Andy Shevchenko
On Tue, Jan 29, 2019 at 05:07:34PM -0800, Andrew Morton wrote: > On Mon, 14 Jan 2019 15:19:17 +0900 William Breathitt Gray > wrote: > It's a shame that it doesn't actually dercease the kernel line count, > but there are other benefits. > > The patches are missing the hoped-for acks, but I

Re: [PATCH v8 0/8] Introduce the for_each_set_clump8 macro

2019-01-30 Thread Linus Walleij
On Wed, Jan 30, 2019 at 11:17 AM William Breathitt Gray wrote: > On Tue, Jan 29, 2019 at 05:07:34PM -0800, Andrew Morton wrote: > > Do we have any expectation that these facilities will be used by > > anything other than GPIO? If not then perhaps they should be sited > > within drivers/gpio

Re: [PATCH v8 0/8] Introduce the for_each_set_clump8 macro

2019-01-30 Thread William Breathitt Gray
On Tue, Jan 29, 2019 at 05:07:34PM -0800, Andrew Morton wrote: > Do we have any expectation that these facilities will be used by > anything other than GPIO? If not then perhaps they should be sited > within drivers/gpio (presumably as a standalone module) until such a > need is found? I can

Re: [PATCH v8 0/8] Introduce the for_each_set_clump8 macro

2019-01-30 Thread Linus Walleij
On Wed, Jan 30, 2019 at 2:07 AM Andrew Morton wrote: > On Mon, 14 Jan 2019 15:19:17 +0900 William Breathitt Gray > wrote: > > drivers/gpio/gpio-104-dio-48e.c | 73 ++-- > > drivers/gpio/gpio-104-idi-48.c| 37 +++--- > > drivers/gpio/gpio-gpio-mm.c | 73

Re: [PATCH v8 0/8] Introduce the for_each_set_clump8 macro

2019-01-29 Thread Andrew Morton
On Mon, 14 Jan 2019 15:19:17 +0900 William Breathitt Gray wrote: > While adding GPIO get_multiple/set_multiple callback support for various > drivers, I noticed a pattern of looping manifesting that would be useful > standardized as a macro. > > This patchset introduces the for_each_set_clump8

[PATCH v8 0/8] Introduce the for_each_set_clump8 macro

2019-01-13 Thread William Breathitt Gray
Changes in v8: - Return unsigned long for bitmap_get_value8 for consistency - Add clobbering risk warning to bitmap_set_value8 documentation - Reimplement bitmap_get_value8 and bitmap_set_value8 to account for clumps that fall across bitmap word boundaries - Add a bitmap size argument