Re: [PATCH v8 0/8] livepatch: Atomic replace feature

2018-03-06 Thread Petr Mladek
On Mon 2018-03-05 13:54:38, Miroslav Benes wrote: > On Mon, 5 Mar 2018, Evgenii Shatokhin wrote: > > > Hi, > > Hi, > > > > The atomic replace allows to create cumulative patches. They > > > are useful when you maintain many livepatches and want to remove > > > one that is lower on the stack.

Re: [PATCH v8 0/8] livepatch: Atomic replace feature

2018-03-06 Thread Petr Mladek
On Mon 2018-03-05 13:54:38, Miroslav Benes wrote: > On Mon, 5 Mar 2018, Evgenii Shatokhin wrote: > > > Hi, > > Hi, > > > > The atomic replace allows to create cumulative patches. They > > > are useful when you maintain many livepatches and want to remove > > > one that is lower on the stack.

Re: [PATCH v8 0/8] livepatch: Atomic replace feature

2018-03-05 Thread Miroslav Benes
On Mon, 5 Mar 2018, Evgenii Shatokhin wrote: > Hi, Hi, > > The atomic replace allows to create cumulative patches. They > > are useful when you maintain many livepatches and want to remove > > one that is lower on the stack. In addition it is very useful when > > more patches touch the same

Re: [PATCH v8 0/8] livepatch: Atomic replace feature

2018-03-05 Thread Miroslav Benes
On Mon, 5 Mar 2018, Evgenii Shatokhin wrote: > Hi, Hi, > > The atomic replace allows to create cumulative patches. They > > are useful when you maintain many livepatches and want to remove > > one that is lower on the stack. In addition it is very useful when > > more patches touch the same

Re: [PATCH v8 0/8] livepatch: Atomic replace feature

2018-03-05 Thread Evgenii Shatokhin
Hi, Petr, Jason - thanks a lot for working on this series, first of all! And especially for your patience. On 21.02.2018 16:29, Petr Mladek wrote: The atomic replace allows to create cumulative patches. They are useful when you maintain many livepatches and want to remove one that is lower

Re: [PATCH v8 0/8] livepatch: Atomic replace feature

2018-03-05 Thread Evgenii Shatokhin
Hi, Petr, Jason - thanks a lot for working on this series, first of all! And especially for your patience. On 21.02.2018 16:29, Petr Mladek wrote: The atomic replace allows to create cumulative patches. They are useful when you maintain many livepatches and want to remove one that is lower

Re: [PATCH v8 0/8] livepatch: Atomic replace feature

2018-02-22 Thread Miroslav Benes
> I have found one bug in v7. We were not able to initialize NOP > struct klp_func when the patches module is not loaded. It was > because func->new_func was NULL. I have fixed it in separate patch > for an easier review. This is embarassing. I'd swear I tested this. At least it was a part of my

Re: [PATCH v8 0/8] livepatch: Atomic replace feature

2018-02-22 Thread Miroslav Benes
> I have found one bug in v7. We were not able to initialize NOP > struct klp_func when the patches module is not loaded. It was > because func->new_func was NULL. I have fixed it in separate patch > for an easier review. This is embarassing. I'd swear I tested this. At least it was a part of my

[PATCH v8 0/8] livepatch: Atomic replace feature

2018-02-21 Thread Petr Mladek
The atomic replace allows to create cumulative patches. They are useful when you maintain many livepatches and want to remove one that is lower on the stack. In addition it is very useful when more patches touch the same function and there are dependencies between them. I have found one bug in

[PATCH v8 0/8] livepatch: Atomic replace feature

2018-02-21 Thread Petr Mladek
The atomic replace allows to create cumulative patches. They are useful when you maintain many livepatches and want to remove one that is lower on the stack. In addition it is very useful when more patches touch the same function and there are dependencies between them. I have found one bug in