Re: [PATCH v8 01/14] ASoC: sun4i-i2s: Change set_chan_cfg() params

2020-10-27 Thread Maxime Ripard
On Mon, Oct 26, 2020 at 07:52:26PM +0100, Clément Péron wrote: > As slots and slot_width can be set manually using set_tdm(). > These values are then kept in sun4i_i2s struct. > So we need to check if these values are set or not. > > This is not done actually and will trigger a bug. > For

[PATCH v8 01/14] ASoC: sun4i-i2s: Change set_chan_cfg() params

2020-10-26 Thread Clément Péron
As slots and slot_width can be set manually using set_tdm(). These values are then kept in sun4i_i2s struct. So we need to check if these values are set or not. This is not done actually and will trigger a bug. For example, if we set to the simple soundcard in the device-tree dai-tdm-slot-width =