Re: [PATCH v8 02/12] kthread: Kthread worker API cleanup

2016-06-13 Thread Steven Rostedt
On Mon, 13 Jun 2016 17:13:53 +0200 Petr Mladek wrote: > OK, all wants to keep DEFINE stuff as is: > > DEFINE_KTHREAD_WORKER() stay > DEFINE_KTHREAD_WORK() stay > DEFINE_KTHREAD_WORKER_ONSTACK() stay >

Re: [PATCH v8 02/12] kthread: Kthread worker API cleanup

2016-06-13 Thread Steven Rostedt
On Mon, 13 Jun 2016 17:13:53 +0200 Petr Mladek wrote: > OK, all wants to keep DEFINE stuff as is: > > DEFINE_KTHREAD_WORKER() stay > DEFINE_KTHREAD_WORK() stay > DEFINE_KTHREAD_WORKER_ONSTACK() stay > DEFINE_KTHREAD_WORKER_ONSTACK() stay > > >

Re: [PATCH v8 02/12] kthread: Kthread worker API cleanup

2016-06-13 Thread Petr Mladek
On Fri 2016-06-10 15:29:05, Andrew Morton wrote: > On Thu, 9 Jun 2016 11:07:10 -0400 Steven Rostedt wrote: > > > On Thu, 9 Jun 2016 15:51:56 +0200 > > Petr Mladek wrote: > > > > > A good practice is to prefix the names of functions and macros > > > by

Re: [PATCH v8 02/12] kthread: Kthread worker API cleanup

2016-06-13 Thread Petr Mladek
On Fri 2016-06-10 15:29:05, Andrew Morton wrote: > On Thu, 9 Jun 2016 11:07:10 -0400 Steven Rostedt wrote: > > > On Thu, 9 Jun 2016 15:51:56 +0200 > > Petr Mladek wrote: > > > > > A good practice is to prefix the names of functions and macros > > > by the name of the subsystem. > > > > > >

Re: [PATCH v8 02/12] kthread: Kthread worker API cleanup

2016-06-10 Thread Andrew Morton
On Thu, 9 Jun 2016 11:07:10 -0400 Steven Rostedt wrote: > On Thu, 9 Jun 2016 15:51:56 +0200 > Petr Mladek wrote: > > > A good practice is to prefix the names of functions and macros > > by the name of the subsystem. > > > > The kthread worker API is a

Re: [PATCH v8 02/12] kthread: Kthread worker API cleanup

2016-06-10 Thread Andrew Morton
On Thu, 9 Jun 2016 11:07:10 -0400 Steven Rostedt wrote: > On Thu, 9 Jun 2016 15:51:56 +0200 > Petr Mladek wrote: > > > A good practice is to prefix the names of functions and macros > > by the name of the subsystem. > > > > The kthread worker API is a mix of classic kthreads and workqueues.

Re: [PATCH v8 02/12] kthread: Kthread worker API cleanup

2016-06-09 Thread Peter Zijlstra
On Thu, Jun 09, 2016 at 03:51:56PM +0200, Petr Mladek wrote: > -#define DEFINE_KTHREAD_WORKER(worker) > \ > - struct kthread_worker worker = KTHREAD_WORKER_INIT(worker) > +#define KTHREAD_DECLARE_WORKER(worker) > \

Re: [PATCH v8 02/12] kthread: Kthread worker API cleanup

2016-06-09 Thread Peter Zijlstra
On Thu, Jun 09, 2016 at 03:51:56PM +0200, Petr Mladek wrote: > -#define DEFINE_KTHREAD_WORKER(worker) > \ > - struct kthread_worker worker = KTHREAD_WORKER_INIT(worker) > +#define KTHREAD_DECLARE_WORKER(worker) > \

Re: [PATCH v8 02/12] kthread: Kthread worker API cleanup

2016-06-09 Thread Steven Rostedt
On Thu, 9 Jun 2016 15:51:56 +0200 Petr Mladek wrote: > A good practice is to prefix the names of functions and macros > by the name of the subsystem. > > The kthread worker API is a mix of classic kthreads and workqueues. > Each worker has a dedicated kthread. It runs a

Re: [PATCH v8 02/12] kthread: Kthread worker API cleanup

2016-06-09 Thread Steven Rostedt
On Thu, 9 Jun 2016 15:51:56 +0200 Petr Mladek wrote: > A good practice is to prefix the names of functions and macros > by the name of the subsystem. > > The kthread worker API is a mix of classic kthreads and workqueues. > Each worker has a dedicated kthread. It runs a generic function > that

[PATCH v8 02/12] kthread: Kthread worker API cleanup

2016-06-09 Thread Petr Mladek
A good practice is to prefix the names of functions and macros by the name of the subsystem. The kthread worker API is a mix of classic kthreads and workqueues. Each worker has a dedicated kthread. It runs a generic function that process queued works. It is implemented as part of the kthread

[PATCH v8 02/12] kthread: Kthread worker API cleanup

2016-06-09 Thread Petr Mladek
A good practice is to prefix the names of functions and macros by the name of the subsystem. The kthread worker API is a mix of classic kthreads and workqueues. Each worker has a dedicated kthread. It runs a generic function that process queued works. It is implemented as part of the kthread