Re: [PATCH v8 04/14] media: rkisp1: add Rockchip MIPI Synopsys DPHY driver

2019-08-21 Thread Laurent Pinchart
Hi Helen, On Wed, Aug 21, 2019 at 06:46:15PM -0300, Helen Koike wrote: > On 8/15/19 2:54 PM, Laurent Pinchart wrote: > > On Wed, Aug 07, 2019 at 10:37:55AM -0300, Helen Koike wrote: > >> On 8/7/19 10:05 AM, Sakari Ailus wrote: > >>> On Tue, Jul 30, 2019 at 03:42:46PM -0300, Helen Koike wrote: > >>

Re: [PATCH v8 04/14] media: rkisp1: add Rockchip MIPI Synopsys DPHY driver

2019-08-21 Thread Helen Koike
Hi Laurent, Thanks for your review, I just have some comments/questions below. On 8/15/19 2:54 PM, Laurent Pinchart wrote: > Hi Helen, > > Thank you for the patch. > > On Wed, Aug 07, 2019 at 10:37:55AM -0300, Helen Koike wrote: >> On 8/7/19 10:05 AM, Sakari Ailus wrote: >>> On Tue, Jul 30, 201

Re: [PATCH v8 04/14] media: rkisp1: add Rockchip MIPI Synopsys DPHY driver

2019-08-15 Thread Heiko Stübner
Hi Laurent, Am Donnerstag, 15. August 2019, 19:54:40 CEST schrieb Laurent Pinchart: > On Wed, Aug 07, 2019 at 10:37:55AM -0300, Helen Koike wrote: > > On 8/7/19 10:05 AM, Sakari Ailus wrote: > > > On Tue, Jul 30, 2019 at 03:42:46PM -0300, Helen Koike wrote: > > >> From: Jacob Chen > > >> > > >> T

Re: [PATCH v8 04/14] media: rkisp1: add Rockchip MIPI Synopsys DPHY driver

2019-08-15 Thread Laurent Pinchart
Hi Helen, Thank you for the patch. On Wed, Aug 07, 2019 at 10:37:55AM -0300, Helen Koike wrote: > On 8/7/19 10:05 AM, Sakari Ailus wrote: > > On Tue, Jul 30, 2019 at 03:42:46PM -0300, Helen Koike wrote: > >> From: Jacob Chen > >> > >> This commit adds a subdev driver for Rockchip MIPI Synopsys D

Re: [PATCH v8 04/14] media: rkisp1: add Rockchip MIPI Synopsys DPHY driver

2019-08-07 Thread Helen Koike
Hi Sakari, thanks for your review, On 8/7/19 10:05 AM, Sakari Ailus wrote: > Hi Helen, > > Thanks for the patchset. > > On Tue, Jul 30, 2019 at 03:42:46PM -0300, Helen Koike wrote: >> From: Jacob Chen >> >> This commit adds a subdev driver for Rockchip MIPI Synopsys DPHY driver >> >> Signed-of

Re: [PATCH v8 04/14] media: rkisp1: add Rockchip MIPI Synopsys DPHY driver

2019-08-07 Thread Sakari Ailus
Hi Helen, Thanks for the patchset. On Tue, Jul 30, 2019 at 03:42:46PM -0300, Helen Koike wrote: > From: Jacob Chen > > This commit adds a subdev driver for Rockchip MIPI Synopsys DPHY driver > > Signed-off-by: Jacob Chen > Signed-off-by: Shunqian Zheng > Signed-off-by: Tomasz Figa > [migrat

[PATCH v8 04/14] media: rkisp1: add Rockchip MIPI Synopsys DPHY driver

2019-07-30 Thread Helen Koike
From: Jacob Chen This commit adds a subdev driver for Rockchip MIPI Synopsys DPHY driver Signed-off-by: Jacob Chen Signed-off-by: Shunqian Zheng Signed-off-by: Tomasz Figa [migrate to phy framework] Signed-off-by: Ezequiel Garcia [update for upstream] Signed-off-by: Helen Koike --- Change