Re: [PATCH v8 04/18] perf ftrace: add option '-m/--buffer-size' to set per-cpu buffer size

Em Fri, Aug 14, 2020 at 09:12:50AM -0300, Arnaldo Carvalho de Melo escreveu: > > It indicates that the argument is in units of 'pages', while you don't > > state that in: > > > > $ perf ftrace -h -m > > > > -m, --buffer-size > > size of per cpu buffer I

Re: [PATCH v8 04/18] perf ftrace: add option '-m/--buffer-size' to set per-cpu buffer size

Em Fri, Aug 14, 2020 at 08:53:18AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Sat, Aug 08, 2020 at 10:31:27AM +0800, Changbin Du escreveu: > > This adds an option '-m/--buffer-size' to allow us set the size of per-cpu > > tracing buffer. > > > > Signed-off-by: Changbin Du > > So this is a

Re: [PATCH v8 04/18] perf ftrace: add option '-m/--buffer-size' to set per-cpu buffer size

Em Sat, Aug 08, 2020 at 10:31:27AM +0800, Changbin Du escreveu: > This adds an option '-m/--buffer-size' to allow us set the size of per-cpu > tracing buffer. > > Signed-off-by: Changbin Du So this is a little bit confusing, i.e. if I don't specify a suffix (B, K, M, G) I get: # perf ftrace

[PATCH v8 04/18] perf ftrace: add option '-m/--buffer-size' to set per-cpu buffer size

This adds an option '-m/--buffer-size' to allow us set the size of per-cpu tracing buffer. Signed-off-by: Changbin Du --- v2: support units as a suffix. --- tools/perf/Documentation/perf-ftrace.txt | 5 +++ tools/perf/builtin-ftrace.c | 55 2 files