Re: [PATCH v8 05/14] media: rkisp1: add Rockchip ISP1 subdev driver

2020-08-12 Thread Dafna Hirschfeld
Am 07.08.20 um 18:08 schrieb Dafna Hirschfeld: Hi Am 06.08.20 um 14:22 schrieb Tomasz Figa: On Thu, Aug 6, 2020 at 11:21 AM Dafna Hirschfeld wrote: Am 05.08.20 um 23:10 schrieb Dafna Hirschfeld: Hi On 22.07.20 17:24, Tomasz Figa wrote: Hi Dafna, On Sat, Jul 11, 2020 at 01:04:31PM +0

Re: [PATCH v8 05/14] media: rkisp1: add Rockchip ISP1 subdev driver

2020-08-07 Thread Dafna Hirschfeld
Hi Am 06.08.20 um 14:22 schrieb Tomasz Figa: On Thu, Aug 6, 2020 at 11:21 AM Dafna Hirschfeld wrote: Am 05.08.20 um 23:10 schrieb Dafna Hirschfeld: Hi On 22.07.20 17:24, Tomasz Figa wrote: Hi Dafna, On Sat, Jul 11, 2020 at 01:04:31PM +0200, Dafna Hirschfeld wrote: Hi Laurent, On 16.08

Re: [PATCH v8 05/14] media: rkisp1: add Rockchip ISP1 subdev driver

2020-08-07 Thread Dafna Hirschfeld
Hi, Am 06.08.20 um 14:08 schrieb Tomasz Figa: On Wed, Aug 5, 2020 at 11:10 PM Dafna Hirschfeld wrote: Hi On 22.07.20 17:24, Tomasz Figa wrote: Hi Dafna, On Sat, Jul 11, 2020 at 01:04:31PM +0200, Dafna Hirschfeld wrote: Hi Laurent, On 16.08.19 02:13, Laurent Pinchart wrote: Hello Helen,

Re: [PATCH v8 05/14] media: rkisp1: add Rockchip ISP1 subdev driver

2020-08-06 Thread Tomasz Figa
On Thu, Aug 6, 2020 at 11:21 AM Dafna Hirschfeld wrote: > > > > Am 05.08.20 um 23:10 schrieb Dafna Hirschfeld: > > Hi > > > > On 22.07.20 17:24, Tomasz Figa wrote: > >> Hi Dafna, > >> > >> On Sat, Jul 11, 2020 at 01:04:31PM +0200, Dafna Hirschfeld wrote: > >>> Hi Laurent, > >>> > >>> On 16.08.19 0

Re: [PATCH v8 05/14] media: rkisp1: add Rockchip ISP1 subdev driver

2020-08-06 Thread Tomasz Figa
On Wed, Aug 5, 2020 at 11:10 PM Dafna Hirschfeld wrote: > > Hi > > On 22.07.20 17:24, Tomasz Figa wrote: > > Hi Dafna, > > > > On Sat, Jul 11, 2020 at 01:04:31PM +0200, Dafna Hirschfeld wrote: > >> Hi Laurent, > >> > >> On 16.08.19 02:13, Laurent Pinchart wrote: > >>> Hello Helen, > >>> > >>> Than

Re: [PATCH v8 05/14] media: rkisp1: add Rockchip ISP1 subdev driver

2020-08-06 Thread Dafna Hirschfeld
Am 05.08.20 um 23:10 schrieb Dafna Hirschfeld: Hi On 22.07.20 17:24, Tomasz Figa wrote: Hi Dafna, On Sat, Jul 11, 2020 at 01:04:31PM +0200, Dafna Hirschfeld wrote: Hi Laurent, On 16.08.19 02:13, Laurent Pinchart wrote: Hello Helen, Thank you for the patch. On Tue, Jul 30, 2019 at 03:42

Re: [PATCH v8 05/14] media: rkisp1: add Rockchip ISP1 subdev driver

2020-08-05 Thread Dafna Hirschfeld
Hi On 22.07.20 17:24, Tomasz Figa wrote: Hi Dafna, On Sat, Jul 11, 2020 at 01:04:31PM +0200, Dafna Hirschfeld wrote: Hi Laurent, On 16.08.19 02:13, Laurent Pinchart wrote: Hello Helen, Thank you for the patch. On Tue, Jul 30, 2019 at 03:42:47PM -0300, Helen Koike wrote: [snip] +static vo

Re: [PATCH v8 05/14] media: rkisp1: add Rockchip ISP1 subdev driver

2020-07-22 Thread Laurent Pinchart
Hi Tomasz, On Wed, Jul 22, 2020 at 07:12:12PM +0200, Tomasz Figa wrote: > On Wed, Jul 22, 2020 at 6:30 PM Laurent Pinchart wrote: > > On Wed, Jul 22, 2020 at 03:24:59PM +, Tomasz Figa wrote: > > > On Sat, Jul 11, 2020 at 01:04:31PM +0200, Dafna Hirschfeld wrote: > > > > On 16.08.19 02:13, Laur

Re: [PATCH v8 05/14] media: rkisp1: add Rockchip ISP1 subdev driver

2020-07-22 Thread Tomasz Figa
On Wed, Jul 22, 2020 at 6:30 PM Laurent Pinchart wrote: > > Hi Dafna and Tomasz, > > On Wed, Jul 22, 2020 at 03:24:59PM +, Tomasz Figa wrote: > > On Sat, Jul 11, 2020 at 01:04:31PM +0200, Dafna Hirschfeld wrote: > > > On 16.08.19 02:13, Laurent Pinchart wrote: > > > > On Tue, Jul 30, 2019 at 0

Re: [PATCH v8 05/14] media: rkisp1: add Rockchip ISP1 subdev driver

2020-07-22 Thread Laurent Pinchart
Hi Dafna and Tomasz, On Wed, Jul 22, 2020 at 03:24:59PM +, Tomasz Figa wrote: > On Sat, Jul 11, 2020 at 01:04:31PM +0200, Dafna Hirschfeld wrote: > > On 16.08.19 02:13, Laurent Pinchart wrote: > > > On Tue, Jul 30, 2019 at 03:42:47PM -0300, Helen Koike wrote: > > [snip] > > > > > +static void

Re: [PATCH v8 05/14] media: rkisp1: add Rockchip ISP1 subdev driver

2020-07-22 Thread Tomasz Figa
On Fri, Jul 17, 2020 at 09:46:24AM +0200, Dafna Hirschfeld wrote: > Hi, > > > On 11.07.20 13:04, Dafna Hirschfeld wrote: > > Hi Laurent, > > > > On 16.08.19 02:13, Laurent Pinchart wrote: > > > Hello Helen, > > > > > > Thank you for the patch. > > > > > > On Tue, Jul 30, 2019 at 03:42:47PM -03

Re: [PATCH v8 05/14] media: rkisp1: add Rockchip ISP1 subdev driver

2020-07-22 Thread Tomasz Figa
Hi Dafna, On Sat, Jul 11, 2020 at 01:04:31PM +0200, Dafna Hirschfeld wrote: > Hi Laurent, > > On 16.08.19 02:13, Laurent Pinchart wrote: > > Hello Helen, > > > > Thank you for the patch. > > > > On Tue, Jul 30, 2019 at 03:42:47PM -0300, Helen Koike wrote: [snip] > > > +static void rkisp1_isp_qu

Re: [PATCH v8 05/14] media: rkisp1: add Rockchip ISP1 subdev driver

2020-07-17 Thread Dafna Hirschfeld
Hi, On 11.07.20 13:04, Dafna Hirschfeld wrote: Hi Laurent, On 16.08.19 02:13, Laurent Pinchart wrote: Hello Helen, Thank you for the patch. On Tue, Jul 30, 2019 at 03:42:47PM -0300, Helen Koike wrote: From: Jacob Chen Add the subdev driver for rockchip isp1. Signed-off-by: Jacob Chen S

Re: [PATCH v8 05/14] media: rkisp1: add Rockchip ISP1 subdev driver

2020-07-11 Thread Dafna Hirschfeld
Hi Laurent, On 16.08.19 02:13, Laurent Pinchart wrote: Hello Helen, Thank you for the patch. On Tue, Jul 30, 2019 at 03:42:47PM -0300, Helen Koike wrote: From: Jacob Chen Add the subdev driver for rockchip isp1. Signed-off-by: Jacob Chen Signed-off-by: Shunqian Zheng Signed-off-by: Yicho

Re: [PATCH v8 05/14] media: rkisp1: add Rockchip ISP1 subdev driver

2019-08-15 Thread Laurent Pinchart
Hello Helen, Thank you for the patch. On Tue, Jul 30, 2019 at 03:42:47PM -0300, Helen Koike wrote: > From: Jacob Chen > > Add the subdev driver for rockchip isp1. > > Signed-off-by: Jacob Chen > Signed-off-by: Shunqian Zheng > Signed-off-by: Yichong Zhong > Signed-off-by: Jacob Chen > Sign

Re: [PATCH v8 05/14] media: rkisp1: add Rockchip ISP1 subdev driver

2019-08-15 Thread Laurent Pinchart
Hi Hans, On Wed, Aug 07, 2019 at 12:39:17PM +0200, Hans Verkuil wrote: > On 8/6/19 8:51 PM, Helen Koike wrote: > > On 7/30/19 3:42 PM, Helen Koike wrote: > >> From: Jacob Chen > >> > >> Add the subdev driver for rockchip isp1. > >> > >> Signed-off-by: Jacob Chen > >> Signed-off-by: Shunqian Zhen

Re: [PATCH v8 05/14] media: rkisp1: add Rockchip ISP1 subdev driver

2019-08-15 Thread Sakari Ailus
On Thu, Aug 15, 2019 at 11:24:22AM +0300, Sakari Ailus wrote: > Hi Helen, > > On Wed, Aug 14, 2019 at 09:58:05PM -0300, Helen Koike wrote: > > ... > > > >> +static int rkisp1_isp_sd_set_fmt(struct v4l2_subdev *sd, > > >> + struct v4l2_subdev_pad_config *cfg, > > >

Re: [PATCH v8 05/14] media: rkisp1: add Rockchip ISP1 subdev driver

2019-08-15 Thread Sakari Ailus
Hi Helen, On Wed, Aug 14, 2019 at 09:58:05PM -0300, Helen Koike wrote: ... > >> +static int rkisp1_isp_sd_set_fmt(struct v4l2_subdev *sd, > >> + struct v4l2_subdev_pad_config *cfg, > >> + struct v4l2_subdev_format *fmt) > >> +{ > >> + struct r

Re: [PATCH v8 05/14] media: rkisp1: add Rockchip ISP1 subdev driver

2019-08-14 Thread Helen Koike
Hi Sakari, Thanks for your review. I just have some comments/questions below. On 8/8/19 6:14 AM, Sakari Ailus wrote: > Hi Helen, > > On Tue, Jul 30, 2019 at 03:42:47PM -0300, Helen Koike wrote: >> From: Jacob Chen >> >> Add the subdev driver for rockchip isp1. >> >> Signed-off-by: Jacob Chen >

Re: [PATCH v8 05/14] media: rkisp1: add Rockchip ISP1 subdev driver

2019-08-08 Thread Sakari Ailus
Hi Helen, On Tue, Jul 30, 2019 at 03:42:47PM -0300, Helen Koike wrote: > From: Jacob Chen > > Add the subdev driver for rockchip isp1. > > Signed-off-by: Jacob Chen > Signed-off-by: Shunqian Zheng > Signed-off-by: Yichong Zhong > Signed-off-by: Jacob Chen > Signed-off-by: Eddie Cai > Signe

Re: [PATCH v8 05/14] media: rkisp1: add Rockchip ISP1 subdev driver

2019-08-07 Thread Hans Verkuil
On 8/6/19 8:51 PM, Helen Koike wrote: > Hi Hans, > > On 7/30/19 3:42 PM, Helen Koike wrote: >> From: Jacob Chen >> >> Add the subdev driver for rockchip isp1. >> >> Signed-off-by: Jacob Chen >> Signed-off-by: Shunqian Zheng >> Signed-off-by: Yichong Zhong >> Signed-off-by: Jacob Chen >> Signe

Re: [PATCH v8 05/14] media: rkisp1: add Rockchip ISP1 subdev driver

2019-08-06 Thread Helen Koike
Hi Hans, On 7/30/19 3:42 PM, Helen Koike wrote: > From: Jacob Chen > > Add the subdev driver for rockchip isp1. > > Signed-off-by: Jacob Chen > Signed-off-by: Shunqian Zheng > Signed-off-by: Yichong Zhong > Signed-off-by: Jacob Chen > Signed-off-by: Eddie Cai > Signed-off-by: Jeffy Chen >

[PATCH v8 05/14] media: rkisp1: add Rockchip ISP1 subdev driver

2019-07-30 Thread Helen Koike
From: Jacob Chen Add the subdev driver for rockchip isp1. Signed-off-by: Jacob Chen Signed-off-by: Shunqian Zheng Signed-off-by: Yichong Zhong Signed-off-by: Jacob Chen Signed-off-by: Eddie Cai Signed-off-by: Jeffy Chen Signed-off-by: Allon Huang Signed-off-by: Tomasz Figa [fixed unknown