Re: [PATCH v8 05/28] x86/mpx: Use signed variables to compute effective addresses

2017-08-31 Thread Borislav Petkov
On Wed, Aug 30, 2017 at 09:19:14PM -0700, Ricardo Neri wrote: > This is a good suggestion. I will work on it. By now my series comprises > 28 patches. If you plan to review the rest of the series and you don't > have major objections, could I work on these updates as increments from > my v8 series?

Re: [PATCH v8 05/28] x86/mpx: Use signed variables to compute effective addresses

2017-08-30 Thread Ricardo Neri
On Tue, 2017-08-29 at 18:09 +0200, Borislav Petkov wrote: > On Fri, Aug 18, 2017 at 05:27:46PM -0700, Ricardo Neri wrote: > > Even though memory addresses are unsigned, the operands used to compute the > > effective address do have a sign. This is true for ModRM.rm, SIB.base, > > SIB.index as well

Re: [PATCH v8 05/28] x86/mpx: Use signed variables to compute effective addresses

2017-08-29 Thread Borislav Petkov
On Fri, Aug 18, 2017 at 05:27:46PM -0700, Ricardo Neri wrote: > Even though memory addresses are unsigned, the operands used to compute the > effective address do have a sign. This is true for ModRM.rm, SIB.base, > SIB.index as well as the displacement bytes. Thus, signed variables shall > be used

[PATCH v8 05/28] x86/mpx: Use signed variables to compute effective addresses

2017-08-18 Thread Ricardo Neri
Even though memory addresses are unsigned, the operands used to compute the effective address do have a sign. This is true for ModRM.rm, SIB.base, SIB.index as well as the displacement bytes. Thus, signed variables shall be used when computing the effective address from these operands. Once the sig