Re: [PATCH v8 06/22] perf arm-spe: Refactor printing string to buffer

2020-11-11 Thread Leo Yan
Hi David, On Wed, Nov 11, 2020 at 11:03:47PM +, David Laight wrote: > From: Dave Martin > > Sent: 11 November 2020 17:58 > > > > On Wed, Nov 11, 2020 at 05:39:22PM +, Arnaldo Carvalho de Melo wrote: > > > Em Wed, Nov 11, 2020 at 03:45:23PM +, Andr� Przywara escreveu: > > > > On 11/1

Re: [PATCH v8 06/22] perf arm-spe: Refactor printing string to buffer

2020-11-11 Thread Leo Yan
On Wed, Nov 11, 2020 at 03:01:27PM -0300, Arnaldo Carvalho de Melo wrote: > Em Wed, Nov 11, 2020 at 05:58:27PM +, Dave Martin escreveu: > > > > On Wed, Nov 11, 2020 at 05:39:22PM +, Arnaldo Carvalho de Melo wrote: > > > Em Wed, Nov 11, 2020 at 03:45:23PM +, Andr� Przywara escreveu: >

RE: [PATCH v8 06/22] perf arm-spe: Refactor printing string to buffer

2020-11-11 Thread David Laight
From: Dave Martin > Sent: 11 November 2020 17:58 > > On Wed, Nov 11, 2020 at 05:39:22PM +, Arnaldo Carvalho de Melo wrote: > > Em Wed, Nov 11, 2020 at 03:45:23PM +, Andr� Przywara escreveu: > > > On 11/11/2020 15:35, Arnaldo Carvalho de Melo wrote: > > > > > > Hi Arnaldo, > > > > > > tha

Re: [PATCH v8 06/22] perf arm-spe: Refactor printing string to buffer

2020-11-11 Thread Arnaldo Carvalho de Melo
Em Wed, Nov 11, 2020 at 03:02:48PM -0300, Arnaldo Carvalho de Melo escreveu: > > I'll keep the series up to that point and will run my build tests, then > > push it publicly to acme/perf/core and you can go from there, ok? > > I've changed the BIT() to BIT_ULL() as Andre suggested and I'm testing

Re: [PATCH v8 06/22] perf arm-spe: Refactor printing string to buffer

2020-11-11 Thread Arnaldo Carvalho de Melo
Em Wed, Nov 11, 2020 at 03:01:27PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Wed, Nov 11, 2020 at 05:58:27PM +, Dave Martin escreveu: > > > > On Wed, Nov 11, 2020 at 05:39:22PM +, Arnaldo Carvalho de Melo wrote: > > > Em Wed, Nov 11, 2020 at 03:45:23PM +, Andr� Przywara escreveu

Re: [PATCH v8 06/22] perf arm-spe: Refactor printing string to buffer

2020-11-11 Thread Arnaldo Carvalho de Melo
Em Wed, Nov 11, 2020 at 05:58:27PM +, Dave Martin escreveu: > > On Wed, Nov 11, 2020 at 05:39:22PM +, Arnaldo Carvalho de Melo wrote: > > Em Wed, Nov 11, 2020 at 03:45:23PM +, Andr� Przywara escreveu: > > > On 11/11/2020 15:35, Arnaldo Carvalho de Melo wrote: > > > > Isn't this 'ret

Re: [PATCH v8 06/22] perf arm-spe: Refactor printing string to buffer

2020-11-11 Thread Dave Martin
On Wed, Nov 11, 2020 at 05:39:22PM +, Arnaldo Carvalho de Melo wrote: > Em Wed, Nov 11, 2020 at 03:45:23PM +, Andr� Przywara escreveu: > > On 11/11/2020 15:35, Arnaldo Carvalho de Melo wrote: > > > > Hi Arnaldo, > > > > thanks for taking a look! > > > > > Em Wed, Nov 11, 2020 at 03:1

Re: [PATCH v8 06/22] perf arm-spe: Refactor printing string to buffer

2020-11-11 Thread Arnaldo Carvalho de Melo
Em Wed, Nov 11, 2020 at 03:58:27PM +, Dave Martin escreveu: > On Wed, Nov 11, 2020 at 03:53:20PM +, Dave Martin wrote: > > On Wed, Nov 11, 2020 at 07:11:33AM +, Leo Yan wrote: > > > When outputs strings to the decoding buffer with function snprintf(), > > > SPE decoder needs to detects

Re: [PATCH v8 06/22] perf arm-spe: Refactor printing string to buffer

2020-11-11 Thread Arnaldo Carvalho de Melo
Em Wed, Nov 11, 2020 at 03:45:23PM +, André Przywara escreveu: > On 11/11/2020 15:35, Arnaldo Carvalho de Melo wrote: > > Hi Arnaldo, > > thanks for taking a look! > > > Em Wed, Nov 11, 2020 at 03:11:33PM +0800, Leo Yan escreveu: > >> When outputs strings to the decoding buffer with function

Re: [PATCH v8 06/22] perf arm-spe: Refactor printing string to buffer

2020-11-11 Thread Dave Martin
On Wed, Nov 11, 2020 at 03:53:20PM +, Dave Martin wrote: > On Wed, Nov 11, 2020 at 07:11:33AM +, Leo Yan wrote: > > When outputs strings to the decoding buffer with function snprintf(), > > SPE decoder needs to detects if any error returns from snprintf() and if > > so needs to directly bai

Re: [PATCH v8 06/22] perf arm-spe: Refactor printing string to buffer

2020-11-11 Thread Dave Martin
On Wed, Nov 11, 2020 at 07:11:33AM +, Leo Yan wrote: > When outputs strings to the decoding buffer with function snprintf(), > SPE decoder needs to detects if any error returns from snprintf() and if > so needs to directly bail out. If snprintf() returns success, it needs > to update buffer po

Re: [PATCH v8 06/22] perf arm-spe: Refactor printing string to buffer

2020-11-11 Thread André Przywara
On 11/11/2020 15:35, Arnaldo Carvalho de Melo wrote: Hi Arnaldo, thanks for taking a look! > Em Wed, Nov 11, 2020 at 03:11:33PM +0800, Leo Yan escreveu: >> When outputs strings to the decoding buffer with function snprintf(), >> SPE decoder needs to detects if any error returns from snprintf() a

Re: [PATCH v8 06/22] perf arm-spe: Refactor printing string to buffer

2020-11-11 Thread Arnaldo Carvalho de Melo
Em Wed, Nov 11, 2020 at 03:11:33PM +0800, Leo Yan escreveu: > When outputs strings to the decoding buffer with function snprintf(), > SPE decoder needs to detects if any error returns from snprintf() and if > so needs to directly bail out. If snprintf() returns success, it needs > to update buffer

[PATCH v8 06/22] perf arm-spe: Refactor printing string to buffer

2020-11-10 Thread Leo Yan
When outputs strings to the decoding buffer with function snprintf(), SPE decoder needs to detects if any error returns from snprintf() and if so needs to directly bail out. If snprintf() returns success, it needs to update buffer pointer and reduce the buffer length so can continue to output the