Re: [PATCH v8 07/12] gpio: palmas: add in GPIO support for palmas charger

2013-03-14 Thread Ian Lartey
On 13/03/13 14:15, Linus Walleij wrote: Sorry for slow replies :-( On Thu, Mar 7, 2013 at 2:17 PM, Ian Lartey wrote: +static int palmas_gpio_read(struct palmas *palmas, unsigned int reg, + int gpio, unsigned int *dest) I don't like "int gpio" here, please use "int offset". Th

Re: [PATCH v8 07/12] gpio: palmas: add in GPIO support for palmas charger

2013-03-13 Thread Linus Walleij
Sorry for slow replies :-( On Thu, Mar 7, 2013 at 2:17 PM, Ian Lartey wrote: > +static int palmas_gpio_read(struct palmas *palmas, unsigned int reg, > + int gpio, unsigned int *dest) I don't like "int gpio" here, please use "int offset". This is not a global GPIO number, it is an

[PATCH v8 07/12] gpio: palmas: add in GPIO support for palmas charger

2013-03-07 Thread Ian Lartey
Palmas charger has 16 GPIOs add palmas_gpio_[read|write|update] api to take account second bank of GPIOs Signed-off-by: Ian Lartey Signed-off-by: Graeme Gregory --- drivers/gpio/gpio-palmas.c | 77 include/linux/mfd/palmas.h | 12 ++- 2 files