Re: [PATCH v8 08/22] PCI, acpiphp: Separate out hot-add support of pci host bridge

2013-01-15 Thread Yinghai Lu
On Tue, Jan 15, 2013 at 2:00 PM, Rafael J. Wysocki wrote: > Do I understand correctly that you're asking whether to merge the attached > patches together, so as to obtain one combined patch? > > If so, yes, I'd like that to be done. good, will merge them for easy review. Thanks Yinghai -- To un

Re: [PATCH v8 08/22] PCI, acpiphp: Separate out hot-add support of pci host bridge

2013-01-15 Thread Rafael J. Wysocki
On Tuesday, January 15, 2013 07:54:22 AM Yinghai Lu wrote: > On Mon, Jan 14, 2013 at 10:44 PM, Yinghai Lu wrote: > > On Sat, Jan 12, 2013 at 3:18 PM, Rafael J. Wysocki wrote: > >>> @@ -673,3 +673,223 @@ int __init acpi_pci_root_init(void) > >>> > >>> return 0; > >>> } > >>> + > >>> +/* > >

Re: [PATCH v8 08/22] PCI, acpiphp: Separate out hot-add support of pci host bridge

2013-01-15 Thread Yinghai Lu
On Mon, Jan 14, 2013 at 10:44 PM, Yinghai Lu wrote: > On Sat, Jan 12, 2013 at 3:18 PM, Rafael J. Wysocki wrote: >>> @@ -673,3 +673,223 @@ int __init acpi_pci_root_init(void) >>> >>> return 0; >>> } >>> + >>> +/* >>> + * Separated from drivers/pci/hotplug/acpiphp_glue.c >>> + * only suppo

Re: [PATCH v8 08/22] PCI, acpiphp: Separate out hot-add support of pci host bridge

2013-01-14 Thread Yinghai Lu
On Sat, Jan 12, 2013 at 3:18 PM, Rafael J. Wysocki wrote: >> @@ -673,3 +673,223 @@ int __init acpi_pci_root_init(void) >> >> return 0; >> } >> + >> +/* >> + * Separated from drivers/pci/hotplug/acpiphp_glue.c >> + * only support root bridge >> + */ > > This comment will be useless after a

Re: [PATCH v8 08/22] PCI, acpiphp: Separate out hot-add support of pci host bridge

2013-01-12 Thread Rafael J. Wysocki
On Friday, January 11, 2013 02:40:35 PM Yinghai Lu wrote: > It causes confusion. > > We may only need acpi hp for pci host bridge. What does this mean? > Split host bridge hot-add support to pci_root_hp, and keep acpiphp simple. s/Split/Move/ I suppose? In any case that's not telling the whole

[PATCH v8 08/22] PCI, acpiphp: Separate out hot-add support of pci host bridge

2013-01-11 Thread Yinghai Lu
It causes confusion. We may only need acpi hp for pci host bridge. Split host bridge hot-add support to pci_root_hp, and keep acpiphp simple. -v2: put back pci_root_hp change in one patch -v3: add pcibios_resource_survey_bus() calling -v4: remove not needed code with remove_bridge -v5: put back