Re: [PATCH v8 08/50] virtio: memory access APIs

2014-12-02 Thread Prabhakar Lad
Hi Michael, Thanks for the patch. On Mon, Dec 1, 2014 at 4:03 PM, Michael S. Tsirkin wrote: > virtio 1.0 makes all memory structures LE, so [Snip] > +/* > + * Low-level memory accessors for handling virtio in modern little endian > and in > + * compatibility native endian format. > + */ > + >

Re: [PATCH v8 08/50] virtio: memory access APIs

2014-12-02 Thread Prabhakar Lad
Hi Michael, Thanks for the patch. On Mon, Dec 1, 2014 at 4:03 PM, Michael S. Tsirkin m...@redhat.com wrote: virtio 1.0 makes all memory structures LE, so [Snip] +/* + * Low-level memory accessors for handling virtio in modern little endian and in + * compatibility native endian format. +

[PATCH v8 08/50] virtio: memory access APIs

2014-12-01 Thread Michael S. Tsirkin
virtio 1.0 makes all memory structures LE, so we need APIs to conditionally do a byteswap on BE architectures. To make it easier to check code statically, add virtio specific types for multi-byte integers in memory. Add low level wrappers that do a byteswap conditionally, these will be useful

[PATCH v8 08/50] virtio: memory access APIs

2014-12-01 Thread Michael S. Tsirkin
virtio 1.0 makes all memory structures LE, so we need APIs to conditionally do a byteswap on BE architectures. To make it easier to check code statically, add virtio specific types for multi-byte integers in memory. Add low level wrappers that do a byteswap conditionally, these will be useful