Re: [PATCH v8 09/21] x86/paravirt: Align paravirt thunk functions at 16-byte boundaries

2015-07-28 Thread Josh Poimboeuf
On Tue, Jul 28, 2015 at 08:23:04AM -0700, Andy Lutomirski wrote: > On Tue, Jul 28, 2015 at 7:47 AM, Josh Poimboeuf wrote: > > Paravirt thunk functions aren't aligned, which can impact performance > > and is inconsistent with gcc-generated functions. > > > > Align them at 16-byte boundaries to be

Re: [PATCH v8 09/21] x86/paravirt: Align paravirt thunk functions at 16-byte boundaries

2015-07-28 Thread Andy Lutomirski
On Tue, Jul 28, 2015 at 7:47 AM, Josh Poimboeuf wrote: > Paravirt thunk functions aren't aligned, which can impact performance > and is inconsistent with gcc-generated functions. > > Align them at 16-byte boundaries to be consistent with gcc functions. IMO stackvalidate shouldn't warn about

[PATCH v8 09/21] x86/paravirt: Align paravirt thunk functions at 16-byte boundaries

2015-07-28 Thread Josh Poimboeuf
Paravirt thunk functions aren't aligned, which can impact performance and is inconsistent with gcc-generated functions. Align them at 16-byte boundaries to be consistent with gcc functions. Signed-off-by: Josh Poimboeuf --- arch/x86/include/asm/paravirt.h | 1 + 1 file changed, 1 insertion(+)

Re: [PATCH v8 09/21] x86/paravirt: Align paravirt thunk functions at 16-byte boundaries

2015-07-28 Thread Andy Lutomirski
On Tue, Jul 28, 2015 at 7:47 AM, Josh Poimboeuf jpoim...@redhat.com wrote: Paravirt thunk functions aren't aligned, which can impact performance and is inconsistent with gcc-generated functions. Align them at 16-byte boundaries to be consistent with gcc functions. IMO stackvalidate shouldn't

[PATCH v8 09/21] x86/paravirt: Align paravirt thunk functions at 16-byte boundaries

2015-07-28 Thread Josh Poimboeuf
Paravirt thunk functions aren't aligned, which can impact performance and is inconsistent with gcc-generated functions. Align them at 16-byte boundaries to be consistent with gcc functions. Signed-off-by: Josh Poimboeuf jpoim...@redhat.com --- arch/x86/include/asm/paravirt.h | 1 + 1 file

Re: [PATCH v8 09/21] x86/paravirt: Align paravirt thunk functions at 16-byte boundaries

2015-07-28 Thread Josh Poimboeuf
On Tue, Jul 28, 2015 at 08:23:04AM -0700, Andy Lutomirski wrote: On Tue, Jul 28, 2015 at 7:47 AM, Josh Poimboeuf jpoim...@redhat.com wrote: Paravirt thunk functions aren't aligned, which can impact performance and is inconsistent with gcc-generated functions. Align them at 16-byte