Re: [PATCH v8 1/2] PWM: atmel-pwm: add PWM controller driver

2013-12-11 Thread Thierry Reding
On Tue, Dec 10, 2013 at 10:20:33AM +0800, Bo Shen wrote: > Hi Thierry, > > On 12/03/2013 11:09 AM, Bo Shen wrote: > >>>+atmel_pwm->chip.of_xlate = of_pwm_xlate_with_flags; > >>>+atmel_pwm->chip.of_pwm_n_cells = 3; > >>>+atmel_pwm->chip.base = -1; > >>>+} else { > >>>+

Re: [PATCH v8 1/2] PWM: atmel-pwm: add PWM controller driver

2013-12-09 Thread Bo Shen
Hi Thierry, On 12/03/2013 11:09 AM, Bo Shen wrote: +atmel_pwm->chip.of_xlate = of_pwm_xlate_with_flags; +atmel_pwm->chip.of_pwm_n_cells = 3; +atmel_pwm->chip.base = -1; +} else { +atmel_pwm->chip.base = pdev->id; That's not correct. The chip cannot be tied t

Re: [PATCH v8 1/2] PWM: atmel-pwm: add PWM controller driver

2013-12-06 Thread Thierry Reding
On Thu, Dec 05, 2013 at 09:11:28AM +0800, Bo Shen wrote: > Hi Thierry, > > On 12/04/2013 06:03 PM, Thierry Reding wrote: > >On Wed, Dec 04, 2013 at 10:59:46AM +0800, Bo Shen wrote: > >>Hi Thierry, > >> > >>On 12/03/2013 05:43 PM, Thierry Reding wrote: > >>>On Tue, Dec 03, 2013 at 11:09:12AM +0800,

Re: [PATCH v8 1/2] PWM: atmel-pwm: add PWM controller driver

2013-12-04 Thread Bo Shen
Hi Thierry, On 12/04/2013 06:03 PM, Thierry Reding wrote: On Wed, Dec 04, 2013 at 10:59:46AM +0800, Bo Shen wrote: Hi Thierry, On 12/03/2013 05:43 PM, Thierry Reding wrote: On Tue, Dec 03, 2013 at 11:09:12AM +0800, Bo Shen wrote: On 12/02/2013 06:59 PM, Thierry Reding wrote: On Mon, Nov 18,

Re: [PATCH v8 1/2] PWM: atmel-pwm: add PWM controller driver

2013-12-04 Thread Thierry Reding
On Wed, Dec 04, 2013 at 10:59:46AM +0800, Bo Shen wrote: > Hi Thierry, > > On 12/03/2013 05:43 PM, Thierry Reding wrote: > >On Tue, Dec 03, 2013 at 11:09:12AM +0800, Bo Shen wrote: > >>On 12/02/2013 06:59 PM, Thierry Reding wrote: > >>>On Mon, Nov 18, 2013 at 05:13:21PM +0800, Bo Shen wrote: > >[.

Re: [PATCH v8 1/2] PWM: atmel-pwm: add PWM controller driver

2013-12-03 Thread Bo Shen
Hi Thierry, On 12/03/2013 05:43 PM, Thierry Reding wrote: On Tue, Dec 03, 2013 at 11:09:12AM +0800, Bo Shen wrote: On 12/02/2013 06:59 PM, Thierry Reding wrote: On Mon, Nov 18, 2013 at 05:13:21PM +0800, Bo Shen wrote: [...] diff --git a/drivers/pwm/pwm-atmel.c b/drivers/pwm/pwm-atmel.c [...

Re: [PATCH v8 1/2] PWM: atmel-pwm: add PWM controller driver

2013-12-03 Thread Thierry Reding
On Tue, Dec 03, 2013 at 11:09:12AM +0800, Bo Shen wrote: > On 12/02/2013 06:59 PM, Thierry Reding wrote: > >On Mon, Nov 18, 2013 at 05:13:21PM +0800, Bo Shen wrote: [...] > >>diff --git a/drivers/pwm/pwm-atmel.c b/drivers/pwm/pwm-atmel.c [...] > >>+ /* Calculate the period cycles */ > >>+ while

Re: [PATCH v8 1/2] PWM: atmel-pwm: add PWM controller driver

2013-12-02 Thread Bo Shen
Hi Thierry, On 12/02/2013 06:59 PM, Thierry Reding wrote: On Mon, Nov 18, 2013 at 05:13:21PM +0800, Bo Shen wrote: [...] diff --git a/drivers/pwm/pwm-atmel.c b/drivers/pwm/pwm-atmel.c [...] +/* Max value for duty and period Block comments should be of this form: /* * Max v

Re: [PATCH v8 1/2] PWM: atmel-pwm: add PWM controller driver

2013-12-02 Thread Thierry Reding
On Mon, Nov 18, 2013 at 05:13:21PM +0800, Bo Shen wrote: [...] > diff --git a/drivers/pwm/pwm-atmel.c b/drivers/pwm/pwm-atmel.c [...] > +/* Max value for duty and period Block comments should be of this form: /* * Max value ... * ... */ > +static int atmel_pwm_

Re: [PATCH v8 1/2] PWM: atmel-pwm: add PWM controller driver

2013-12-02 Thread Bo Shen
Hi Thierry, On 11/18/2013 05:13 PM, Bo Shen wrote: Add Atmel PWM controller driver based on PWM framework. This is the basic function implementation of Atmel PWM controller. It can work with PWM based led and backlight. Signed-off-by: Bo Shen Acked-by: Alexandre Belloni Acked-by: Jean-Chris

[PATCH v8 1/2] PWM: atmel-pwm: add PWM controller driver

2013-11-18 Thread Bo Shen
Add Atmel PWM controller driver based on PWM framework. This is the basic function implementation of Atmel PWM controller. It can work with PWM based led and backlight. Signed-off-by: Bo Shen Acked-by: Alexandre Belloni Acked-by: Jean-Christophe PLAGNIOL-VILLARD --- Changes in v8: - replace