Re: [PATCH v8 1/5] tpm_tis: Improve reporting of IO errors

On Sat, Jun 25, 2016 at 06:47:45PM +0300, Jarkko Sakkinen wrote: > My repositories are ready for next pull request. The master has been > rebased to James' tree and merged to next. This seems fine.. Generally you shouldn't rebase to create pull requests, but this seemed needed.. Organize your

Re: [PATCH v8 1/5] tpm_tis: Improve reporting of IO errors

On Sat, Jun 25, 2016 at 06:47:45PM +0300, Jarkko Sakkinen wrote: > My repositories are ready for next pull request. The master has been > rebased to James' tree and merged to next. This seems fine.. Generally you shouldn't rebase to create pull requests, but this seemed needed.. Organize your

Re: [PATCH v8 1/5] tpm_tis: Improve reporting of IO errors

On Sat, Jun 25, 2016 at 06:24:30PM +0300, Jarkko Sakkinen wrote: > On Fri, Jun 24, 2016 at 02:26:15PM -0600, Jason Gunthorpe wrote: > > On Fri, Jun 24, 2016 at 11:21:31PM +0300, Jarkko Sakkinen wrote: > > > Hmm... Do you mean by 4 month old stuff the stuff that is in mainline > > > and not in my

Re: [PATCH v8 1/5] tpm_tis: Improve reporting of IO errors

On Sat, Jun 25, 2016 at 06:24:30PM +0300, Jarkko Sakkinen wrote: > On Fri, Jun 24, 2016 at 02:26:15PM -0600, Jason Gunthorpe wrote: > > On Fri, Jun 24, 2016 at 11:21:31PM +0300, Jarkko Sakkinen wrote: > > > Hmm... Do you mean by 4 month old stuff the stuff that is in mainline > > > and not in my

Re: [PATCH v8 1/5] tpm_tis: Improve reporting of IO errors

On Fri, Jun 24, 2016 at 02:26:15PM -0600, Jason Gunthorpe wrote: > On Fri, Jun 24, 2016 at 11:21:31PM +0300, Jarkko Sakkinen wrote: > > Hmm... Do you mean by 4 month old stuff the stuff that is in mainline > > and not in my master branch? > > I mean the stuff that is in your branch but not in

Re: [PATCH v8 1/5] tpm_tis: Improve reporting of IO errors

On Fri, Jun 24, 2016 at 02:26:15PM -0600, Jason Gunthorpe wrote: > On Fri, Jun 24, 2016 at 11:21:31PM +0300, Jarkko Sakkinen wrote: > > Hmm... Do you mean by 4 month old stuff the stuff that is in mainline > > and not in my master branch? > > I mean the stuff that is in your branch but not in

Re: [PATCH v8 1/5] tpm_tis: Improve reporting of IO errors

On Fri, Jun 24, 2016 at 11:21:31PM +0300, Jarkko Sakkinen wrote: > Hmm... Do you mean by 4 month old stuff the stuff that is in mainline > and not in my master branch? I mean the stuff that is in your branch but not in mainline. $ git log --pretty=oneline jarkko/master ^v4.7-rc3 | wc -l 73 >

Re: [PATCH v8 1/5] tpm_tis: Improve reporting of IO errors

On Fri, Jun 24, 2016 at 11:21:31PM +0300, Jarkko Sakkinen wrote: > Hmm... Do you mean by 4 month old stuff the stuff that is in mainline > and not in my master branch? I mean the stuff that is in your branch but not in mainline. $ git log --pretty=oneline jarkko/master ^v4.7-rc3 | wc -l 73 >

Re: [PATCH v8 1/5] tpm_tis: Improve reporting of IO errors

On Fri, Jun 24, 2016 at 11:21:31PM +0300, Jarkko Sakkinen wrote: > Hi Jason, > > On Fri, Jun 24, 2016 at 12:25:15PM -0600, Jason Gunthorpe wrote: > > > expected = be32_to_cpu(*(__be32 *) (buf + 2)); > > > if (expected > count) { > > > + dev_err(chip->pdev, "Response too long (wanted

Re: [PATCH v8 1/5] tpm_tis: Improve reporting of IO errors

On Fri, Jun 24, 2016 at 11:21:31PM +0300, Jarkko Sakkinen wrote: > Hi Jason, > > On Fri, Jun 24, 2016 at 12:25:15PM -0600, Jason Gunthorpe wrote: > > > expected = be32_to_cpu(*(__be32 *) (buf + 2)); > > > if (expected > count) { > > > + dev_err(chip->pdev, "Response too long (wanted

Re: [PATCH v8 1/5] tpm_tis: Improve reporting of IO errors

Hi Jason, On Fri, Jun 24, 2016 at 12:25:15PM -0600, Jason Gunthorpe wrote: > > expected = be32_to_cpu(*(__be32 *) (buf + 2)); > > if (expected > count) { > > + dev_err(chip->pdev, "Response too long (wanted %zd, got %d)\n", > > + count, expected); > > This all

Re: [PATCH v8 1/5] tpm_tis: Improve reporting of IO errors

Hi Jason, On Fri, Jun 24, 2016 at 12:25:15PM -0600, Jason Gunthorpe wrote: > > expected = be32_to_cpu(*(__be32 *) (buf + 2)); > > if (expected > count) { > > + dev_err(chip->pdev, "Response too long (wanted %zd, got %d)\n", > > + count, expected); > > This all

Re: [PATCH v8 1/5] tpm_tis: Improve reporting of IO errors

> expected = be32_to_cpu(*(__be32 *) (buf + 2)); > if (expected > count) { > + dev_err(chip->pdev, "Response too long (wanted %zd, got %d)\n", > + count, expected); This all needs to be rebased on Jarkko's tree I guess, chip->pdev is gone now.

Re: [PATCH v8 1/5] tpm_tis: Improve reporting of IO errors

> expected = be32_to_cpu(*(__be32 *) (buf + 2)); > if (expected > count) { > + dev_err(chip->pdev, "Response too long (wanted %zd, got %d)\n", > + count, expected); This all needs to be rebased on Jarkko's tree I guess, chip->pdev is gone now.

[PATCH v8 1/5] tpm_tis: Improve reporting of IO errors

Mysterious TPM behavior can be difficult to track down through all the layers of software. Add error messages for conditions that should never happen. Also include the manufacturer ID along with other chip data printed during init. Signed-off-by: Ed Swierk

[PATCH v8 1/5] tpm_tis: Improve reporting of IO errors

Mysterious TPM behavior can be difficult to track down through all the layers of software. Add error messages for conditions that should never happen. Also include the manufacturer ID along with other chip data printed during init. Signed-off-by: Ed Swierk Reviewed-by: Jarkko Sakkinen ---