Re: [PATCH v8 10/11] mtd: Support kmsg dumper based on pstore/blk

2020-05-11 Thread WeiXiong Liao
hi Kees Cook, On 2020/5/12 下午1:12, Kees Cook wrote: > [resend to proper CC list...] > > On Tue, May 12, 2020 at 11:12:42AM +0800, WeiXiong Liao wrote: >> hi Kees Cook, >> >> The off parameter on mtdpsore_block*() does not align to block size, >> which makes some bugs. For example, a block contain

Re: [PATCH v8 10/11] mtd: Support kmsg dumper based on pstore/blk

2020-05-11 Thread Kees Cook
[resend to proper CC list...] On Tue, May 12, 2020 at 11:12:42AM +0800, WeiXiong Liao wrote: > hi Kees Cook, > > The off parameter on mtdpsore_block*() does not align to block size, > which makes some bugs. For example, a block contains 4 dmesg zones > and it's expected to erase this block when u

Re: [PATCH v8 10/11] mtd: Support kmsg dumper based on pstore/blk

2020-05-11 Thread WeiXiong Liao
hi Kees Cook, The off parameter on mtdpsore_block*() does not align to block size, which makes some bugs. For example, a block contains 4 dmesg zones and it's expected to erase this block when user remove all files on these zones. However it work failed since it get wrongly zonenum from misaligned

[PATCH v8 10/11] mtd: Support kmsg dumper based on pstore/blk

2020-05-11 Thread Kees Cook
From: WeiXiong Liao This introduces mtdpstore, which is similar to mtdoops but more powerful. It uses pstore/blk, and aims to store panic and oops logs to a flash partition, where pstore can later read back and present as files in the mounted pstore filesystem. To make mtdpstore work, the "blkde