Re: [PATCH v8 2/2] Add PWM fan controller driver for LGM SoC

2020-08-21 Thread Andy Shevchenko
On Fri, Aug 21, 2020 at 05:14:29PM +0800, Tanwar, Rahul wrote: > On 20/8/2020 6:52 pm, Andy Shevchenko wrote: > > On Thu, Aug 20, 2020 at 12:50:46PM +0800, Rahul Tanwar wrote: > >> Intel Lightning Mountain(LGM) SoC contains a PWM fan controller. > >> This PWM controller does not have any other

Re: [PATCH v8 2/2] Add PWM fan controller driver for LGM SoC

2020-08-21 Thread Tanwar, Rahul
On 20/8/2020 6:52 pm, Andy Shevchenko wrote: > On Thu, Aug 20, 2020 at 12:50:46PM +0800, Rahul Tanwar wrote: >> Intel Lightning Mountain(LGM) SoC contains a PWM fan controller. >> This PWM controller does not have any other consumer, it is a >> dedicated PWM controller for fan attached to the

Re: [PATCH v8 2/2] Add PWM fan controller driver for LGM SoC

2020-08-21 Thread Andy Shevchenko
On Fri, Aug 21, 2020 at 02:07:49PM +0800, Tanwar, Rahul wrote: > On 20/8/2020 6:52 pm, Andy Shevchenko wrote: > > On Thu, Aug 20, 2020 at 12:50:46PM +0800, Rahul Tanwar wrote: ... > >> + ret = clk_prepare_enable(pc->clk); > > Wrap it with devm_add_action_or_reset(). Same for

Re: [PATCH v8 2/2] Add PWM fan controller driver for LGM SoC

2020-08-21 Thread Tanwar, Rahul
Hi Andy, On 20/8/2020 6:52 pm, Andy Shevchenko wrote: > On Thu, Aug 20, 2020 at 12:50:46PM +0800, Rahul Tanwar wrote: >> Intel Lightning Mountain(LGM) SoC contains a PWM fan controller. >> This PWM controller does not have any other consumer, it is a >> dedicated PWM controller for fan attached

Re: [PATCH v8 2/2] Add PWM fan controller driver for LGM SoC

2020-08-20 Thread Andy Shevchenko
On Thu, Aug 20, 2020 at 12:50:46PM +0800, Rahul Tanwar wrote: > Intel Lightning Mountain(LGM) SoC contains a PWM fan controller. > This PWM controller does not have any other consumer, it is a > dedicated PWM controller for fan attached to the system. Add > driver for this PWM fan controller. ...

[PATCH v8 2/2] Add PWM fan controller driver for LGM SoC

2020-08-19 Thread Rahul Tanwar
Intel Lightning Mountain(LGM) SoC contains a PWM fan controller. This PWM controller does not have any other consumer, it is a dedicated PWM controller for fan attached to the system. Add driver for this PWM fan controller. Signed-off-by: Rahul Tanwar --- drivers/pwm/Kconfig | 11 ++