Re: [PATCH v8 2/2] drivers/gpio: Altera soft IP GPIO driver

2015-03-05 Thread Linus Walleij
On Wed, Feb 11, 2015 at 9:20 AM, Tien Hock Loh wrote: >> > These calls seem like pretty vanilla generic GPIO functions. >> > Use GENERIC_GPIO with bgpio_init() and override the default >> > functions only when really needed. >> > >> > See e.g. drivers/gpio/gpio-74xx-mmio.c >> > >> OK, I'll update

Re: [PATCH v8 2/2] drivers/gpio: Altera soft IP GPIO driver

2015-02-11 Thread Tien Hock Loh
On Thu, 2015-02-05 at 18:54 -0800, Tien Hock Loh wrote: > On Wed, 2015-01-14 at 10:58 +0100, Linus Walleij wrote: > > On Wed, Dec 24, 2014 at 9:22 AM, wrote: > > > > > From: Tien Hock Loh > > > > > > Adds a new driver for Altera soft GPIO IP. The driver is able to > > > do read/write and allows

Re: [PATCH v8 2/2] drivers/gpio: Altera soft IP GPIO driver

2015-02-05 Thread Tien Hock Loh
On Wed, 2015-01-14 at 10:58 +0100, Linus Walleij wrote: > On Wed, Dec 24, 2014 at 9:22 AM, wrote: > > > From: Tien Hock Loh > > > > Adds a new driver for Altera soft GPIO IP. The driver is able to > > do read/write and allows GPIO to be a interrupt controller. > > > > Tested on Altera GHRD on i

Re: [PATCH v8 2/2] drivers/gpio: Altera soft IP GPIO driver

2015-02-05 Thread Tien Hock Loh
On Wed, 2014-12-24 at 03:04 -0800, Joe Perches wrote: > On Wed, 2014-12-24 at 00:22 -0800, th...@altera.com wrote: > > Adds a new driver for Altera soft GPIO IP. The driver is able to > > do read/write and allows GPIO to be a interrupt controller. > > Some trivial comments, some not quite so trivi

Re: [PATCH v8 2/2] drivers/gpio: Altera soft IP GPIO driver

2015-01-14 Thread Linus Walleij
On Wed, Dec 24, 2014 at 9:22 AM, wrote: > From: Tien Hock Loh > > Adds a new driver for Altera soft GPIO IP. The driver is able to > do read/write and allows GPIO to be a interrupt controller. > > Tested on Altera GHRD on interrupt handling and IO. > > Signed-off-by: Tien Hock Loh (...) > +co

Re: [PATCH v8 2/2] drivers/gpio: Altera soft IP GPIO driver

2014-12-24 Thread Joe Perches
On Wed, 2014-12-24 at 00:22 -0800, th...@altera.com wrote: > Adds a new driver for Altera soft GPIO IP. The driver is able to > do read/write and allows GPIO to be a interrupt controller. Some trivial comments, some not quite so trivial. > diff --git a/drivers/gpio/gpio-altera.c b/drivers/gpio/gp

[PATCH v8 2/2] drivers/gpio: Altera soft IP GPIO driver

2014-12-24 Thread thloh
From: Tien Hock Loh Adds a new driver for Altera soft GPIO IP. The driver is able to do read/write and allows GPIO to be a interrupt controller. Tested on Altera GHRD on interrupt handling and IO. Signed-off-by: Tien Hock Loh --- MAINTAINERS|6 + drivers/gpio/Kconfig