Re: [PATCH v8 2/3] gpio: mmio: add DT support for memory-mapped GPIOs

2016-05-10 Thread Christian Lamparter
On Tuesday, May 10, 2016 02:08:45 PM Linus Walleij wrote: > On Sun, May 8, 2016 at 3:08 PM, Christian Lamparter > wrote: > > > From: Álvaro Fernández Rojas > > > > This patch adds support for defining memory-mapped GPIOs which > > are compatible with

Re: [PATCH v8 2/3] gpio: mmio: add DT support for memory-mapped GPIOs

2016-05-10 Thread Christian Lamparter
On Tuesday, May 10, 2016 02:08:45 PM Linus Walleij wrote: > On Sun, May 8, 2016 at 3:08 PM, Christian Lamparter > wrote: > > > From: Álvaro Fernández Rojas > > > > This patch adds support for defining memory-mapped GPIOs which > > are compatible with the existing gpio-mmio interface. > >

Re: [PATCH v8 2/3] gpio: mmio: add DT support for memory-mapped GPIOs

2016-05-10 Thread Linus Walleij
On Sun, May 8, 2016 at 3:08 PM, Christian Lamparter wrote: > From: Álvaro Fernández Rojas > > This patch adds support for defining memory-mapped GPIOs which > are compatible with the existing gpio-mmio interface. Overall very nice, just waiting for

Re: [PATCH v8 2/3] gpio: mmio: add DT support for memory-mapped GPIOs

2016-05-10 Thread Linus Walleij
On Sun, May 8, 2016 at 3:08 PM, Christian Lamparter wrote: > From: Álvaro Fernández Rojas > > This patch adds support for defining memory-mapped GPIOs which > are compatible with the existing gpio-mmio interface. Overall very nice, just waiting for the next version. > The first user for this

Re: [PATCH v8 2/3] gpio: mmio: add DT support for memory-mapped GPIOs

2016-05-08 Thread Christian Lamparter
On Sunday, May 08, 2016 07:17:13 PM Joachim Eastwood wrote: > > +#define ADD(_name, _func) { .compatible = _name, .data = _func } > > I don't see the point in having a macro for such a simple data > structure, but since this v8 and Linus hasn't complained I guess it's > fine. > > Using a macro

Re: [PATCH v8 2/3] gpio: mmio: add DT support for memory-mapped GPIOs

2016-05-08 Thread Christian Lamparter
On Sunday, May 08, 2016 07:17:13 PM Joachim Eastwood wrote: > > +#define ADD(_name, _func) { .compatible = _name, .data = _func } > > I don't see the point in having a macro for such a simple data > structure, but since this v8 and Linus hasn't complained I guess it's > fine. > > Using a macro

Re: [PATCH v8 2/3] gpio: mmio: add DT support for memory-mapped GPIOs

2016-05-08 Thread Joachim Eastwood
Hi Christian, On 8 May 2016 at 15:08, Christian Lamparter wrote: > From: Álvaro Fernández Rojas > > This patch adds support for defining memory-mapped GPIOs which > are compatible with the existing gpio-mmio interface. The generic > library provides

Re: [PATCH v8 2/3] gpio: mmio: add DT support for memory-mapped GPIOs

2016-05-08 Thread Joachim Eastwood
Hi Christian, On 8 May 2016 at 15:08, Christian Lamparter wrote: > From: Álvaro Fernández Rojas > > This patch adds support for defining memory-mapped GPIOs which > are compatible with the existing gpio-mmio interface. The generic > library provides support for many memory-mapped GPIO

[PATCH v8 2/3] gpio: mmio: add DT support for memory-mapped GPIOs

2016-05-08 Thread Christian Lamparter
From: Álvaro Fernández Rojas This patch adds support for defining memory-mapped GPIOs which are compatible with the existing gpio-mmio interface. The generic library provides support for many memory-mapped GPIO controllers that are found in various on-board FPGA and ASIC

[PATCH v8 2/3] gpio: mmio: add DT support for memory-mapped GPIOs

2016-05-08 Thread Christian Lamparter
From: Álvaro Fernández Rojas This patch adds support for defining memory-mapped GPIOs which are compatible with the existing gpio-mmio interface. The generic library provides support for many memory-mapped GPIO controllers that are found in various on-board FPGA and ASIC solutions that are used