Hi Andy,
Sorry for the late reply.
On Thu, 8 Feb 2018 20:18:47 +0800
Andy Yan wrote:
> From: Shawn Lin
Commit message please.
>
> Add Rockchip SFC(serial flash controller) driver.
>
> Signed-off-by: Shawn Lin
> Signed-off-by: Andy Yan
> Acked-by: Marek Vasut
>
> ---
>
> Changes in v8
Hi Andy,
Just a very minor nit.
On 8 February 2018 at 09:18, Andy Yan wrote:
[..]
> +
> +static int get_if_type(struct rockchip_sfc *sfc, enum spi_nor_protocol proto)
> +{
I understand that this got copy-pasted from some other driver,
but please change this function name to something like
rockc
Hi Andy, Shawn,
I saw mention of DMA while skimming through LAKML, so you win a drive-by
review :)
On 08/02/18 12:18, Andy Yan wrote:
From: Shawn Lin
Add Rockchip SFC(serial flash controller) driver.
Signed-off-by: Shawn Lin
Signed-off-by: Andy Yan
Acked-by: Marek Vasut
---
Changes in
Hi Andy,
Am Sonntag, 8. April 2018, 14:08:45 CEST schrieb Andy Yan:
> ping
We're in the middle of the merge-window right now, so I do guess
maintainers will possibly do other things than looking at new code.
But you might want to address the kbuild-robot issue and resend
in the meantime, as some
Hi Shawn,
I love your patch! Perhaps something to improve:
[auto build test WARNING on robh/for-next]
[also build test WARNING on v4.15 next-20180209]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/com
From: Shawn Lin
Add Rockchip SFC(serial flash controller) driver.
Signed-off-by: Shawn Lin
Signed-off-by: Andy Yan
Acked-by: Marek Vasut
---
Changes in v8:
- remove unused macro SFC_CMD_TRAN_BYTES_MASK
- set max transfer length to 15.5KB
- remove unnecessary buffer align check
- remove the
6 matches
Mail list logo
