Re: [PATCH v8 2/3] phy: zynqmp: Add PHY driver for the Xilinx ZynqMP Gigabit Transceiver

2020-06-24 Thread Michal Simek
Hi Laurent and Vinod, On 24. 06. 20 23:14, Laurent Pinchart wrote: > Hi Vinod, > > On Wed, Jun 24, 2020 at 10:56:35PM +0530, Vinod Koul wrote: >> On 24-06-20, 19:39, Laurent Pinchart wrote: >> > +/* Number of GT lanes */ > +#define NUM_LANES4 Should this

Re: [PATCH v8 2/3] phy: zynqmp: Add PHY driver for the Xilinx ZynqMP Gigabit Transceiver

2020-06-24 Thread Laurent Pinchart
Hi Vinod, On Wed, Jun 24, 2020 at 10:56:35PM +0530, Vinod Koul wrote: > On 24-06-20, 19:39, Laurent Pinchart wrote: > > > > > +/* Number of GT lanes */ > > > > +#define NUM_LANES 4 > > > > > > Should this be coded in driver like this? Maybe future versions of > > > hardware

Re: [PATCH v8 2/3] phy: zynqmp: Add PHY driver for the Xilinx ZynqMP Gigabit Transceiver

2020-06-24 Thread Vinod Koul
Hi Laurent, On 24-06-20, 19:39, Laurent Pinchart wrote: > > > +/* Number of GT lanes */ > > > +#define NUM_LANES4 > > > > Should this be coded in driver like this? Maybe future versions of > > hardware will have more lanes..? Why not describe this in DT? > > This macro i

Re: [PATCH v8 2/3] phy: zynqmp: Add PHY driver for the Xilinx ZynqMP Gigabit Transceiver

2020-06-24 Thread Laurent Pinchart
Hi Vinod, On Wed, Jun 24, 2020 at 08:41:21PM +0530, Vinod Koul wrote: > Hi Laurent, > > Mostly this looks fine to me, some minor nitpicks below: > > On 13-05-20, 20:22, Laurent Pinchart wrote: > > +config PHY_XILINX_ZYNQMP > > + tristate "Xilinx ZynqMP PHY driver" > > + depends on ARCH_ZYNQM

Re: [PATCH v8 2/3] phy: zynqmp: Add PHY driver for the Xilinx ZynqMP Gigabit Transceiver

2020-06-24 Thread Vinod Koul
Hi Laurent, Mostly this looks fine to me, some minor nitpicks below: On 13-05-20, 20:22, Laurent Pinchart wrote: > +config PHY_XILINX_ZYNQMP > + tristate "Xilinx ZynqMP PHY driver" > + depends on ARCH_ZYNQMP Can we add COMPILE_TEST here so that this driver gets wider compile coverage? >

[PATCH v8 2/3] phy: zynqmp: Add PHY driver for the Xilinx ZynqMP Gigabit Transceiver

2020-05-13 Thread Laurent Pinchart
From: Anurag Kumar Vulisha Xilinx ZynqMP SoCs have a Gigabit Transceiver with four lanes. All the high speed peripherals such as USB, SATA, PCIE, Display Port and Ethernet SGMII can rely on any of the four GT lanes for PHY layer. This patch adds driver for that ZynqMP GT core. Signed-off-by: Anu